/contrib/cvs/src/ChangeLog

https://bitbucket.org/freebsd/freebsd-head/ · #! · 9664 lines · 6783 code · 2881 blank · 0 comment · 0 complexity · 121f3c566953393dafe8cd5be2bc2480 MD5 · raw file

Large files are truncated click here to view the full file

    

  1. 2008-03-10  Mark D. Baushke  <mdb@gnu.org>
    2. 

  2. 

  3. 	* mkmodules.c, parseinfo.c: Update copyright.
    4. 

  4. 

  5. 	* parseinfo.c (parse_config): Add support for new
    6. 

  6. 	"IgnoreUnknownConfigKeys" configuration key.
    7. 

  7. 	* mkmodules.c (config_contents): Add text about the
    8. 

  8. 	"IgnoreUnknownConfigKeys" option.
    9. 

  9. 	* sanity.sh (config): Test that IgnoreUnknownConfigKeys=yes works.
    10. 

  10. 

  11. 2008-01-30  Derek R. Price  <derek@ximbiot.com>
    12. 

  12. 

  13. 	* update.c (join_file): Use local copy to detect deletion conflicts,
    14. 

  14. 	as opposed to the base revision.  Restore freeing of rev2 to its
    15. 

  15. 	original location.  Use simpler conflict message.
    16. 

  16. 	* sanity.sh: Update to compensate.
    17. 

  17. 

  18. 2008-01-29  Derek R. Price  <derek@ximbiot.com>
    19. 

  19. 

  20. 	* update.c (join_file): Remove trace that is no longer needed.
    21. 

  21. 

  22. 2008-01-29  Derek R. Price  <derek@ximbiot.com>
    23. 

  23. 	    Paul Edwards  <fight.subjugation@gmail.com>
    24. 

  24. 

  25. 	* update.c (join_file): Detect deletion conflicts.
    26. 

  26. 	* sanity.sh (join, join4): Adjusted for this fix.
    27. 

  27. 	  (join8, join9): Add new tests for conflicts.
    28. 

  28. 

  29. 2008-01-27  Mark D. Baushke  <mdb@gnu.org>
    30. 

  30. 

  31. 	* filesubr.c (xreadlink): s/128/BUFSIZ/ avoid magic numbers.
    32. 

  32. 

  33. 	* client.c (start_rsh_server): Use CVS_SSH for the :extssh:
    34. 

  34. 	method or fall back to "ssh" as set using the --with-ssh flag to
    35. 

  35. 	configure.
    36. 

  36. 

  37. 	* client.h, log.c, main.c, recurse.c, root.c: Update copyright for
    38. 

  38. 	2008.
    39. 

  39. 

  40. 2008-01-24  Mark D. Baushke  <mdb@gnu.org>
    41. 

  41. 

  42. 	* log.c (cvslog): New -n option to revert the -N switch.
    43. 

  43. 	(log_usage): Add -n to the help string.
    44. 

  44. 	* main.c (cmds[]): Add "blame" as a synonym for the
    45. 

  45. 	"annotate" command.
    46. 

  46. 	* sanity.sh (cvs-log): New tests for 'cvs log -N -n' validation.
    47. 

  47. 	(ann-10w1blame): Test the 'cvs blame' synonym for annotate.
    48. 

  48. 	(Patch suggested by "David O'Brien" <obrien@FreeBSD.org>)
    49. 

  49. 

  50. 	* edit.c (notify_check): Rename to...
    51. 

  51. 	(cvs_notify_check): ...this to avoid Mac OSX symbol conflicts.
    52. 

  52. 	* client.h, edit.h, recurse.c: Change all references.
    53. 

  53. 

  54. 	* client.c (start_rsh_server): Use RSH_DFLT not a hardcoded "rsh"
    55. 

  55. 	* root.c (parse_cvsroot): Fix parsing for the :extssh: method.
    56. 

  56. 

  57. 	* sanity.sh (expr_set_DASHDASH): Fix for non-POSIX expr
    58. 

  58. 	implementations.
    59. 

  59. 	(CVSROOTDIR): Use 'cvsrootdir' instead of 'cvsroot' to
    60. 

  60. 	avoid problems on case preserving and/or case insensitive
    61. 

  61. 	filesystems (e.g., HFS+).
    62. 

  62. 	(CVSROOT_DIRNAME): Use ${TESTDIR}/${CVSROOTDIR} instead of
    63. 

  63. 	${TESTDIR}/cvsroot to avoid filesystem case sensitivity problems.
    64. 

  64. 	(crerepos-extssh): Clone of crerepos tests, but use the :extssh:
    65. 

  65. 	method.
    66. 

  66. 

  67. 2007-12-19  Larry Jones  <lawrence.jones@siemens.com>
    68. 

  68. 

  69. 	* client.c, import.c, lock.c, login.c, mkmodules.c, modules.c,
    70. 

  70. 	rcs.c, server.c: Fix gcc -Wall warnings.
    71. 

  71. 

  72. 2007-12-16  Larry Jones  <lawrence.jones@siemens.com>
    73. 

  73. 

  74. 	* rcs.c (HAVE_MMAP): Fall back to stdio if mmap fails.
    75. 

  75. 

  76. 2007-12-13  Larry Jones  <lawrence.jones@siemens.com>
    77. 

  77. 

  78. 	* rcs.c (rcsbuf_ftell): Avoid potential overflow.
    79. 

  79. 

  80. 2007-12-12  Larry Jones  <lawrence.jones@siemens.com>
    81. 

  81. 

  82. 	* vers_ts.c (time_stamp): Add warnings for [l]stat failures
    83. 

  83. 	other than no such file.
    84. 

  84. 

  85. 2007-08-26  Derek Price  <derek@ximbiot.com>
    86. 

  86. 

  87. 	* mkmodules.c (in_root): Rename to...
    88. 

  88. 	(in_repository): ...this.
    89. 

  89. 

  90. 2007-08-26  Larry Jones  <lawrence.jones@ugs.com>
    91. 

  91. 

  92. 	* mkmodules.c (in_root, init): Unmix declarations and code.
    93. 

  93. 

  94. 2007-08-22  Derek Price  <derek@ximbiot.com>
    95. 

  95. 

  96. 	* add.c (add): Check last component of argument paths instead of the
    97. 

  97. 	entire argument.
    98. 

  98. 	* sanity.sh (add-restricted): Test indirect paths to `CVS' dir with
    99. 

  99. 	add.
    100. 

    101. 

  101. 	* server.c (serve_init): Remove unnecessary argument to printf style
    102. 

  102. 	function.
    103. 

    104. 

  104. 	* mkmodules.c (in_root): New function.
    105. 

  105. 	(init): Verify that new roots are not created inside others.
    106. 

  106. 	* sanity.sh (init-3): New test for same.
    107. 

    108. 

  108. 2007-08-16  Derek Price  <derek@ximbiot.com>
    109. 

    110. 

  110. 	* root.c (root_allow_used): New function and...
    111. 

  111. 	* root.h (root_allow_used): ...its prototype.
    112. 

  112. 	* server.c (serve_root): Backport --allow-root test for `cvs server'.
    113. 

  113. 	* sanity.sh (server2-5, server2-6): New tests for the above.
    114. 

  114. 

  115. 2007-06-18  Derek Price  <derek@ximbiot.com>
    116. 

  116. 

  117. 	* client.c (send_repository): Don't attempt to send metadata from CVS
    118. 

  118. 	subdirectories when importing.
    119. 

  119. 

  120. 2007-06-15  Derek Price  <derek@ximbiot.com>
    121. 

  121. 

  122. 	* import.c (import): Check more carefully for files and directories
    123. 

  123. 	named "CVS".
    124. 

  124. 	* sanity.sh (import-1b): New test for same.
    125. 

  125. 	(import-2): Test files named "CVS", in addition to directories.
    126. 

  126. 

  127. 2007-05-22  Larry Jones  <lawrence.jones@ugs.com>
    128. 

  128. 

  129. 	* rcs.c (RCS_fully_parse): Include revision in error message.
    130. 

  130. 

  131. 2007-05-07  Derek Price  <derek@ximbiot.com>
    132. 

  132. 

  133. 	* mkmodules.c (init): Assert that the server is not active.
    134. 

  134. 	* server.c (serve_init): Send error message when the init command is
    135. 

  135. 	received from a client.
    136. 

  136. 

  137. 	* sanity.sh (*): Avoid using remote init.
    138. 

  138. 	(skip_always, localonly, restore_adm): New convenience functions.	
    139. 

  139. 

  140. 2007-03-08  Larry Jones  <lawrence.jones@ugs.com>
    141. 

  141. 

  142. 	* rcs.c (findmagictag): Cast node->data before doing arithmetic
    143. 

  143. 	since it's now (void *).
    144. 

    145. 

  145. 2007-03-05  Larry Jones  <lawrence.jones@ugs.com>
    146. 

  146. 

  147. 	* rcs.c (RCS_delete_revs): When checking for tagged revisions,
    148. 

  148. 	include magic branch tags.
    149. 

  149. 

  150. 2007-03-01  Larry Jones  <lawrence.jones@ugs.com>
    151. 

  151. 

  152. 	* import.c (import_descend_dir): Correct error message.
    153. 

  153. 	* sanity.sh (pserver-3a): New test.
    154. 

  154. 

  155. 2006-09-14  Derek Price  <derek@ximbiot.com>
    156. 

  156. 

  157. 	* sanity.sh (server3, client2): New tests.
    158. 

  158. 

  159. 2006-09-07  Derek Price  <derek@ximbiot.com>
    160. 

  160. 

  161. 	[bug #17560]
    162. 

  162. 	* rcs.c (apply_rcs_changes): Improve comments.  Restore repaired error
    163. 

  163. 	handling.
    164. 

  164. 

  165. 2006-09-06  Larry Jones  <lawrence.jones@ugs.com>
    166. 

  166. 

  167. 	* rcs.c (apply_rcs_changes): Improve linked list handling.  Remove
    168. 

  168. 	unused variables and unreachable error handling code.  Avoid unneeded
    169. 

  169. 	dynamic allocation of temp linevector.  Minor stylistic code clean up.
    170. 

  170. 

  171. 2006-09-06  Derek Price  <derek@ximbiot.com>
    172. 

  172. 

  173. 	[bug #17560]
    174. 

  174. 	* rcs.c (apply_rcs_changes): Improve header block comment.  Clean up
    175. 

  175. 	unused linevector on non-fatal error.
    176. 

  176. 

  177. 2006-09-06  Derek Price  <derek@ximbiot.com>
    178. 

  178. 

  179. 	[bug #17560]
    180. 

  180. 	* rcs.c (apply_rcs_changes): Remove an unecessary memcpy.  Avoid some
    181. 

  181. 	other processing on error.
    182. 

  182. 	(linevector_delete): Remove - it's no longer used.
    183. 

    184. 

  184. 2006-09-06  Mark D. Baushke  <mdb@gnu.org>
    185. 

  185. 

  186. 	[bug #17560]
    187. 

  187. 	* rcs.c (apply_rcs_changes): Fix the merge algorithm from O(n^2)
    188. 

  188. 	to O(n).
    189. 

  189. 	(Based on a patch submitted by "Michael J. Smith"
    190. 

  190. 	<msmith@ideorlando.org>)
    191. 

  191. 

  192. 2006-08-28  Derek Price  <derek@ximbiot.com>
    193. 

  193. 

  194. 	* recurse.c (do_recursion): Remove misguided assertion.
    195. 

  195. 	* sanity.sh (dottedroot-3): Add test for the above.
    196. 

  196. 	(Thanks to report from Paul Eggert <eggert@CS.UCLA.EDU>.)
    197. 

  197. 

  198. 	[bug #17168]
    199. 

  199. 	* classify.c (Classify_File): Use T_PATCH for changed keywords instead
    200. 

  200. 	of T_CHECKOUT to conserver bandwidth.  Don't sticky check when marking
    201. 

  201. 	files for update anyhow.
    202. 

  202. 	* sanity.sh: Update to compensate (s/^U /[UP] /).
    203. 

  203. 

  204. 2006-08-25  Derek Price  <derek@ximbiot.com>
    205. 

  205. 

  206. 	[bug #17168]
    207. 

  207. 	* classify.c (Classify_file): Mark files with potential keyword
    208. 

  208. 	substitution changes as needing update.
    209. 

  209. 	* sanity.sh: Update to compensate.
    210. 

  210. 	(keyword, keywordname, serverpatch): Update to compensate, removing
    211. 

  211. 	the last few "checksum failed" tests.
    212. 

  212. 

  213. 	* classify.c (Classify_File): Remove hacks which worked around checksum
    214. 

  214. 	failures from bug #17032.
    215. 

  215. 

  216. 2006-08-24  Derek Price  <derek@ximbiot.com>
    217. 

  217. 

  218. 	[bug #17032]
    219. 

  219. 	* update.c (patch_file): Correctly recreate client working files
    220. 

  220. 	containing the RCS `Name' keyword before generating patches.
    221. 

  221. 	* sanity.sh (keyword-23r): Merge with local case to compensate.
    222. 

    223. 

  223. 2006-08-17  Larry Jones  <lawrence.jones@ugs.com>
    224. 

    225. 

  225. 	* hash.h: Rename structs node and list to hashnode and hashlist
    226. 

  226. 	to avoid name clashes.
    227. 

    228. 

  228. 2006-07-25  Mark D. Baushke  <mdb@gnu.org>
    229. 

    230. 

  230. 	* login.c (free_cvs_password): New function to control freeing of
    231. 

  231. 	the static get_cvs_passwd() returned storage.
    232. 

  232. 	(login): Call it.
    233. 

  233. 	* cvs.h (free_cvs_password): Add prototype for it.
    234. 

  234. 	* client.c (auth_server): Call it.
    235. 

  235. 	[Alter the previous NetBSD coverity cid-3404 patch.]
    236. 

  236. 	
    237. 

  237. 2006-07-11  Larry Jones  <lawrence.jones@ugs.com>
    238. 

    239. 

  239. 	* log.c (log_usage): Fix misleading description of -b (it selects
    240. 

  240. 	revisions on the default branch *in addition to* revisions selected
    241. 

  241. 	with -r).
    242. 

    243. 

  243. 2006-06-29  Derek Price  <derek@ximbiot.com>
    244. 

    245. 

  245. 	* client.c (is_arg_a_parent_or_listed_dir): Strip trailing slashes from
    246. 

  246. 	dir name defore searching for it.  Partially addresses TODO #205.
    247. 

  247. 	* sanity.sh (trailingslashes): Update to compensate.
    248. 

    249. 

  249. 2006-06-28  Derek Price  <derek@ximbiot.com>
    250. 

    251. 

  251. 	[bug #16961]
    252. 

  252. 	* login.c (get_cvs_password): Return copy of global variable.
    253. 

  253. 	(Patch from <mbarabas@redhat.com>.)
    254. 

    255. 

  255. 2006-06-23  Larry Jones  <lawrence.jones@ugs.com>
    256. 

    257. 

  257. 	* server.c (do_cvs_command): Remove unused variable.
    258. 

    259. 

  259. 2006-06-22  Larry Jones  <lawrence.jones@ugs.com>
    260. 

    261. 

  261. 	* mkmodules.c (modules_contents): Remove defunct -i option.
    262. 

    263. 

  263. 2006-06-10  Derek Price  <derek@ximbiot.com>
    264. 

    265. 

  265. 	* sanity.sh (conflicts4): Don't expect specific file permissions.  Use
    266. 

  266. 	$PLUS.
    267. 

    268. 

  268. 2006-06-08  Derek Price  <derek@ximbiot.com>
    269. 

    270. 

  270. 	* sanity.sh (conflicts4): Test that the client honors Empty-conflicts.
    271. 

    272. 

  272. 	* server.c (requests): Add "Empty-conflicts" marker.
    273. 

  273. 	* client.c (send_fileproc): Send contents of all files with conflicts
    274. 

  274. 	unless the server can handle the conflict marker in the Entry.
    275. 

    276. 

  276. 	* sanity.sh (conflicts4): New tests.
    277. 

  277. 	(Original patch from Mark D. Baushke <mdb@gnu.org>.)
    278. 

    279. 

  279. 2006-06-07  Mark D. Baushke  <mdb@gnu.org>
    280. 

    281. 

  281. 	* modules.c (my_module): Remove unused variable xvalue.
    282. 

  282. 	[Fixes NetBSD coverity cid-705.]
    283. 

  283. 	
    284. 

  284. 2006-05-31  Mark D. Baushke  <mdb@gnu.org>
    285. 

    286. 

  286. 	* add.c (add): Fix memory leak.
    287. 

  287. 	[Fixes NetBSD coverity cid-3751.]
    288. 

  288. 	(add_directory): Fix memory leak.
    289. 

  289. 	[Fixes NetBSD coverity cid-3640.]
    290. 

    291. 

  291. 	* checkin.c (Checkin): Avoid possible NULL dereference.
    292. 

  292. 	[Fixes NetBSD coverity cid-2425.]
    293. 

    294. 

  294. 	* client.c (auth_server): Fix memory leak.
    295. 

  295. 	[Fixes NetBSD coverity cid-3404.]
    296. 

    297. 

  297. 	* commit.c (remove_file): Fix memory leak.
    298. 

  298. 	[Fixes NetBSD coverity cid-3752.]
    299. 

    300. 

  300. 	* rcs.c (RCS_checkin): Add assert (tip).
    301. 

  301. 	[Fixes NetBSD coverity cid-2424.]
    302. 

    303. 

  303. 2006-05-26  Mark D. Baushke  <mdb@gnu.org>
    304. 

    305. 

  305. 	* add.c (add): Do not leak memory.
    306. 

  306. 	[Fixes NetBSD coverity cid-2199.]
    307. 

    308. 

  308. 	* edit.c (onoff_fileproc): Do not leak memory.
    309. 

  309. 	[Fixes NetBSD coverity cid-2201.]
    310. 

    311. 

  311. 	* edit.c (onoff_filesdoneproc): Do not leak memory.
    312. 

  312. 	[Fixes NetBSD coverity cid-2202.]
    313. 

    314. 

  314. 	* lock.c (readers_exist): Add assert (lockdir).
    315. 

  315. 	[Fixes NetBSD coverity cid-2411.]
    316. 

    317. 

  317. 	* rcs.c (RCS_findlock_or_tip): Do not leak memory.
    318. 

  318. 	[Fixes NetBSD coverity cid-2198.]
    319. 

    320. 

  320. 	* rcs.c (RCS_getdate): Avoid possible NULL dereference.
    321. 

  321. 	[Fixes NetBSD coverity cid-2412.]
    322. 

    323. 

  323. 	* server.c (serve_sticky): Do not leak file descriptors.
    324. 

  324. 	[Fixes NetBSD coverity cid-2197.]
    325. 

    326. 

  326. 	* server.c (do_cvs_command): Do not leak memory.
    327. 

  327. 	[Fixes NetBSD coverity cid-2204.]
    328. 

    329. 

  329. 	* tag.c (add_to_val_tags): Do not leak memory.
    330. 

  330. 	[Fixes NetBSD coverity cid-2071.]
    331. 

    332. 

  332. 2006-05-25  Derek Price  <derek@ximbiot.com>
    333. 

    334. 

  334. 	* client.c (start_rsh_server): Default rsh client to RSH_DFLT.  Remove
    335. 

  335. 	verbose comment attempting to justify the previous default.
    336. 

    337. 

  337. 2006-05-24  Larry Jones  <lawrence.jones@ugs.com>
    338. 

    339. 

  339. 	* sanity.sh: Add -v|--verbose option to echo test names.  Clean
    340. 

  340. 	up help message.
    341. 

  341. 	Remove val-tags files for cleanup instead of truncating since the
    342. 

  342. 	truncation code doesn't work right on Solaris.  Always use -f when
    343. 

  343. 	removing val-tags.
    344. 

    345. 

  345. 2006-05-22  Derek Price  <derek@ximbiot.com>
    346. 

    347. 

  347. 	* rcs.c (RCS_reparsercsfile, RCS_fully_parse, RCS_checkout, RCS_deltas,
    348. 

  348. 	RCS_getdeltatext, RCS_copydeltas): Verify input revision numbers.
    349. 

  349. 	(rcs6): Update to compensate.
    350. 

    351. 

  351. 	* sanity.sh (rcs6): New test.
    352. 

    353. 

  353. 2006-05-16  Derek Price  <derek@ximbiot.com>
    354. 

    355. 

  355. 	* main.c: Update copyright for 2006.
    356. 

    357. 

  357. 2006-05-12  Mark D. Baushke  <mdb@gnu.org>
    358. 

    359. 

  359. 	* log.c (log_expand_revlist): Add assert (r->first). It should
    360. 

  360. 	only be possible for both r->first == NULL && r->last == NULL
    361. 

  361. 	which would have been handled.
    362. 

  362. 	[Fixes NetBSD coverity cid-1063.]
    363. 

    364. 

  364. 	* server.c (do_cvs_command): Protect close (dev_null_fd) against
    365. 

  365. 	invalid fd value in error_exit.
    366. 

  366. 	[Fixes NetBSD coverity cid-1307.]
    367. 

  367. 	
    368. 

  368. 	* rcs.c (RCS_isdead): Assert that the first argument is not NULL.
    369. 

  369. 	[Fixes NetBSD coverity cid-1058.]
    370. 

    371. 

  371. 	* commit.c (checkaddfile): Do not dereference NULL on call to
    372. 

  372. 	error().
    373. 

  373. 	[Fixes NetBSD coverity cid-1061.]
    374. 

    375. 

  375. 	* log.c (cvslog): Assert p->start && p->end instead of masking the
    376. 

  376. 	problem.
    377. 

  377. 	* server.c (server_updated): Assert findnode_fn results instead of
    378. 

  378. 	masking the problem.
    379. 

  379. 	
    380. 

  380. 	* add.c (add_directory): Revert previous change. The xstrdup()
    381. 

  381. 	function already deals a NULL argument.
    382. 

  382. 	* client.c (handle_mt): Ditto.
    383. 

  383. 	* entries.c (Entnode_Create): Ditto.
    384. 

  384. 	(Entries_Open): Ditto.
    385. 

  385. 	* logmsg.c (fmt_proc): Ditto.
    386. 

  386. 	* vers_ts.c (Version_TS): Ditto.
    387. 

  387. 	
    388. 

  388. 2006-05-11  Mark D. Baushke  <mdb@gnu.org>
    389. 

    390. 

  390. 	* add.c (add_directory): Protect tag from NULL dereference.
    391. 

  391. 	[Fixes NetBSD cid-1054.]
    392. 

    393. 

  393. 	* client.c (handle_mt): Deal with missing text argument.
    394. 

  394. 	[Fixes NetBSD cid-924.]
    395. 

    396. 

  396. 	* entries.c (Entnode_Create): Protect date, tag and ts_conflict
    397. 

  397. 	from possible NULL dereference.
    398. 

  398. 	[Fixes NetBSD coverity cid-994, cid-995, cid-1055, cid-1057.]
    399. 

    400. 

  400. 	* entries.c (Entries_Open): Protect dirtag and dirdate from
    401. 

  401. 	possible NULL dereference.
    402. 

  402. 	[Fixes NetBSD coverity cid-996.]
    403. 

    404. 

  404. 	* log.c (cvslog): Validate start and end args to
    405. 

  405. 	date_to_internet().
    406. 

  406. 	[Fixes NetBSD coverity cid-2427 and cid-2428.]
    407. 

    408. 

  408. 	* logmsg.c (fmt_proc): Protect li->tag from NULL dereference.
    409. 

  409. 	[Fixes NetBSD coverity cid-997.]
    410. 

    411. 

  411. 	* vers_ts.c (Version_TS): Protect tag and vers_ts->tag from NULL
    412. 

  412. 	dereference.
    413. 

  413. 	[Fixes NetBSD coverity cid-1053.]
    414. 

    415. 

  415. 2006-05-04  Mark D. Baushke  <mdb@gnu.org>
    416. 

    417. 

  417. 	* filesubr.c (cvs_temp_file): Avoid keeping pointers to free()'d
    418. 

  418. 	storage laying around.
    419. 

  419. 	* commit.c (commit): Handle possible NULL filename values
    420. 

  420. 	returned from cvs_temp_file().
    421. 

  421. 	* filesubr.c (cvs_temp_name): Ditto.
    422. 

  422. 	* import.c (import): Ditto.
    423. 

  423. 	* login.c (password_entry_operation): Ditto.
    424. 

  424. 	* logmsg.c (do_verify): Ditto.
    425. 

  425. 	* patch.c (patch_fileproc): Ditto.
    426. 

  426. 	[Fixes NetBSD coverity cid-2545.]
    427. 

    428. 

  428. 	* buffer.c (packetizing_buffer_output): Initialize outdata.
    429. 

  429. 	[Fixes NetBSD coverity cid-2474.]
    430. 

    431. 

  431. 	* server.c (server_updated): Check for NULL return from
    432. 

  432. 	findnode_fn(). [Fixes NetBSD coverity cid-1352.]
    433. 

    434. 

  434. 2006-04-19  Larry Jones  <lawrence.jones@ugs.com>
    435. 

    436. 

  436. 	* history.c (sort_order): Back out previous change - not needed.
    437. 

    438. 

  438. 2006-04-15  Larry Jones  <lawrence.jones@ugs.com>
    439. 

    440. 

  440. 	* history.c (sort_order): Add prototype.
    441. 

  441. 	* server.c (template_proc): Add prototype and make args const.
    442. 

  442. 	* update.c (RegisterMerge): Make static to match prototype.
    443. 

    444. 

  444. 2006-04-07  Derek Price  <derek@ximbiot.com>
    445. 

    446. 

  446. 	* client.c (strto_file_size): New function which checks for errors when
    447. 

  447. 	parsing protocol input.
    448. 

  448. 	(read_counted_file, update_entries, handle_mbinary): Use new function.
    449. 

  449. 	Remove FIXME.
    450. 

  450. 	(Thanks to a report from Brendan Harrison
    451. 

  451. 	<brendan.harrison@klocwork.com>.)
    452. 

    453. 

  453. 	* client.c (send_a_repository): Add assertion.
    454. 

  454. 	(Thanks to an incorrect report from Brendan Harrison
    455. 

  455. 	<brendan.harrison@klocwork.com>.)
    456. 

    457. 

  457. 2006-04-06  Derek Price  <derek@ximbiot.com>
    458. 

    459. 

  459. 	* filesubr.c (last_component, expand_wild), rcs.c (RCS_deltas,
    460. 

  460. 	RCS_rewrite), server.c (server_checked_in): Add assertions.
    461. 

  461. 	(Thanks to an incorrect report from Brendan Harrison
    462. 

  462. 	<brendan.harrison@klocwork.com>.)
    463. 

    464. 

  464. 2006-03-31  Mark D. Baushke  <mdb@gnu.org>
    465. 

    466. 

  466. 	* cvsrc.c (read_cvsrc): Deal with \r\n (DOS) line endings in
    467. 

  467. 	.cvsrc files.
    468. 

    469. 

  469. 2006-03-07  Derek Price  <derek@ximbiot.com>
    470. 

    471. 

  471. 	* tag.c (rtag_proc): Search the Attic when -F is used.
    472. 

  472. 	* sanity.sh (tests): Run death-rtag.
    473. 

  473. 	(death-rtag): Expect success.
    474. 

    475. 

  475. 	* sanity.sh (death-rtag): Add failing force tag move test.
    476. 

    477. 

  477. 2006-03-06  Derek Price  <derek@ximbiot.com>
    478. 

    479. 

  479. 	* tag.c (rtag_proc): Always search in the attic when -r is used.
    480. 

    481. 

  481. 	* sanity.sh (death-rtag): New test.
    482. 

  482. 	(Original report from C. Michael Pilato <cmpilato@collab.net>.)
    483. 

    484. 

  484. 2006-03-01  Derek Price  <derek@ximbiot.com>
    485. 

    486. 

  486. 	* sanity.sh: Set MALLOC_CHECK_ in hopes of exposing common memory
    487. 

  487. 	errors when CVS is linked with glibc 2.x.
    488. 

    489. 

  489. 2006-02-27  Derek Price  <derek@ximbiot.com>
    490. 

    491. 

  491. 	* lock.c (internal_lock): Back out previous change, we don't change
    492. 

  492. 	user visible output on stable unless absolutely necessary.
    493. 

    494. 

  494. 	* lock.c (internal_lock): Improve error message.
    495. 

    496. 

  496. 2006-02-26  Derek Price  <derek@ximbiot.com>
    497. 

    498. 

  498. 	* client.c (call_in_directory): Remove unneeded code.
    499. 

  499. 	* sanity.sh (toplevel-12): Compensate by failing to expect a redundant
    500. 

  500. 	error message.
    501. 

    502. 

  502. 2006-02-24  Mark D. Baushke  <mdb@gnu.org>
    503. 

    504. 

  504. 	* client.c (gzip_level): Move to...
    505. 

  505. 	* main.c (gzip_level): ...here.
    506. 

  506. 	(main): Revert previous change in '-z' argument processing and
    507. 

  507. 	remove CLIENT_SUPPORT ifdef/endif.
    508. 

  508. 	* sanity.h (crerepos-6a): Deal with --disable-client output.
    509. 

    510. 

  510. 	* main.c (main): Validate the gzip compression level for
    511. 

  511. 	--disable-client configurations.
    512. 

    513. 

  513. 2006-02-13  Derek Price  <derek@ximbiot.com>
    514. 

    515. 

  515. 	* server.c (do_cvs_command): Skip server_cleanup in the child process.
    516. 

    517. 

  517. 	* sanity.sh (sshstdio-6): Rewrite using more portable sed script.
    518. 

    519. 

  519. 2006-02-02  Derek Price  <derek@ximbiot.com>
    520. 

    521. 

  521. 	* sanity.sh (sshstdio): Attempt to ignore spurious SSH output.
    522. 

    523. 

  523. 	* main.c (main), release.c (release), server.c (do_cvs_command): Always
    524. 

  524. 	call the cleanup hooks before exit.
    525. 

    526. 

  526. 2006-02-01  Derek Price  <derek@ximbiot.com>
    527. 

    528. 

  528. 	* tag.c (add_to_val_tags): When a tag turns out to exist in the db when
    529. 

  529. 	it isn't expected, release the lock.
    530. 

    531. 

  531. 	* history.c (save_user, save_file, save_mod, read_hrecs): Avoid
    532. 

  532. 	overflow.
    533. 

    534. 

  534. 2006-01-30  Derek Price  <derek@ximbiot.com>
    535. 

    536. 

  536. 	* server.c (do_cvs_command): Set flow control pipe to blocking mode
    537. 

  537. 	before waiting for it to close.
    538. 

  538. 	(set_block_fd): New function.
    539. 

  539. 	(Original patch from Garrett Rooney <grooney@collab.net>.)
    540. 

    541. 

  541. 2006-01-13  Larry Jones  <lawrence.jones@ugs.com>
    542. 

    543. 

  543. 	* mkmodules.c (config_contents): Change SystemAuth to yes to match
    544. 

  544. 	the default value.  Add missing newline in RereadLogAfterVerify.
    545. 

    546. 

  546. 2006-01-09  Larry Jones  <lawrence.jones@ugs.com>
    547. 

    548. 

  548. 	* commit.c (remove_file): Record correct revision in history file.
    549. 

  549. 	(Reported by Chris Reed <cr@progress.com>.)
    550. 

    551. 

  551. 2005-12-07  Derek Price  <derek@ximbiot.com>
    552. 

    553. 

  553. 	* client.c (start_server), root.c (method_names), root.h (CVSmethod):
    554. 

  554. 	Handle :extssh: as a kindness to Eclipse users.
    555. 

  555. 	(Suggestion from Joseph P. Skudlarek <Jskud@Jskud.com>.)
    556. 

    557. 

  557. 2005-12-06  Mark D. Baushke  <mdb@gnu.org>
    558. 

    559. 

  559. 	* buffer.c (stdio_buffer_shutdown): No longer assert() the
    560. 

  560. 	fstat(). Use error (0, ...) instead of error (1, ...) to avoid
    561. 

  561. 	infinite loops. (patch #4678)
    562. 

  562. 	Patch adapted from "Allan L. Bazinet" <allan.bazinet@gmail.com>
    563. 

    564. 

  564. 2005-11-10  Larry Jones  <lawrence.jones@ugs.com>
    565. 

    566. 

  566. 	* commit.c (commit): Complain about obsolete -n option if not in
    567. 

  567. 	server mode.
    568. 

    569. 

  569. 2005-11-09  Derek Price  <derek@ximbiot.com>
    570. 

    571. 

  571. 	* sanity.sh (pserver-4.2): Accept a "no such sytem user" message when
    572. 

  572. 	a root attempt is made.
    573. 

    574. 

  574. 2005-09-30  Larry Jones  <lawrence.jones@ugs.com>
    575. 

    576. 

  576. 	* expand_path.c (expand_path): Fix memory leaks.
    577. 

    578. 

  578. 2005-09-29  Paul Eggert  <eggert@CS.UCLA.EDU>
    579. 

  579. 	    Derek Price  <derek@ximbiot.com>
    580. 

    581. 

  581. 	* client.c (handle_m, handle_e): Remove incomplete workaround for
    582. 

  582. 	O_NONBLOCK problem; no longer needed because of the fix below.
    583. 

  583. 	(start_rsh_server): We need the O_NONBLOCK fix, so pass 'true' to
    584. 

  584. 	piped_child to enable the workaround.
    585. 

  585. 	* cvs.h (piped_child): New bool argument saying whether O_NONBLOCK
    586. 

  586. 	fix is needed.  All uses changed.
    587. 

  587. 	* run.c (work_around_openssh_glitch): New function.
    588. 

  588. 	(piped_child): Use it if the fix is requested.  Avoid call call to
    589. 

  589. 	vfork with undefined behavior.
    590. 

    591. 

  591. 2005-09-26  Conrad T. Pino  <Conrad@Pino.com>
    592. 

    593. 

  593. 	* rcs.c: Use "#ifdef HAVE_FSYNC" just like every where else.
    594. 

    595. 

  595. 2005-09-25  Derek Price  <derek@ximbiot.com>
    596. 

    597. 

  597. 	* rcs.c (rcs_internal_unlockfile): Fsync files before renaming them.
    598. 

  598. 	Patch from Rahul Bhargava <rahul@wandisco.com>.
    599. 

    600. 

  600. 2005-09-24  Derek Price  <derek@ximbiot.com>
    601. 

    602. 

  602. 	* update.c (merge_file): Check for RCS_checkout errors.
    603. 

    604. 

  604. 2005-09-23  Larry Jones  <lawrence.jones@ugs.com>
    605. 

    606. 

  606. 	* checkout.c (export_usage): Note that -r requires a tag.
    607. 

    608. 

  608. 2005-09-22  Larry Jones  <lawrence.jones@ugs.com>
    609. 

    610. 

  610. 	* patch.c (patch_usage): Document -k option.
    611. 

    612. 

  612. 2005-09-22  Derek Price  <derek@ximbiot.com>
    613. 

    614. 

  614. 	* classify.c (Classify_File): If a file had a conflict and the
    615. 

  615. 	timestamp hasn't changed, it still has a conflict.  Add comment about
    616. 

  616. 	how T_MODIFIED could later turn out to have conflict markers and why
    617. 

  617. 	it should not be checked in this function.
    618. 

  618. 	* client.c (send_fileproc): Don't send contents for files known to have
    619. 

  619. 	conflicts unless this is for `cvs diff'.
    620. 

  620. 	* commit.c (check_fileproc): T_CONFLICT should be handled like
    621. 

  621. 	T_MODIFIED, since force could be requested.  Simplify logic since
    622. 

  622. 	T_CONFLICT can now be trusted.
    623. 

  623. 	* cvs.h (file_has_conflict): Remove proto.
    624. 

  624. 	* rcs.c (RCS_Checkout): Comment noexec behavior in header block.
    625. 

  625. 	* server.c (serve_unchanged, serve_is_modified): Handle conflicts.
    626. 

  626. 	* status.c (status_fileproc): Trust T_CONFLICT to simplify.
    627. 

  627. 	* subr.c (file_has_conflict): Removed.
    628. 

  628. 	* update.c (update_fileproc): Trust T_CONFLICT.
    629. 

  629. 	(RegisterMerge): New function factored from...
    630. 

  630. 	(merge_file, join_file): ...these two functions.
    631. 

  631. 	* vers_ts.c (time_stamp_server): Handle = conflict timestamps in server
    632. 

  632. 	entdata.
    633. 

  633. 	* sanity.sh (files-12): Account for slight behavior improvement.
    634. 

  634. 	(status, conflicts, mwrap): Account for corrected behavior.
    635. 

  635. 	(join-readonly-conflict-10): Correct comment.
    636. 

  636. 	(binfiles-con1b): New test for correct behavior.
    637. 

  637. 

  638. 2005-09-19  Derek Price  <derek@ximbiot.com>
    639. 

  639. 

  640. 	* sanity.sh (modules5-8): Rename...
    641. 

  641. 	(modules5-8r): ...to this and comment Mac OS X failure.
    642. 

  642. 	Comment Solaris 9 failure below with a `FIXME?' tag.
    643. 

    644. 

  644. 	* sanity.sh: Remove previous hack in favor of setting TESTDIR on
    645. 

  645. 	Solaris (and Mac OS X) until problem is solved correctly.
    646. 

    647. 

  647. 2005-09-15  Derek Price  <derek@ximbiot.com>
    648. 

    649. 

  649. 	* sanity.sh: Use /bin/pwd to verify current dir since Solaris 9 is
    650. 

  650. 	sometimes resolving symlinked paths.
    651. 

    652. 

  652. 2005-09-14  Derek Price  <derek@ximbiot.com>
    653. 

    654. 

  654. 	* edit.c (edit_usage, unedit_usage, editors_usage), watch.c
    655. 

  655. 	(watch_usage, watchers_usage): Add quotes and reword for clarity and
    656. 

  656. 	consistency.
    657. 

    658. 

  658. 	* edit.c (edit_usage): Add missing syntax.  Reword description for
    659. 

  659. 	clarity.  Mention default behavior.
    660. 

    661. 

  661. 2005-09-13  Derek Price  <derek@ximbiot.com>
    662. 

    663. 

  663. 	* sanity.sh: Split $username into $username & $username8.  Rename
    664. 

  664. 	$author as $anyusername.
    665. 

    666. 

  666. 2005-09-12  Derek Price  <derek@ximbiot.com>
    667. 

    668. 

  668. 	* sanity.sh (binfiles-con1b): Back out accidental addition.
    669. 

    670. 

  670. 	* sanity.sh (username): Cut $username down to 8 characters when longer,
    671. 

  671. 	since that is all that appears in output.
    672. 

    673. 

  673. 2005-09-07  Derek Price  <derek@ximbiot.com>
    674. 

    675. 

  675. 	Close <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14462>.
    676. 

  676. 	* rcs.c (RCS_parse): Free variable *after* using it for the last time.
    677. 

    678. 

  678. 2005-09-06  Derek Price  <derek@ximbiot.com>
    679. 

    680. 

  680. 	* rcs.c (RCS_putdtree): Remove unused variable.
    681. 

    682. 

  682. 2005-09-06  Mark D. Baushke  <mdb@gnu.org>
    683. 

    684. 

  684. 	Close <https://savannah.nongnu.org/bugs/?func=detailitem&item_id=14435>.
    685. 

  685. 	* rcs.c (RCS_putdtree): Avoid stack overflow which may be
    686. 

  686. 	possible with excessive recursive calls to RCS_putdtree().
    687. 

  687. 	(Patch from Serg Masyutin.)
    688. 

    689. 

  689. 2005-09-03  Derek Price  <derek@ximbiot.com>
    690. 

    691. 

  691. 	* add.c (add_usage): Standardize usage message somewhat.
    692. 

    693. 

  693. 2005-09-02  Larry Jones  <lawrence.jones@ugs.com>
    694. 

    695. 

  695. 	* commit.c (checkaddfile): Improve error messages for lock_RCS failure.
    696. 

  696. 	* release.c (release): Improve error message for pclose failure.
    697. 

    698. 

  698. 	* root.h (struct cvsroot_s): Always declare isremote to simplify
    699. 

  699. 	other code.  Simplify referencing code.
    700. 

  700. 	* root.c (new_cvsroot_t): Always initialize isremote.
    701. 

  701. 	* server.h: Always declare server_active to simplify other code.
    702. 

  702. 	Simplify referencing code.
    703. 

  703. 	* server.c: Always define server_active.
    704. 

    705. 

  705. 2005-09-01  Derek Price  <derek@ximbiot.com>
    706. 

    707. 

  707. 	* main.c, wrapper.c: Update links.
    708. 

    709. 

  709. 2005-09-01  Derek Price  <derek@ximbiot.com>
    710. 

    711. 

  711. 	* recurse.c: Update bug report email address.
    712. 

    713. 

  713. 2005-08-30  Larry Jones  <lawrence.jones@ugs.com>
    714. 

    715. 

  715. 	* import.c (import_descend): Lock repository directory during import.
    716. 

    717. 

  717. 2005-07-12  Derek Price  <derek@ximbiot.com>
    718. 

    719. 

  719. 	* buffer.c, buffer.h, client.h, expand_path.c, history.c, myndbm.h,
    720. 

  720. 	release.c: Add copyright notices.
    721. 

    722. 

  722. 2005-07-11  Derek Price  <derek@ximbiot.com>
    723. 

    724. 

  724. 	* buffer.c, buffer.h, client.h, expand_path.c, history.c, myndbm.h,
    725. 

  725. 	release.c: Update license notices.
    726. 

    727. 

  727. 2005-06-22  Larry Jones  <lawrence.jones@ugs.com>
    728. 

    729. 

  729.         * vers_ts (Version_TS): Don't allow command line keyword expansion
    730. 

  730.         modes to override binary mode.
    731. 

  731.         * sanity.sh (): Tests for the above.
    732. 

  732.         (Merged from trunk.)
    733. 

    734. 

  734. 2005-06-06  Conrad T. Pino  <Conrad@Pino.com>
    735. 

    736. 

  736. 	* cvs.h: Reverse patch committed 2005-05-27 by Conrad T. Pino.
    737. 

  737. 	* run.c: Reverse patch committed 2005-05-27 by Conrad T. Pino.
    738. 

    739. 

  739. 2005-06-02  Derek Price  <derek@ximbiot.com>
    740. 

    741. 

  741. 	* zlib.c (compress_buffer_shutdown_input): Don't attempt to read EOF
    742. 

  742. 	from the client during shutdown.  It might never be sent.
    743. 

  743. 	* sanity.sh (abspath2): Test for this.
    744. 

    745. 

  745. 2005-05-31  Derek Price  <derek@ximbiot.com>
    746. 

  746. 	for Alexander Taler <alex@0--0.org>
    747. 

    748. 

  748. 	* rcscmds.c: Change type of call_diff_argc_allocated from int to
    749. 

  749. 	size_t, to match the prototype of run_add_arg_p().  This fixes a
    750. 

  750. 	bus error in OpenBSD 3.6 sparc64.
    751. 

    752. 

  752. 2005-05-27  Conrad T. Pino  <Conrad@Pino.com>
    753. 

    754. 

  754. 	* cvs.h: Replace "run_arg" function with "#define run_arg run_add_arg",
    755. 

  755. 	add "run_add_arg" prototype, change "piped_child" prototype to be same
    756. 

  756. 	as feature branch to reflect "(os2,src,windows-NT)/run.c" changes.
    757. 

  757. 	* run.c: Remove "run_arg" to synchronize with "../windows-NT/run.c".
    758. 

  758. 	Function "run_add_arg" scope was "static" and is now "extern" scope.
    759. 

  759. 	Synchronize "piped_child" function arguments with feature branch.
    760. 

    761. 

  761. 2005-05-27  Derek Price  <derek@ximbiot.com>
    762. 

    763. 

  763. 	* client.c (send_arg): Make arg const.
    764. 

  764. 	(send_option_string): Rename to...
    765. 

  765. 	(send_options): ...this and accept argc/argv in place of string.
    766. 

  766. 	* client.h: Update protos to match the changes to client.c.
    767. 

  767. 	* cvs.h (RCS_exec_rcsdiff, diff_exec): Update protos.
    768. 

  768. 	(run_add_arg_p, run_arg_free_p): New protos.
    769. 

  769. 	* diff.c (opts, opts_allocated): Replace with...
    770. 

  770. 	(diff_argv, diff_argc, diff_arg_allocated): ...these.
    771. 

  771. 	(add_diff_args): New convenience function.
    772. 

  772. 	(diff): Use new constructs and APIs.
    773. 

  773. 	* patch.c (patch_fileproc, RCS_checkin, RCS_delete_revs), rcscmds.c
    774. 

  774. 	(call_diff_add_arg, call_diff_setup, RCS_merge, RCS_exec_rcsdiff,
    775. 

  775. 	diff_exec, RCS_output_diff_options), update.c (patch_file): Use new
    776. 

  776. 	APIs.
    777. 

  777. 	* run.c (run_add_arg_p, run_arg_free_p): New functions.
    778. 

  778. 	(run_argc_allocated): Make size_t.
    779. 

  779. 	(run_setup, run_add_arg): Use new functions.
    780. 

  780. 	* sanity.sh: Accomodate above changes.
    781. 

  781. 	(rcslib-diffrgx-3): Slip in test for space splitting.
    782. 

    783. 

  783. 2005-05-02  Derek Price  <derek@ximbiot.com>
    784. 

    785. 

  785. 	Remove unnecessary level of indirection.
    786. 

  786. 	* lock.c (L_HISTORY_LOCK, L_VAL_TAGS_LOCK): Remove macros.
    787. 

  787. 	(internal_lock, internal_clear_lock): Accept lock as argument.
    788. 

  788. 	(history_lock, clear_history_lock, val_tags_lock, clear_val_tags_lock):
    789. 

  789. 	Replace old macro arg with an actual lock pointer.
    790. 

    791. 

  791. 2005-05-02  Derek Price  <derek@ximbiot.com>
    792. 

    793. 

  793. 	* lock.c (internal_lock, internal_clear_lock): Add protos.
    794. 

  794. 	(history_lock, val_tags_lock): Return the chartered true/false status.
    795. 

    796. 

  796. 2005-05-02  Derek Price  <derek@ximbiot.com>
    797. 

    798. 

  798. 	* cvs.h (CVSHISTLCK): Rename macro to...
    799. 

  799. 	(CVSHISTORYLCK): ...this.
    800. 

  800. 	(CVSVALTAGSLCK): New macro.
    801. 

  801. 	(val_tags_lock, clear_val_tags_lock): New functions.
    802. 

  802. 	* lock.c (global_val_tags_lock): New global.
    803. 

  803. 	(Lock_Cleanup): Clean up after val-tags lock if necessary.
    804. 

  804. 	(L_HISTORY_LOCK, L_VAL_TAGS_LOCK): New local macros.
    805. 

  805. 	(internal_lock, internal_clear_lock, val_tags_lock,
    806. 

  806. 	clear_val_tags_lock): New functions.
    807. 

  807. 	(history_lock, clear_history_lock): Use new internal functions.
    808. 

  808. 	* tag.c (is_in_val_tags, add_to_val_tags): New functions using the
    809. 

  809. 	write-lock for val-tags and factored from...
    810. 

  810. 	(tag_check_valid): ...this function.
    811. 

  811. 	* sanity.sh (lockfiles-22): Add val-tags lock test.
    812. 

    813. 

  813. 2005-04-28  Derek Price  <derek@ximbiot.com>
    814. 

    815. 

  815. 	* cvs.h (history_lock, clear_history_lock): New protos.
    816. 

  816. 	* lock.c (struct lock): Add lockdirname.
    817. 

  817. 	(global_history_lock): New global.
    818. 

  818. 	(global_read_lock): Initialize.
    819. 

  819. 	(lock_name): Handle const args.
    820. 

  820. 	(lock_simple_remove): Factor out code in favor of clear_lock call.
    821. 

  821. 	(set_lock): Handle variable lockdirname.
    822. 

  822. 	(lock_filesdoneproc): Set new lockdirname.
    823. 

  823. 	(history_lock, clear_history_lock): New functions.
    824. 

  824. 	(clear_lock): Avoid segfault on missing lock.
    825. 

  825. 	(Lock_Cleanup): Clean up history locks when necessary.
    826. 

  826. 	* history.c (history_write): Use new lock.
    827. 

  827. 	* sanity.sh (lockfiles-20): Test new lock.
    828. 

    829. 

  829. 2005-04-28  Derek Price  <derek@ximbiot.com>
    830. 

    831. 

  831. 	* sanity.sh (lockfiles): Port some locking tests over from 1.12.x.
    832. 

    833. 

  833. 2005-04-28  Derek Price  <derek@ximbiot.com>
    834. 

    835. 

  835. 	* lock.c (clear_lock): Improve comment.
    836. 

    837. 

  837. 2005-04-28  Derek Price  <derek@ximbiot.com>
    838. 

    839. 

  839. 	* lock.c (struct lock): Store lockdir name.
    840. 

  840. 	(masterlock): Remove global.
    841. 

  841. 	(remove_lock_files, clear_lock, set_lock): Update to compensate.
    842. 

    843. 

  843. 2005-04-20  Derek Price  <derek@ximbiot.com>
    844. 

    845. 

  845. 	* sanity.sh (rcs5): Minor cosmetic change.
    846. 

    847. 

  847. 2005-04-20  Derek Price  <derek@ximbiot.com>
    848. 

    849. 

  849. 	* sanity.sh (tests): Add rcs4.
    850. 

  850. 	(rcs5): Add comments.
    851. 

    852. 

  852. 2005-04-20  Derek Price  <derek@ximbiot.com>
    853. 

    854. 

  854. 	* rcs.c (expand_keywords): Avoid buffer overflow.
    855. 

  855. 	(Original patch from Stewart Brodie <stewart@eh.org>.)
    856. 

    857. 

  857. 	* sanity.sh (rcs5): New tests for the above.
    858. 

    859. 

  859. 2005-03-17  Derek Price  <derek@ximbiot.com>
    860. 

    861. 

  861. 	* login.c (password_entry_parseline): Avoid using uninitialized
    862. 

  862. 	variable.
    863. 

  863. 	* rcs.c (RCS_deltas): Avoid buffer overflow.
    864. 

  864. 	(RCS_checkout): Avoid using uninitialized loglen.
    865. 

  865. 	* patch.c (patch_fileproc): Free original pointer, not one that may
    866. 

  866. 	have been incremented.
    867. 

  867. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    868. 

    869. 

  869. 2005-03-17  Derek Price  <derek@ximbiot.com>
    870. 

    871. 

  871. 	* commit.c (checkaddfile): Avoid dereferencing a NULL pointer in
    872. 

  872. 	response to a rare error.
    873. 

  873. 	* admin.c (admin_fileproc), log.c (log_expand_revlist), mkmodules.c
    874. 

  874. 	(checkout_file), rcs.c (RCS_getdate, RCS_deltas, RCS_findlock_or_tip,
    875. 

  875. 	RCS_tag2rev): Avoid dereferencing NULL pointer.
    876. 

  876. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    877. 

    878. 

  878. 2005-03-17  Derek Price  <derek@ximbiot.com>
    879. 

    880. 

  880. 	* rcs.c (RCS_reparsercsfile): Avoid memory leak.
    881. 

  881. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    882. 

    883. 

  883. 2005-03-17  Derek Price  <derek@ximbiot.com>
    884. 

    885. 

  885. 	* log.c (log_expand_revlist): Suppress message and not error handling
    886. 

  886. 	when really_quiet.
    887. 

    888. 

  888. 2005-03-17  Derek Price  <derek@ximbiot.com>
    889. 

    890. 

  890. 	* client.c (call_in_directory): Put function call after var decls.
    891. 

    892. 

  892. 2005-03-16  Derek Price  <derek@ximbiot.com>
    893. 

    894. 

  894. 	* client.c (call_in_directory), commit.c (commit_filesdoneproc), log.c
    895. 

  895. 	(log_expand_revlist, log_version), logmsg.c (logfile_write), modules
    896. 

  896. 	(my_module), no_diff.c (No_Difference), parseinfo.c (Parse_Info), rcs.c
    897. 

  897. 	(RCS_deltas, RCS_checkin, RCS_addbranch, do_locks, do_symbols),
    898. 

  898. 	rcscmds.c (RCS_merge), root.c (parse_cvsroot, normalize_cvsroot),
    899. 

  899. 	update.c (merge_file): Verify assumptions via assertions.
    900. 

  900. 	(Thanks to (probably) incorrect reports from Alen Zukich
    901. 

  901. 	<alen.zukich@klocwork.com>.)
    902. 

    903. 

  903. 2005-03-16  Derek Price  <derek@ximbiot.com>
    904. 

    905. 

  905. 	* server.c (create_adm_p, serve_entry), tag.c (rtag_proc): Avoid memory
    906. 

  906. 	leaks.
    907. 

  907. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    908. 

    909. 

  909. 2005-03-15  Mark D. Baushke  <mdb@cvshome.org>
    910. 

    911. 

  911. 	* history.c (select_hrec): Avoid possible memory leak.
    912. 

    913. 

  913. 2005-03-15  Derek Price  <derek@ximbiot.com>
    914. 

    915. 

  915. 	* patch.c (patch_proc): Avoid memory leak.
    916. 

  916. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    917. 

    918. 

  918. 2005-03-11  Mark D. Baushke  <mdb@cvshome.org>
    919. 

    920. 

  920. 	* modules.c (my_module): Protect against free (NULL) code path.
    921. 

    922. 

  922. 2005-03-11  Derek Price  <derek@ximbiot.com>
    923. 

    924. 

  924. 	* annotate.c (rannotate_proc), fileattr.c (fileattr_write), rcs.c
    925. 

  925. 	(RCS_deltas), server.c (check_repository_password), update.c (update):
    926. 

  926. 	Avoid memory leaks.
    927. 

  927. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    928. 

    929. 

  929. 2005-03-09  Derek Price  <derek@ximbiot.com>
    930. 

    931. 

  931. 	* add.c (add, add_directory), buffer.c (allocate_buffer_datas),
    932. 

  932. 	client.c (update_entries), commit.c (checkaddfile), entries.c
    933. 

  933. 	(Entries_Open), fileattr.c (fileattr_read), ignore.c (ign_add),
    934. 

  934. 	import.c (import), main.c (main), parseinfo.c (parse_config), rcs.c
    935. 

  935. 	(RCS_reparsercsfile, RCS_getbranchpoint, RCS_checkout,
    936. 

  936. 	RCS_delete_revs, apply_rcs_changes): Avoid memory leaks.
    937. 

  937. 	(Thanks to report from Alen Zukich <alen.zukich@klocwork.com>.)
    938. 

    939. 

  939. 	* hardlink.c, hardlink.h: Avoid compiling entire contents of these
    940. 

  940. 	files w/o preserve permissions support.
    941. 

    942. 

  942. 2005-03-09  Mark D. Baushke  <mdb@cvshome.org>
    943. 

    944. 

  944. 	* history.c (history, save_file): Cleanup the API to match the
    945. 

  945. 	comments.
    946. 

    947. 

  947. 2005-02-27  Jim Meyering  <jim@meyering.net>
    948. 

    949. 

  949. 	* login.c (password_entry_operation): Exit nonzero when
    950. 

  950. 	failing to close a just-appended-to .cvspass file.
    951. 

    952. 

  952. 2005-02-26  Larry Jones  <lawrence.jones@ugs.com>
    953. 

    954. 

  954. 	* release.c (release): Remove unneeded code.
    955. 

    956. 

  956. 2005-02-22 Derek Price <derek@ximbiot.com>
    957. 

    958. 

  958. 	* edit.c: Load watch settings before setting new ones with
    959. 

  959. 	`cvs watch on/off'.
    960. 

  960. 	(Original patch from Jim Hyslop <jhyslop@ieee.org>.)
    961. 

  961. 

  962. 	* sanity.sh (watch6): New tests for same.
    963. 

  963. 	(Outline from Jim Hyslop <jhyslop@ieee.org>.)
    964. 

  964. 

  965. 2005-02-21  Mark D. Baushke  <mdb@cvshome.org>
    966. 

  966. 

  967. 	* import.c (import): Avoid using assert with side effects it may
    968. 

  968. 	be configured away using NDEBUG.
    969. 

  969. 	(Patch from Frank Hemer <frank@hemer.org>.)
    970. 

  970. 

  971. 2005-02-08 Derek Price <derek@ximbiot.com>
    972. 

  972. 

  973. 	* build_src.com: Build stack.c on VMS.
    974. 

  974. 	(Suggestion from Piet Schuermans <pschuermans@mac.com>.)
    975. 

  975. 

  976. 2005-02-01  Larry Jones  <lawrence.jones@ugs.com>
    977. 

  977. 

  978. 	* log.c (log_fileproc, log_expand_revlist): Add support for BASE tag.
    979. 

  979. 	* sanity.sh (log): New tests for above.
    980. 

  980. 

  981. 2005-01-31 Derek Price <derek@ximbiot.com>
    982. 

  982. 

  983. 	* main.c: Update year in copyright notice to match GNU standards.
    984. 

  984. 	* sanity.sh (version-1): Update to match.
    985. 

  985. 

  986. 2005-01-31 Derek Price <derek@ximbiot.com>
    987. 

  987. 

  988. 	* main.c: Rephrase --version message.
    989. 

  989. 	* sanity.sh (version-1): Update to match.
    990. 

  990. 

  991. 2005-01-31 Derek Price <derek@ximbiot.com>
    992. 

  992. 

  993. 	* Makefile.am, add.c, admin.c, annotate.c, checkin.c, checkout.c,
    994. 

  994. 	classify.c, commit.c, create_adm.c, cvs.h, cvsrc.c, diff.c, entries.c,
    995. 

  995. 	find_names.c, hash.c, hash.h, history.h, import.c, lock.c, log.c,
    996. 

  996. 	login.c, logmsg.c, main.c, mkmodules.c, modules.c, myndbm.c, no_diff.c,
    997. 

  997. 	parseinfo.c, patch.c, rcs.c, rcs.h, rcscmds.c, recurse.c, remove.c,
    998. 

  998. 	repos.c, root.c, root.h, server.h, stack.c, stack.h, status.c, subr.c,
    999. 

  999. 	tag.c, update.c, vers_ts.c, version.c: Update copyright notices.
    1000. 

  1000. 

  1001. 2005-01-29 Derek Price <derek@ximbiot.com>
    1002. 

  1002. 

  1003. 	* log.c (log_usage): Add note about using -S with revision info
    1004. 

  1004. 	supression and selection.
    1005. 

  1005. 	(Suggestion from Dan Peterson <dbpete@aol.com>.)
    1006. 

  1006. 

  1007. 2004-12-19  Larry Jones  <lawrence.jones@ugs.com>
    1008. 

  1008. 

  1009. 	* expand_path.c (expand_path): Rewrite using offsets instead of
    1010. 

  1010. 	pointers to simplify and avoid reallocation bugs.
    1011. 

  1011. 	(Inspired by Jeremy Bopp <jeremy@motive.com>.)
    1012. 

  1012. 

  1013. 2004-12-09 Derek Price <derek@ximbiot.com>
    1014. 

  1014. 

  1015. 	* sanity.sh (tests): Add modules7.
    1016. 

  1016. 

  1017. 2004-12-09 Derek Price <derek@ximbiot.com>
    1018. 

  1018. 

  1019. 	* sanity.sh (modules7): New test group.
    1020. 

  1020. 	(Based on a patch from Mark D. Baushke <mdb@cvshome.org>, based on a
    1021. 

  1021. 	report from Richard Verhoeven <Richard_Verhoeven@WestLB.de>.)
    1022. 

  1022. 

  1023. 2004-11-18  Mark D. Baushke  <mdb@cvshome.org>
    1024. 

  1024. 

  1025. 	* checkout.c (checkout_proc): Passing the repository to
    1026. 

  1026. 	tag_check_valid seems to stop the assertion failure in recurse.c
    1027. 

  1027. 	do_recursion.
    1028. 

  1028. 	* sanity.sh (basic2-21a): Removed.
    1029. 

  1029. 	(basic2-21b): Fixed.
    1030. 

  1030. 

  1031. 2004-11-17  Mark D. Baushke  <mdb@cvshome.org>
    1032. 

  1032. 

  1033. 	* sanity.sh (basic2-21a): The val-tags file should have
    1034. 

  1034. 	at least 'rtagged-by-head y' in it.
    1035. 

  1035. 	(basic2-21b): New test showing a cvs bug when val-tags
    1036. 

  1036. 	is not properly updated.
    1037. 

  1037. 	(Report from "John Elgin" <John@JCElgin.com>.)
    1038. 

  1038. 

  1039. 2004-11-17  Mark D. Baushke  <mdb@cvshome.org>
    1040. 

  1040. 

  1041. 	* client.c (handle_m, handle_e): Winsock is returning
    1042. 

  1042. 	SOCK_ERRNO == WSAENOTSOCK for select() problems and not
    1043. 

  1043. 	setting errno. Do not bother with printing an error from a
    1044. 

  1044. 	select() that is not returning an non-zero errno.
    1045. 

  1045. 	(Report from Conrad T. Pino <Conrad@Pino.com>.)
    1046. 

  1046. 

  1047. 2004-11-10 Derek Price <derek@ximbiot.com>
    1048. 

  1048. 

  1049. 	* sanity.sh: Maintain pass/skip/warn status and output at end.
    1050. 

  1050. 	(usage): Note new functionality of -e.
    1051. 

  1051. 	(warn): New function.
    1052. 

  1052. 	(verify_tmp_empty): Warn instead of failing.  Delete turds if warn()
    1053. 

  1053. 	doesn't exit.
    1054. 

    1055. 

  1055. 2004-11-10 Derek Price <derek@ximbiot.com>
    1056. 

  1056. 

  1057. 	* sanity.sh (verify_tmp_empty): New function.
    1058. 

  1058. 	(dotest_internal_*): Call verify_tmp_empty as needed.
    1059. 

  1059. 

  1060. 2004-11-09  Mark D. Baushke  <mdb@cvshome.org>
    1061. 

  1061. 

  1062. 	* sanity.sh: Backport find_tool changes from 1.12.9.1.
    1063. 

  1063. 	(SEARCHPATH): New list of PATH directories to search.
    1064. 

  1064. 	(Which): Use $SEARCHPATH. Support -a switch.
    1065. 

  1065. 	(badtools,set_bad_tool,is_bad_tool): Keep track of tools that do
    1066. 

  1066. 	not work for us.
    1067. 

  1067. 	(version_test): Obtain the version of tools under test if
    1068. 

  1068. 	possible.
    1069. 

  1069. 	(tool_find): Rewrite. API changed to allow a list of
    1070. 

  1070. 	tests to be used against a list of possible command names found on
    1071. 

  1071. 	the SEARCHPATH.
    1072. 

  1072. 	(id_tool_test): Check that 'id -u' and 'id -un' work.
    1073. 

  1073. 	(expr_tooltest1): Check for NextStep 3.3 expr bug.
    1074. 

  1074. 	(expr_tooltest2): Check for SunOS expr multi-line pattern bug.
    1075. 

  1075. 	(expr_create_bar): Create a test file for expr testing.
    1076. 

  1076. 	(expr_tooltest3): Use it and test for big multi-line identity
    1077. 

  1077. 	matches.
    1078. 

  1078. 	(expr_set_ENDANCHOR): Find and set the right value for ENDANCHOR.
    1079. 

  1079. 	(expr_set_DOTSTAR): Find and set the right value for DOTSTAR.
    1080. 

  1080. 	(expr_tooltest_DOTSTAR): Ensure that DOTSTAR works with big
    1081. 

  1081. 	matches.
    1082. 

  1082. 	(tr_tooltest1): Verify that tr handles NUL bytes.
    1083. 

  1083. 	(awk_tooltest1): Verify that awk the BEGIN clause works properly.
    1084. 

  1084. 	(awk_tooltest2): Verify that print %c format item works properly.
    1085. 

  1085. 

  1086. 2004-11-02  Mark D. Baushke  <mdb@cvshome.org>
    1087. 

  1087. 

  1088. 	* filesubr.c (MAXSIZE): New macro.
    1089. 

  1089. 	(xreadlink): Ensure initial buffer size does not exceed MAXSIZE.
    1090. 

  1090. 	Avoid cast. If readlink fails with buffer size just under MAXSIZE,
    1091. 

  1091. 	try again with MAXSIZE.
    1092. 

  1092. 

  1093. 2004-11-02  Mark D. Baushke  <mdb@cvshome.org>
    1094. 

  1094. 

  1095. 	* filesubr.c (xreadlink): AIX and HP-UX readlink() returns ERANGE
    1096. 

  1096. 	when there is not enough room in the buffer.
    1097. 

  1097. 

  1098. 2004-11-01 Derek Price <derek@ximbiot.com>
    1099. 

  1099. 

  1100. 	* sanity.sh (rcslib): Fix typo in path.
    1101. 

  1101. 

  1102. 2004-11-01 Derek Price <derek@ximbiot.com>
    1103. 

  1103. 

  1104. 	* sanity.sh (rcslib): Test a link to a path longer than 128
    1105. 

  1105. 	characters.
    1106. 

  1106. 

  1107. 2004-10-29 Derek Price <derek@ximbiot.com>
    1108. 

  1108. 

  1109. 	* filesubr.c (xreadlink): Make sure allocation is tried once at the
    1110. 

  1110. 	maximum buffer size.  Protect against overflow.
    1111. 

  1111. 

  1112. 2004-10-29  Mark D. Baushke  <mdb@cvshome.org>
    1113. 

  1113. 

  1114. 	* filesubr.c (SIZE_MAX, SSIZE_MAX): Use #include "xsize.h" instead.
    1115. 

  1115. 	(xreadlink): Use xrealloc instead of xmalloc/free.
    1116. 

  1116. 

  1117. 2004-10-29  Mark D. Baushke  <mdb@cvshome.org>
    1118. 

  1118. 

  1119. 	* filesubr.c (SIZE_MAX, SSIZE_MAX): New constants.
    1120. 

  1120. 	(xreadlink): Deal with symlinks longer than 127 bytes.
    1121. 

  1121. 	(Problem reported as issue 190 by Gottfried Ganssauge
    1122. 

  1122. 	<gotti@cvshome.org>.)
    1123. 

  1123. 

  1124. 2004-10-28  Mark D. Baushke  <mdb@cvshome.org>
    1125. 

  1125. 

  1126. 	* release.c (release): Allow builds of cvs with --disable-server
    1127. 

  1127. 	--disable-client both used for local installation configuration.
    1128. 

  1128. 	* root.c (Name_Root): Ditto.
    1129. 

  1129. 	* update.c (checkout_file): Ditto.
    1130. 

  1130. 	(Problem reported by Jean Olivier Caron <jecar@mlab.t.u-tokyo.ac.jp>.)
    1131. 

  1131. 

  1132. 2004-10-27  Mark D. Baushke  <mdb@cvshome.org>
    1133. 

  1133. 

  1134. 	* cvs.h (RCS_FLAGS_USETIME): New flag.
    1135. 

  1135. 	* rcs.c (RCS_checkin): Add citime argument.
    1136. 

  1136. 	* rcs.h (RCS_checkin): Ditto.
    1137. 

  1137. 	* checkin.c (Checkin): Pass new RCS_checkin argument.
    1138. 

  1138. 	* commit.c (remove_file, checkaddfile): Ditto.
    1139. 

  1139. 	* import.c (add_rev): Ditto.
    1140. 

  1140. 

  1141. 	* sanity.sh (tagdate): Delete tagdate-19b as an incorrect test.
    1142. 

  1142. 

  1143. 2004-10-27  Mark D. Baushke  <mdb@cvshome.org>
    1144. 

  1144. 

  1145. 	* sanity.sh (tagdate): Provide more output.
    1146. 

  1146. 

  1147. 2004-10-26  Mark D. Baushke  <mdb@cvshome.org>
    1148. 

  1148. 

  1149. 	* commit.c (checkaddfile): Create a dead version for a new file
    1150. 

  1150. 	added to a branch. Fixes FIXCVS for tagdate tests.
    1151. 

  1151. 	* sanity.sh (tagdate): Update to expect correct results.
    1152. 

  1152. 	(death2, branch-after-import, join, ignore-on-branch): Ditto.
    1153. 

  1153. 

  1154. 2004-10-26 Derek Price <derek@ximbiot.com>
    1155. 

  1155. 

  1156. 	* client.c (connect_to_gserver): Avoid truncating error messages from
    1157. 

  1157. 	the GSSAPI server.
    1158. 

  1158. 	(Report from Dan Peterson <dbpete@aol.com>.)
    1159. 

  1159. 

  1160. 2004-10-26 Derek Price <derek@ximbiot.com>
    1161. 

  1161. 

  1162. 	* sanity.sh (import-quirks): Test an even branch number.
    1163. 

  1163. 

  1164. 2004-10-25 Derek Price <derek@ximbiot.com>
    1165. 

  1165. 

  1166. 	* import.c (import): Repair regex for regressions introduced in last
    1167. 

  1167. 	commit.
    1168. 

  1168. 	* sanity.sh (import-quirks): Test a few branch numbers import shouldn't
    1169. 

  1169. 	have a problem with.
    1170. 

  1170. 

  1171. 2004-10-25 Derek Price <derek@ximbiot.com>
    1172. 

  1172. 

  1173. 	* import.c (import): Anchor and simplify branch verification regex.
    1174. 

  1174. 	* sanity.sh (import-quirks): Test another pattern that should fail.
    1175. 

  1175. 

  1176. 2004-10-25  Mark D. Baushke  <mdb@cvshome.org>
    1177. 

  1177. 

  1178. 	* sanity.sh (tagdate): Added some additional tests and FIXCVS
    1179. 

  1179. 	comments for dealing properly with a 'cvs add' of a file to
    1180. 

  1180. 	a branch that already exists on the mainline.
    1181. 

  1181. 	(Problem reported by Renny Barrett <rbarrett@curamsoftware.com>.)
    1182. 

  1182. 

  1183. 	* sanity.sh (getrlogdate): New shell function.
    1184. 

  1184. 	(tagdate-{13,14,16}): Use it to avoid 'sleep 60' by using
    1185. 

  1185. 	the exact 1.1.4.1 timestamp for tagdate-14 and tagdate-16.
    1186. 

  1186. 

  1187. 2004-10-22  Mark D. Baushke  <mdb@cvshome.org>
    1188. 

  1188. 

  1189. 	* sanity.sh (tagdate): Fix typo.
    1190. 

  1190. 

  1191. 2004-10-19 Derek Price <derek@ximbiot.com>
    1192. 

  1192. 

  1193. 	* add.c (add): Avoid attempting to resurrect a dead rev 1.1.
    1194. 

  1194. 	* sanity.sh (resurrection): Add test for the above.
    1195. 

  1195. 	(Report from Dan Peterson <dbpete@aol.com>.)
    1196. 

  1196. 

  1197. 2004-10-14 Derek Price <derek@ximbiot.com>
    1198. 

  1198. 

  1199. 	* import.c (import): Verify branch specifications more thoroughly.
    1200. 

  1200. 	* sanity.sh (importb): Adapt to new error message.
    1201. 

  1201. 	(import-quirks): New test.
    1202. 

  1202. 

  1203. 2004-10-04 Derek Price <derek@ximbiot.com>
    1204. 

  1204. 

  1205. 	* cvs.h (CVSROOT_DFLT): Undef rather than defining to NULL.
    1206. 

  1206. 	* main.c (main): Untangle parsing of CVSROOT, eliminating several
    1207. 

  1207. 	variables in the process.  Simplify xmalloc/sprintf with asnprintf.
    1208. 

  1208. 

  1209. 2004-10-01  Mark D. Baushke  <mdb@cvshome.org>
    1210. 

  1210. 

  1211. 	* main.c (main): Initialize CVSroot before it is used.
    1212. 

  1212. 	(Report and patch by Martin Neitzel <neitzel@sco.gaertner.de>.)
    1213. 

  1213. 	* sanity.sh (status): Test it.
    1214. 

  1214. 

  1215. 2004-09-25  Mark D. Baushke  <mdb@cvshome.org>
    1216. 

  1216. 

  1217. 	* sanity.sh (parseroot2): Correct two test names.  Restore CVSROOT.
    1218. 

  1218. 

  1219. 	* sanity.sh (parseroot2): Expand dokeep inline.
    1220. 

  1220. 

  1221. 2004-09-24  Derek Price <derek@ximbiot.com>
    1222. 

  1222. 

  1223. 	* sanity.sh (tests): Add parseroot2.
    1224. 

  1224. 

  1225. 2004-09-24  Derek Price <derek@ximbiot.com>
    1226. 

  1226. 

  1227. 	* sanity.sh (parseroot2): New test for root parsing consistency.
    1228. 

  1228. 	(Original patch from Alexander Taler <dissent@cvshome.org>.)
    1229. 

  1229. 

  1230. 	* cvs.h (Name_Root, free_cvsroot_t, parse_cvsroot, local_cvsroot,
    1231. 

  1231. 	Create_Root, root_allow_add, root_allow_free, root_allow_ok): Move
    1232. 

  1232. 	these protos to...
    1233. 

  1233. 	* root.h: ...here.
    1234. 

  1234. 	* client.c (arg_should_not_be_sent_to_server), recurse.c
    1235. 

  1235. 	(start_recusrion, do_recursion): Use new Name_Root API.
    1236. 

  1236. 	* main.c (current_root): Remove global.
    1237. 

  1237. 	(set_root_directory): Set current_parsed_root directly.
    1238. 

  1238. 	(main): Use new Name_Root API.  Restore deletion of root directories
    1239. 

  1239. 	list.
    1240. 

  1240. 	* root.c (Name_Root): Return a parsed cvsroot_t rather than a string.
    1241. 

  1241. 

  1242. 2004-09-23  Derek Price <derek@ximbiot.com>
    1243. 

  1243. 

  1244. 	* sanity.sh (depends_on_ssh, sshstdio): Don't use skip() to skip
    1245. 

  1245. 	remote-only tests.
    1246. 

  1246. 

  1247. 2004-09-23  Mark D. Baushke  <mdb@cvshome.org>
    1248. 

  1248. 

  1249. 	* server.c (cvs_output, cvs_output_binary): fflush (stderr)
    1250. 

  1250. 	here to avoid problems with 'cvs status 2>&1'.
    1251. 

  1251. 	(Report by Frank Hemer <frank@hemer.org>.)
    1252. 

  1252. 

  1253. 2004-09-23  Derek Price <derek@ximbiot.com>
    1254. 

  1254. 

  1255. 	* sanity.sh (crerepos, sshstdio): Minor modifications to make use of
    1256. 

  1256. 	the new depends_on_?sh API.
    1257. 

  1257. 

  1258. 2004-09-23  Derek Price <derek@ximbiot.com>
    1259. 

  1259. 

  1260. 	* sanity.sh: Accept new -e option to interpret non-fatal calls to skip
    1261. 

  1261. 	as errors.
    1262. 

  1262. 	(skip, depends_on_rsh, depends_on_ssh): New functions.
    1263. 

  1263. 

  1264. 2004-09-12  Mark D. Baushke  <mdb@cvshome.org>
    1265. 

  1265. 

  1266. 	* rcs.c (RCS_checkout): Allow noexec to do checkouts when
    1267. 

  1267. 	server_active is true.
    1268. 

  1268. 	* sanity.sh (join7): Test above change (fixes a FIXCVS).
    1269. 

  1269. 

  1270. 2004-09-08  Mark D. Baushke  <mdb@cvshome.org>
    1271. 

  1271. 

  1272. 	* sanity.sh (join7): Fix if-then-else conditional.
    1273. 

  1273. 

  1274. 	* server.c (server_updated): Deal with cvs -n update -jt1 -jt2
    1275. 

  1275. 	"protocol error: uncounted data discarded" problem.
    1276. 

  1276. 	* sanity.sh (join7): New test for this case.
    1277. 

  1277. 

  1278. 2004-08-24  Derek Price <derek@ximbiot.com>
    1279. 

  1279. 

  1280. 	* recurse.c (start_recursion): Don't shorten //. to / (use //).
    1281. 

    1282. 

  1282. 2004-08-24  Derek Price <derek@ximbiot.com>
    1283. 

  1283. 

  1284. 	* recurse.c (start_recursion): Strip trailing CWD indirections on
    1285. 

  1285. 	repository.
    1286. 

  1286. 	* sanity.sh (rstar-toplevel): Update to account for new behavior.
    1287. 

  1287. 	(Report from Dan Peterson <dbpete@aol.com>.)
    1288. 

  1288. 

  1289. 2004-08-24  Mark D. Baushke  <mdb@cvshome.org>
    1290. 

  1290. 

  1291. 	* recurse.c (do_recursion): Correct test for calling
    1292. 

  1292. 	server_pause_check to occur when locktype != CVS_LOCK_WRITE.
    1293. 

  1293. 	(Patch suggested by Ian Lance Taylor <ian@wasabisystems.com>
    1294. 

  1294. 	in bug#198).
    1295. 

  1295. 

  1296. 2004-08-24  Derek Price <derek@ximbiot.com>
    1297. 

  1297. 

  1298. 	* rcs.c (translate_symtag): Prevent infinite loop.
    1299. 

  1299. 	* tag.c (tag_check_valid): Check tag syntax before searching for tags.
    1300. 

  1300. 	* sanity.sh (tag-space): Some tests for the above.
    1301. 

  1301. 	(Report from Dan Peterson <dbpete@aol.com>.)
    1302. 

  1302. 

  1303. 2004-08-24  Mark D. Baushke  <mdb@cvshome.org>
    1304. 

  1304. 

  1305. 	* ignore.c (ignore_directory): Include the terminating NUL
    1306. 

  1306. 	character in the directory name comparison to avoid matching
    1307. 

  1307. 	substrings of directories by accident.
    1308. 

  1308. 	(Report and suggested fix from James E Wilson
    1309. 

  1309. 	<wilson@specifixinc.com>.)
    1310. 

  1310. 	* sanity.sh (modules4): Add some more tests testing the above
    1311. 

  1311. 	change.
    1312. 

  1312. 

  1313. 2004-08-17  Mark D. Baushke  <mdb@cvshome.org>
    1314. 

  1314. 

  1315. 	* sanity.sh (sshstdio): Fix comment typo plus gratuitous
    1316. 

  1316. 	reformatting.
    1317. 

  1317. 

  1318. 	* client.c (handle_m): Workaround to deal with stdio getting put
    1319. 

  1319. 	into non-blocking via redirection of stderr and interaction with
    1320. 

  1320. 	ssh on some platforms. On those boxes, stdio can put stdout
    1321. 

  1321. 	unexpectedly into non-blocking mode which may lead to fwrite() or
    1322. 

  1322. 	fflush() failing with EAGAIN, but cvs not checking for the error.
    1323. 

  1323. 	(Patch suggested by Frank Hemer <frank@hemer.org>.)
    1324. 

  1324. 

  1325. 	* client.c (handle_e): Similar fix for stderr.
    1326. 

  1326. 	* sanity.sh (sshstdio): New test for non-blocking stdio via ssh.
    1327. 

  1327. 

  1328. 2004-08-11  Derek Price <derek@ximbiot.com>
    1329. 

  1329. 

  1330. 	* sanity.sh (basicc): Work around a problem in Linux 2.2 & Bash 2.05b
    1331. 

  1331. 	which prevents a `cd ..' from a deleted directory from working.
    1332. 

  1332. 	(Original patch from Matthew Ogilvie <mmo9317bd@mailcan.com>.)
    1333. 

    1334. 

  1334. 2004-06-22  Derek Price  <derek@ximbiot.com>
    1335. 

    1336. 

  1336. 	* wrapper.c: Add explicit "void" return type to "wrap_clean_fmt_str"
    1337. 

  1337. 	definition.
    1338. 

  1338. 	(Patch from Conrad T. Pino <Conrad@Pino.com>.)
    1339. 

    1340. 

  1340. 2004-06-09  Derek Price  <derek@ximbiot.com>
    1341. 

    1342. 

  1342. 	* commit.c, filesubr.c, history.c, server.c, wrapper.c: Various
    1343. 

  1343. 	security fixes.
    1344. 

  1344. 	(Original patch from Stefan Essler <s.esser@e-matters.de> & Sebastian
    1345. 

  1345. 	Krahmer <krahmer@suse.de>.)
    1346. 

    1347. 

  1347. 	* cvs.h: Include xsize.h.
    1348. 

    1349. 

  1349. 2004-06-09  Derek Price  <derek@ximbiot.com>
    1350. 

    1351. 

  1351. 	* server.c (serve_entry, serve_is_modified, serve_unchanged): Protect
    1352. 

  1352. 	against malformed entries.
    1353. 

  1353. 	* sanity.sh (server): Tests for same.
    1354. 

    1355. 

  1355. 2004-06-07  Larry Jones  <lawrence.jones@ugsplm.com>
    1356. 

    1357. 

  1357. 	* sanity.sh (basica): More tests for string-based revision inc.
    1358. 

    1359. 

  1359. 2004-06-04  Larry Jones  <lawrence.jones@ugsplm.com>
    1360. 

    1361. 

  1361. 	* subr.c (increment_revnum): Rewrite ala RCS to work directly on
    1362. 

  1362. 	the string rather than converting to int to avoid overflow.
    1363. 

  1363. 	* sanity.sh (basica): New tests for above, update others to match.
    1364. 

    1365. 

  1365. 2004-05-19  Derek Price  <derek@ximbiot.com>
    1366. 

    1367. 

  1367. 	* server.c (serve_unchanged, serve_is_modified): Overwrite existing
    1368. 

  1368. 	data in timefields.  Fixes CAN-2004-0396.
    1369. 

    1370. 

  1370. 2004-05-14  Derek Price  <derek@ximbiot.com>
    1371. 

    1372. 

  1372. 	* subr.c (file_has_conflict), vers_ts.c (time_stamp_server): Don't
    1373. 

  1373. 	require '=' to be the only character here, as this is potentially
    1374. 

  1374. 	destabilizing.
    1375. 

    1376. 

  1376. 2004-05-14  Mark D. Baushke  <mdb@cvshome.org>
    1377. 

    1378. 

  1378. 	* sanity.sh (trailingslashes): During cleanup remove topfile,v to
    1379. 

  1379. 	avoid problems in later tests (editor-1).
    1380. 

    1381. 

  1381. 2004-05-13  Derek Price  <derek@ximbiot.com>
    1382. 

    1383. 

  1383. 	* sanity.sh (trailingslashes): Note TODO item #205 in the comment.
    1384. 

    1385. 

  1385. 2004-05-13  Derek Price  <derek@ximbiot.com>
    1386. 

    1387. 

  1387. 	* sanity.sh (trailingslashes): New tests to expose a bug in CVS when
    1388. 

  1388. 	paths are specified with trailing slashes.  This relates to TODO #205.
    1389. 

    1390. 

  1390. 2004-05-12  Derek Price  <derek@ximbiot.com>
    1391. 

    1392. 

  1392. 	* subr.c (file_has_conflict), vers_ts.c (time_stamp_server): Only
    1393. 

  1393. 	special case "=" when it is the only character in a timestamp field.
    1394. 

  1394. 	Gratuitous reformatting.
    1395. 

  1395. 	* vers_ts.c (time_stamp_server): Check for NULL in a consistent manner.
    1396. 

  1396. 	Gratuitous reformatting.
    1397. 

    1398. 

  1398. 2004-05-10  Derek Price  <derek@ximbiot.com>
    1399. 

    1400. 

  1400. 	* sanity.sh (top-level): Rename to...
    1401. 

  1401. 	(rstar-toplevel): ...this for clarity.
    1402. 

    1403. 

  1403. 2004-05-10  Derek Price  <derek@ximbiot.com>
    1404. 

    1405. 

  1405. 	* sanity.sh (dirs2-10ar): Remove unnecessary empty argument.
    1406. 

    1407. 

  1407. 2004-05-02  Larry Jones  <lawrence.jones@ugsplm.com>
    1408. 

    1409. 

  1409. 	* log.c (log_expand_revlist): Suppress warnings if really_quiet.
    1410. 

    1411. 

  1411. 2004-05-07  Derek Price  <derek@ximbiot.com>
    1412. 

    1413. 

  1413. 	* sanity.sh (basica): Remove unnecessary empty arguments.
    1414. 

    1415. 

  1415. 2004-05-07  Derek Price  <derek@ximbiot.com>
    1416. 

    1417. 

  1417. 	* cvs.h (fopen_case): Remove obsolescent prototype.
    1418. 

    1419. 

  1419. 2004-05-05  Derek Price  <derek@ximbiot.com>
    1420. 

    1421. 

  1421. 	* sanity.sh: Wait a second and retry if cvs-serv* directories are
    1422. 

  1422. 	discovered to avoid race conditions on some systems.
    1423. 

  1423. 	(Patch from Pavel Roskin <proski@gnu.org>.)
    1424. 

    1425. 

  1425. 2004-05-05  Derek Price  <derek@ximbiot.com>
    1426. 

    1427. 

  1427. 	* commit.c: Some gratuitous reformatting.
    1428. 

    1429. 

  1429. 2004-05-04  Derek Price  <derek@ximbiot.com>
    1430. 

    1431. 

  1431. 	* update.c: Some gratuitous reformatting.
    1432. 

    1433. 

  1433. 2004-05-04  Derek Price  <derek@ximbiot.com>
    1434. 

    1435. 

  1435. 	* add.c (add): Remove obsolete FIXME comment.
    1436. 

  1436. 	(*): Some gratuitous reformatting.
    1437. 

    1438. 

  1438. 2004-04-26  Derek Price  <derek@ximbiot.com>
    1439. 

    1440. 

  1440. 	* client.c (start_rsh_server): Don't rely on GNU argument processing
    1441. 

  1441. 	capabilities in the RSH command.
    1442. 

  1442. 	(Report from Mark Andrews <Mark_Andrews@isc.org>.)
    1443. 

    1444. 

  1444. 2004-04-19  Derek Price  <derek@ximbiot.com>
    1445. 

    1446. 

  1446. 	* ignore.c: Gratuitous reformatting.
    1447. 

    1448. 

  1448. 2004-04-11  Derek Price  <derek@ximbiot.com>
    1449. 

    1450. 

  1450. 	* client.c (call_in_directory): Check paths the server sends us to make
    1451. 

  1451. 	sure they are within a sandbox the user requested be updated.
    1452. 

  1452. 	(is_valid_client_path, path_list_prefixed): New functions.
    1453. 

    1454. 

  1454. 2004-04-11  Derek Price  <derek@ximbiot.com>
    1455. 

    1456. 

  1456. 	* modules.c (do_module): Don't allow up-level references in paths to
    1457. 

  1457. 	step out of the repository.
    1458. 

  1458. 	* sanity.sh (multiroot3): Update tests and add a few more.
    1459. 

    1460. 

  1460. 2004-04-07  Derek Price  <derek@ximbiot.com>
    1461. 

    1462. 

  1462. 	* sanity.sh (parseroot): Replace hard path with $HOME.
    1463. 

    1464. 

  1464. 2004-04-07  Derek Price  <derek@ximbiot.com>
    1465. 

    1466. 

  1466. 	* sanity.sh (parseroot): s/oberon/$username/.
    1467. 

    1468. 

  1468. 2004-04-07  Derek Price  <derek@ximbiot.com>
    1469. 

    1470. 

  1470. 	* client.c (start_tcp_server): Use xstrdup rather than
    1471. 

  1471. 	xmalloc(strlen)/strcpy.
    1472. 

    1473. 

  1473. 2004-04-07  Derek Price  <der…
    1474.