/lib/rails_best_practices/reviews/dry_bundler_in_capistrano_review.rb

http://github.com/flyerhzm/rails_best_practices · Ruby · 29 lines · 14 code · 2 blank · 13 comment · 4 complexity · b712d3c9a9cbe8cd2a5ca6991e13f070 MD5 · raw file

  1. # frozen_string_literal: true
  2. module RailsBestPractices
  3. module Reviews
  4. # Review config/deploy.rb file to make sure using the bundler's capistrano recipe.
  5. #
  6. # See the best practice details here https://rails-bestpractices.com/posts/2010/09/02/dry-bundler-in-capistrano/
  7. #
  8. # Implementation:
  9. #
  10. # Review process:
  11. # only check the command nodes to see if there is bundler namespace in config/deploy.rb file,
  12. #
  13. # if the message of command node is "namespace" and the first argument is "bundler",
  14. # then it should use bundler's capistrano recipe.
  15. class DryBundlerInCapistranoReview < Review
  16. interesting_nodes :command
  17. interesting_files DEPLOY_FILES
  18. url 'https://rails-bestpractices.com/posts/2010/09/02/dry-bundler-in-capistrano/'
  19. # check call node to see if it is with message "namespace" and argument "bundler".
  20. add_callback :start_command do |node|
  21. if node.message.to_s == 'namespace' && node.arguments.all[0].to_s == 'bundler'
  22. add_error 'dry bundler in capistrano'
  23. end
  24. end
  25. end
  26. end
  27. end