/spec/helpers/issues_helper_spec.rb

https://gitlab.com/artofhuman/gitlab-ce · Ruby · 188 lines · 149 code · 39 blank · 0 comment · 7 complexity · 5e69010fb33d6e87e72dd503e9a8952e MD5 · raw file

  1. require "spec_helper"
  2. describe IssuesHelper do
  3. let(:project) { create(:project) }
  4. let(:issue) { create :issue, project: project }
  5. let(:ext_project) { create :redmine_project }
  6. describe "url_for_issue" do
  7. let(:issues_url) { ext_project.external_issue_tracker.issues_url}
  8. let(:ext_expected) { issues_url.gsub(':id', issue.iid.to_s).gsub(':project_id', ext_project.id.to_s) }
  9. let(:int_expected) { polymorphic_path([@project.namespace, @project, issue]) }
  10. it "returns internal path if used internal tracker" do
  11. @project = project
  12. expect(url_for_issue(issue.iid)).to match(int_expected)
  13. end
  14. it "returns path to external tracker" do
  15. @project = ext_project
  16. expect(url_for_issue(issue.iid)).to match(ext_expected)
  17. end
  18. it "returns path to internal issue when internal option passed" do
  19. @project = ext_project
  20. expect(url_for_issue(issue.iid, ext_project, internal: true)).to match(int_expected)
  21. end
  22. it "returns empty string if project nil" do
  23. @project = nil
  24. expect(url_for_issue(issue.iid)).to eq ""
  25. end
  26. it 'returns an empty string if issue_url is invalid' do
  27. expect(project).to receive_message_chain('issues_tracker.issue_url') { 'javascript:alert("foo");' }
  28. expect(url_for_issue(issue.iid, project)).to eq ''
  29. end
  30. it 'returns an empty string if issue_path is invalid' do
  31. expect(project).to receive_message_chain('issues_tracker.issue_path') { 'javascript:alert("foo");' }
  32. expect(url_for_issue(issue.iid, project, only_path: true)).to eq ''
  33. end
  34. describe "when external tracker was enabled and then config removed" do
  35. before do
  36. @project = ext_project
  37. allow(Gitlab.config).to receive(:issues_tracker).and_return(nil)
  38. end
  39. it "returns external path" do
  40. expect(url_for_issue(issue.iid)).to match(ext_expected)
  41. end
  42. end
  43. end
  44. describe '#award_user_list' do
  45. it "returns a comma-separated list of the first X users" do
  46. user = build_stubbed(:user, name: 'Joe')
  47. awards = Array.new(3, build_stubbed(:award_emoji, user: user))
  48. expect(award_user_list(awards, nil, limit: 3))
  49. .to eq('Joe, Joe, and Joe')
  50. end
  51. it "displays the current user's name as 'You'" do
  52. user = build_stubbed(:user, name: 'Joe')
  53. award = build_stubbed(:award_emoji, user: user)
  54. expect(award_user_list([award], user)).to eq('You')
  55. expect(award_user_list([award], nil)).to eq 'Joe'
  56. end
  57. it "truncates lists" do
  58. user = build_stubbed(:user, name: 'Jane')
  59. awards = Array.new(5, build_stubbed(:award_emoji, user: user))
  60. expect(award_user_list(awards, nil, limit: 3))
  61. .to eq('Jane, Jane, Jane, and 2 more.')
  62. end
  63. it "displays the current user in front of other users" do
  64. current_user = build_stubbed(:user)
  65. my_award = build_stubbed(:award_emoji, user: current_user)
  66. award = build_stubbed(:award_emoji, user: build_stubbed(:user, name: 'Jane'))
  67. awards = Array.new(5, award).push(my_award)
  68. expect(award_user_list(awards, current_user, limit: 2))
  69. .to eq("You, Jane, and 4 more.")
  70. end
  71. end
  72. describe '#award_state_class' do
  73. let!(:upvote) { create(:award_emoji) }
  74. let(:awardable) { upvote.awardable }
  75. let(:user) { upvote.user }
  76. before do
  77. allow(helper).to receive(:can?) do |*args|
  78. Ability.allowed?(*args)
  79. end
  80. end
  81. it "returns disabled string for unauthenticated user" do
  82. expect(helper.award_state_class(awardable, AwardEmoji.all, nil)).to eq("disabled")
  83. end
  84. it "returns disabled for a user that does not have access to the awardable" do
  85. expect(helper.award_state_class(awardable, AwardEmoji.all, build(:user))).to eq("disabled")
  86. end
  87. it "returns active string for author" do
  88. expect(helper.award_state_class(awardable, AwardEmoji.all, upvote.user)).to eq("active")
  89. end
  90. it "is blank for a user that has access to the awardable" do
  91. user = build(:user)
  92. expect(helper).to receive(:can?).with(user, :award_emoji, awardable).and_return(true)
  93. expect(helper.award_state_class(awardable, AwardEmoji.all, user)).to be_blank
  94. end
  95. end
  96. describe "awards_sort" do
  97. it "sorts a hash so thumbsup and thumbsdown are always on top" do
  98. data = { "thumbsdown" => "some value", "lifter" => "some value", "thumbsup" => "some value" }
  99. expect(awards_sort(data).keys).to eq(%w(thumbsup thumbsdown lifter))
  100. end
  101. end
  102. describe "#link_to_discussions_to_resolve" do
  103. describe "passing only a merge request" do
  104. let(:merge_request) { create(:merge_request) }
  105. it "links just the merge request" do
  106. expected_path = project_merge_request_path(merge_request.project, merge_request)
  107. expect(link_to_discussions_to_resolve(merge_request, nil)).to include(expected_path)
  108. end
  109. it "containst the reference to the merge request" do
  110. expect(link_to_discussions_to_resolve(merge_request, nil)).to include(merge_request.to_reference)
  111. end
  112. end
  113. describe "when passing a discussion" do
  114. let(:diff_note) { create(:diff_note_on_merge_request) }
  115. let(:merge_request) { diff_note.noteable }
  116. let(:discussion) { diff_note.to_discussion }
  117. it "links to the merge request with first note if a single discussion was passed" do
  118. expected_path = Gitlab::UrlBuilder.build(diff_note)
  119. expect(link_to_discussions_to_resolve(merge_request, discussion)).to include(expected_path)
  120. end
  121. it "contains both the reference to the merge request and a mention of the discussion" do
  122. expect(link_to_discussions_to_resolve(merge_request, discussion)).to include("#{merge_request.to_reference} (discussion #{diff_note.id})")
  123. end
  124. end
  125. end
  126. describe '#show_new_issue_link?' do
  127. before do
  128. allow(helper).to receive(:current_user)
  129. end
  130. it 'is false when no project there is no project' do
  131. expect(helper.show_new_issue_link?(nil)).to be_falsey
  132. end
  133. it 'is true when there is a project and no logged in user' do
  134. expect(helper.show_new_issue_link?(build(:project))).to be_truthy
  135. end
  136. it 'is true when the current user does not have access to the project' do
  137. project = build(:project)
  138. allow(helper).to receive(:current_user).and_return(project.owner)
  139. expect(helper).to receive(:can?).with(project.owner, :create_issue, project).and_return(true)
  140. expect(helper.show_new_issue_link?(project)).to be_truthy
  141. end
  142. end
  143. end