/spec/requests/api/events_spec.rb

https://gitlab.com/tbeadle/gitlab-ce · Ruby · 200 lines · 157 code · 43 blank · 0 comment · 2 complexity · 95670538dc617aeb2174d041040e0775 MD5 · raw file

  1. require 'spec_helper'
  2. describe API::Events do
  3. include ApiHelpers
  4. let(:user) { create(:user) }
  5. let(:non_member) { create(:user) }
  6. let(:other_user) { create(:user, username: 'otheruser') }
  7. let(:private_project) { create(:project, :private, creator_id: user.id, namespace: user.namespace) }
  8. let(:closed_issue) { create(:closed_issue, project: private_project, author: user) }
  9. let!(:closed_issue_event) { create(:event, project: private_project, author: user, target: closed_issue, action: Event::CLOSED, created_at: Date.new(2016, 12, 30)) }
  10. describe 'GET /events' do
  11. context 'when unauthenticated' do
  12. it 'returns authentication error' do
  13. get api('/events')
  14. expect(response).to have_gitlab_http_status(401)
  15. end
  16. end
  17. context 'when authenticated' do
  18. it 'returns users events' do
  19. get api('/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31', user)
  20. expect(response).to have_gitlab_http_status(200)
  21. expect(response).to include_pagination_headers
  22. expect(json_response).to be_an Array
  23. expect(json_response.size).to eq(1)
  24. end
  25. end
  26. end
  27. describe 'GET /users/:id/events' do
  28. context "as a user that cannot see the event's project" do
  29. it 'returns no events' do
  30. get api("/users/#{user.id}/events", other_user)
  31. expect(response).to have_gitlab_http_status(200)
  32. expect(json_response).to be_empty
  33. end
  34. end
  35. context "as a user that can see the event's project" do
  36. it 'accepts a username' do
  37. get api("/users/#{user.username}/events", user)
  38. expect(response).to have_gitlab_http_status(200)
  39. expect(response).to include_pagination_headers
  40. expect(json_response).to be_an Array
  41. expect(json_response.size).to eq(1)
  42. end
  43. it 'returns the events' do
  44. get api("/users/#{user.id}/events", user)
  45. expect(response).to have_gitlab_http_status(200)
  46. expect(response).to include_pagination_headers
  47. expect(json_response).to be_an Array
  48. expect(json_response.size).to eq(1)
  49. end
  50. context 'when the list of events includes push events' do
  51. let(:event) do
  52. create(:push_event, author: user, project: private_project)
  53. end
  54. let!(:payload) { create(:push_event_payload, event: event) }
  55. let(:payload_hash) { json_response[0]['push_data'] }
  56. before do
  57. get api("/users/#{user.id}/events?action=pushed", user)
  58. end
  59. it 'responds with HTTP 200 OK' do
  60. expect(response).to have_gitlab_http_status(200)
  61. end
  62. it 'includes the push payload as a Hash' do
  63. expect(payload_hash).to be_an_instance_of(Hash)
  64. end
  65. it 'includes the push payload details' do
  66. expect(payload_hash['commit_count']).to eq(payload.commit_count)
  67. expect(payload_hash['action']).to eq(payload.action)
  68. expect(payload_hash['ref_type']).to eq(payload.ref_type)
  69. expect(payload_hash['commit_to']).to eq(payload.commit_to)
  70. end
  71. end
  72. context 'when there are multiple events from different projects' do
  73. let(:second_note) { create(:note_on_issue, project: create(:project)) }
  74. before do
  75. second_note.project.add_user(user, :developer)
  76. [second_note].each do |note|
  77. EventCreateService.new.leave_note(note, user)
  78. end
  79. end
  80. it 'returns events in the correct order (from newest to oldest)' do
  81. get api("/users/#{user.id}/events", user)
  82. comment_events = json_response.select { |e| e['action_name'] == 'commented on' }
  83. close_events = json_response.select { |e| e['action_name'] == 'closed' }
  84. expect(comment_events[0]['target_id']).to eq(second_note.id)
  85. expect(close_events[0]['target_id']).to eq(closed_issue.id)
  86. end
  87. it 'accepts filter parameters' do
  88. get api("/users/#{user.id}/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31", user)
  89. expect(json_response.size).to eq(1)
  90. expect(json_response[0]['target_id']).to eq(closed_issue.id)
  91. end
  92. end
  93. end
  94. it 'returns a 404 error if not found' do
  95. get api('/users/42/events', user)
  96. expect(response).to have_gitlab_http_status(404)
  97. expect(json_response['message']).to eq('404 User Not Found')
  98. end
  99. end
  100. describe 'GET /projects/:id/events' do
  101. context 'when unauthenticated ' do
  102. it 'returns 404 for private project' do
  103. get api("/projects/#{private_project.id}/events")
  104. expect(response).to have_gitlab_http_status(404)
  105. end
  106. it 'returns 200 status for a public project' do
  107. public_project = create(:project, :public)
  108. get api("/projects/#{public_project.id}/events")
  109. expect(response).to have_gitlab_http_status(200)
  110. end
  111. end
  112. context 'when not permitted to read' do
  113. it 'returns 404' do
  114. get api("/projects/#{private_project.id}/events", non_member)
  115. expect(response).to have_gitlab_http_status(404)
  116. end
  117. end
  118. context 'when authenticated' do
  119. it 'returns project events' do
  120. get api("/projects/#{private_project.id}/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31", user)
  121. expect(response).to have_gitlab_http_status(200)
  122. expect(response).to include_pagination_headers
  123. expect(json_response).to be_an Array
  124. expect(json_response.size).to eq(1)
  125. end
  126. it 'returns 404 if project does not exist' do
  127. get api("/projects/1234/events", user)
  128. expect(response).to have_gitlab_http_status(404)
  129. end
  130. end
  131. context 'when exists some events' do
  132. let(:merge_request1) { create(:merge_request, :closed, author: user, assignee: user, source_project: private_project, title: 'Test') }
  133. let(:merge_request2) { create(:merge_request, :closed, author: user, assignee: user, source_project: private_project, title: 'Test') }
  134. before do
  135. create_event(merge_request1)
  136. end
  137. it 'avoids N+1 queries' do
  138. control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do
  139. get api("/projects/#{private_project.id}/events", user), target_type: :merge_request
  140. end.count
  141. create_event(merge_request2)
  142. expect do
  143. get api("/projects/#{private_project.id}/events", user), target_type: :merge_request
  144. end.not_to exceed_all_query_limit(control_count)
  145. expect(response).to have_gitlab_http_status(200)
  146. expect(response).to include_pagination_headers
  147. expect(json_response.size).to eq(2)
  148. expect(json_response.map { |r| r['target_id'] }).to match_array([merge_request1.id, merge_request2.id])
  149. end
  150. def create_event(target)
  151. create(:event, project: private_project, author: user, target: target)
  152. end
  153. end
  154. end
  155. end