/spec/requests/api/events_spec.rb
https://gitlab.com/tbeadle/gitlab-ce · Ruby · 200 lines · 157 code · 43 blank · 0 comment · 2 complexity · 95670538dc617aeb2174d041040e0775 MD5 · raw file
- require 'spec_helper'
- describe API::Events do
- include ApiHelpers
- let(:user) { create(:user) }
- let(:non_member) { create(:user) }
- let(:other_user) { create(:user, username: 'otheruser') }
- let(:private_project) { create(:project, :private, creator_id: user.id, namespace: user.namespace) }
- let(:closed_issue) { create(:closed_issue, project: private_project, author: user) }
- let!(:closed_issue_event) { create(:event, project: private_project, author: user, target: closed_issue, action: Event::CLOSED, created_at: Date.new(2016, 12, 30)) }
- describe 'GET /events' do
- context 'when unauthenticated' do
- it 'returns authentication error' do
- get api('/events')
- expect(response).to have_gitlab_http_status(401)
- end
- end
- context 'when authenticated' do
- it 'returns users events' do
- get api('/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31', user)
- expect(response).to have_gitlab_http_status(200)
- expect(response).to include_pagination_headers
- expect(json_response).to be_an Array
- expect(json_response.size).to eq(1)
- end
- end
- end
- describe 'GET /users/:id/events' do
- context "as a user that cannot see the event's project" do
- it 'returns no events' do
- get api("/users/#{user.id}/events", other_user)
- expect(response).to have_gitlab_http_status(200)
- expect(json_response).to be_empty
- end
- end
- context "as a user that can see the event's project" do
- it 'accepts a username' do
- get api("/users/#{user.username}/events", user)
- expect(response).to have_gitlab_http_status(200)
- expect(response).to include_pagination_headers
- expect(json_response).to be_an Array
- expect(json_response.size).to eq(1)
- end
- it 'returns the events' do
- get api("/users/#{user.id}/events", user)
- expect(response).to have_gitlab_http_status(200)
- expect(response).to include_pagination_headers
- expect(json_response).to be_an Array
- expect(json_response.size).to eq(1)
- end
- context 'when the list of events includes push events' do
- let(:event) do
- create(:push_event, author: user, project: private_project)
- end
- let!(:payload) { create(:push_event_payload, event: event) }
- let(:payload_hash) { json_response[0]['push_data'] }
- before do
- get api("/users/#{user.id}/events?action=pushed", user)
- end
- it 'responds with HTTP 200 OK' do
- expect(response).to have_gitlab_http_status(200)
- end
- it 'includes the push payload as a Hash' do
- expect(payload_hash).to be_an_instance_of(Hash)
- end
- it 'includes the push payload details' do
- expect(payload_hash['commit_count']).to eq(payload.commit_count)
- expect(payload_hash['action']).to eq(payload.action)
- expect(payload_hash['ref_type']).to eq(payload.ref_type)
- expect(payload_hash['commit_to']).to eq(payload.commit_to)
- end
- end
- context 'when there are multiple events from different projects' do
- let(:second_note) { create(:note_on_issue, project: create(:project)) }
- before do
- second_note.project.add_user(user, :developer)
- [second_note].each do |note|
- EventCreateService.new.leave_note(note, user)
- end
- end
- it 'returns events in the correct order (from newest to oldest)' do
- get api("/users/#{user.id}/events", user)
- comment_events = json_response.select { |e| e['action_name'] == 'commented on' }
- close_events = json_response.select { |e| e['action_name'] == 'closed' }
- expect(comment_events[0]['target_id']).to eq(second_note.id)
- expect(close_events[0]['target_id']).to eq(closed_issue.id)
- end
- it 'accepts filter parameters' do
- get api("/users/#{user.id}/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31", user)
- expect(json_response.size).to eq(1)
- expect(json_response[0]['target_id']).to eq(closed_issue.id)
- end
- end
- end
- it 'returns a 404 error if not found' do
- get api('/users/42/events', user)
- expect(response).to have_gitlab_http_status(404)
- expect(json_response['message']).to eq('404 User Not Found')
- end
- end
- describe 'GET /projects/:id/events' do
- context 'when unauthenticated ' do
- it 'returns 404 for private project' do
- get api("/projects/#{private_project.id}/events")
- expect(response).to have_gitlab_http_status(404)
- end
- it 'returns 200 status for a public project' do
- public_project = create(:project, :public)
- get api("/projects/#{public_project.id}/events")
- expect(response).to have_gitlab_http_status(200)
- end
- end
- context 'when not permitted to read' do
- it 'returns 404' do
- get api("/projects/#{private_project.id}/events", non_member)
- expect(response).to have_gitlab_http_status(404)
- end
- end
- context 'when authenticated' do
- it 'returns project events' do
- get api("/projects/#{private_project.id}/events?action=closed&target_type=issue&after=2016-12-1&before=2016-12-31", user)
- expect(response).to have_gitlab_http_status(200)
- expect(response).to include_pagination_headers
- expect(json_response).to be_an Array
- expect(json_response.size).to eq(1)
- end
- it 'returns 404 if project does not exist' do
- get api("/projects/1234/events", user)
- expect(response).to have_gitlab_http_status(404)
- end
- end
- context 'when exists some events' do
- let(:merge_request1) { create(:merge_request, :closed, author: user, assignee: user, source_project: private_project, title: 'Test') }
- let(:merge_request2) { create(:merge_request, :closed, author: user, assignee: user, source_project: private_project, title: 'Test') }
- before do
- create_event(merge_request1)
- end
- it 'avoids N+1 queries' do
- control_count = ActiveRecord::QueryRecorder.new(skip_cached: false) do
- get api("/projects/#{private_project.id}/events", user), target_type: :merge_request
- end.count
- create_event(merge_request2)
- expect do
- get api("/projects/#{private_project.id}/events", user), target_type: :merge_request
- end.not_to exceed_all_query_limit(control_count)
- expect(response).to have_gitlab_http_status(200)
- expect(response).to include_pagination_headers
- expect(json_response.size).to eq(2)
- expect(json_response.map { |r| r['target_id'] }).to match_array([merge_request1.id, merge_request2.id])
- end
- def create_event(target)
- create(:event, project: private_project, author: user, target: target)
- end
- end
- end
- end