Use let or const to avoid scope issues and hoisting
var createError = require('http-errors')
1'use strict'23/**4 * Module dependencies.5 */67var createError = require('http-errors')8var express = require('../../');9var app = module.exports = express();1011// Faux database1213var users = [14 { name: 'tj' }15 , { name: 'tobi' }16 , { name: 'loki' }17 , { name: 'jane' }18 , { name: 'bandit' }19];2021// Convert :to and :from to integers2223app.param(['to', 'from'], function(req, res, next, num, name){24 req.params[name] = parseInt(num, 10);25 if( isNaN(req.params[name]) ){26 next(createError(400, 'failed to parseInt '+num));27 } else {28 next();29 }30});3132// Load user by id3334app.param('user', function(req, res, next, id){35 req.user = users[id]36 if (req.user) {37 next();38 } else {39 next(createError(404, 'failed to find user'));40 }41});4243/**44 * GET index.45 */4647app.get('/', function(req, res){48 res.send('Visit /user/0 or /users/0-2');49});5051/**52 * GET :user.53 */5455app.get('/user/:user', function (req, res) {56 res.send('user ' + req.user.name);57});5859/**60 * GET users :from - :to.61 */6263app.get('/users/:from-:to', function (req, res) {64 var from = req.params.from;65 var to = req.params.to;66 var names = users.map(function(user){ return user.name; });67 res.send('users ' + names.slice(from, to + 1).join(', '));68});6970/* istanbul ignore next */71if (!module.parent) {72 app.listen(3000);73 console.log('Express started on port 3000');74}
Code quality findings 8
Use let or const to avoid scope issues and hoisting
var express = require('../../');
Use let or const to avoid scope issues and hoisting
var app = module.exports = express();
Use let or const to avoid scope issues and hoisting
var users = [
Use let or const to avoid scope issues and hoisting
var from = req.params.from;
Use let or const to avoid scope issues and hoisting
var to = req.params.to;
Use let or const to avoid scope issues and hoisting
var names = users.map(function(user){ return user.name; });
Remove debugging statements or use a logging library
console.log('Express started on port 3000');