compiler/rustc_borrowck/src/nll.rs RUST 362 lines View on github.com → Search inside
1//! The entry point of the NLL borrow checker.23use std::io;4use std::path::PathBuf;5use std::rc::Rc;6use std::str::FromStr;78use polonius_engine::{Algorithm, AllFacts, Output};9use rustc_data_structures::frozen::Frozen;10use rustc_hir::find_attr;11use rustc_index::IndexSlice;12use rustc_middle::mir::pretty::PrettyPrintMirOptions;13use rustc_middle::mir::{Body, MirDumper, PassWhere, Promoted};14use rustc_middle::ty::print::with_no_trimmed_paths;15use rustc_middle::ty::{self, TyCtxt};16use rustc_mir_dataflow::move_paths::MoveData;17use rustc_mir_dataflow::points::DenseLocationMap;18use rustc_session::config::MirIncludeSpans;19use tracing::{debug, instrument};2021use crate::borrow_set::BorrowSet;22use crate::consumers::RustcFacts;23use crate::diagnostics::RegionErrors;24use crate::handle_placeholders::compute_sccs_applying_placeholder_outlives_constraints;25use crate::polonius::PoloniusContext;26use crate::polonius::legacy::{27    PoloniusFacts, PoloniusFactsExt, PoloniusLocationTable, PoloniusOutput,28};29use crate::region_infer::RegionInferenceContext;30use crate::type_check::MirTypeckRegionConstraints;31use crate::type_check::free_region_relations::UniversalRegionRelations;32use crate::universal_regions::UniversalRegions;33use crate::{34    BorrowCheckRootCtxt, BorrowckInferCtxt, ClosureOutlivesSubject, ClosureRegionRequirements,35    polonius, renumber,36};3738/// The output of `nll::compute_regions`. This includes the computed `RegionInferenceContext`, any39/// closure requirements to propagate, and any generated errors.40pub(crate) struct NllOutput<'tcx> {41    pub regioncx: RegionInferenceContext<'tcx>,42    pub polonius_input: Option<Box<PoloniusFacts>>,43    pub polonius_output: Option<Box<PoloniusOutput>>,44    pub opt_closure_req: Option<ClosureRegionRequirements<'tcx>>,45    pub nll_errors: RegionErrors<'tcx>,4647    /// When using `-Zpolonius=next`: the data used to compute errors and diagnostics, e.g.48    /// localized typeck and liveness constraints.49    pub polonius_context: Option<PoloniusContext>,50}5152/// Rewrites the regions in the MIR to use NLL variables, also scraping out the set of universal53/// regions (e.g., region parameters) declared on the function. That set will need to be given to54/// `compute_regions`.55#[instrument(skip(infcx, body, promoted), level = "debug")]56pub(crate) fn replace_regions_in_mir<'tcx>(57    infcx: &BorrowckInferCtxt<'tcx>,58    body: &mut Body<'tcx>,59    promoted: &mut IndexSlice<Promoted, Body<'tcx>>,60) -> UniversalRegions<'tcx> {61    let def = body.source.def_id().expect_local();6263    debug!(?def);6465    // Compute named region information. This also renumbers the inputs/outputs.66    let universal_regions = UniversalRegions::new(infcx, def);6768    // Replace all remaining regions with fresh inference variables.69    renumber::renumber_mir(infcx, body, promoted);7071    if let Some(dumper) = MirDumper::new(infcx.tcx, "renumber", body) {72        dumper.dump_mir(body);73    }7475    universal_regions76}7778/// Computes the closure requirements given the current inference state.79///80/// This is intended to be used by before [BorrowCheckRootCtxt::handle_opaque_type_uses]81/// because applying member constraints may rely on closure requirements.82/// This is frequently the case of async functions where pretty much everything83/// happens inside of the inner async block but the opaque only gets constrained84/// in the parent function.85pub(crate) fn compute_closure_requirements_modulo_opaques<'tcx>(86    infcx: &BorrowckInferCtxt<'tcx>,87    body: &Body<'tcx>,88    location_map: Rc<DenseLocationMap>,89    universal_region_relations: &Frozen<UniversalRegionRelations<'tcx>>,90    constraints: &MirTypeckRegionConstraints<'tcx>,91) -> Option<ClosureRegionRequirements<'tcx>> {92    // FIXME(#146079): we shouldn't have to clone all this stuff here.93    // Computing the region graph should take at least some of it by reference/`Rc`.94    let lowered_constraints = compute_sccs_applying_placeholder_outlives_constraints(95        constraints.clone(),96        &universal_region_relations,97        infcx,98    );99    let mut regioncx = RegionInferenceContext::new(100        &infcx,101        lowered_constraints,102        universal_region_relations.clone(),103        location_map,104    );105106    let (closure_region_requirements, _nll_errors) = regioncx.solve(infcx, body, None);107    closure_region_requirements108}109110/// Computes the (non-lexical) regions from the input MIR.111///112/// This may result in errors being reported.113pub(crate) fn compute_regions<'tcx>(114    root_cx: &mut BorrowCheckRootCtxt<'tcx>,115    infcx: &BorrowckInferCtxt<'tcx>,116    body: &Body<'tcx>,117    location_table: &PoloniusLocationTable,118    move_data: &MoveData<'tcx>,119    borrow_set: &BorrowSet<'tcx>,120    location_map: Rc<DenseLocationMap>,121    universal_region_relations: Frozen<UniversalRegionRelations<'tcx>>,122    constraints: MirTypeckRegionConstraints<'tcx>,123    mut polonius_facts: Option<AllFacts<RustcFacts>>,124    mut polonius_context: Option<PoloniusContext>,125) -> NllOutput<'tcx> {126    let polonius_output = root_cx.consumer.as_ref().map_or(false, |c| c.polonius_output())127        || infcx.tcx.sess.opts.unstable_opts.polonius.is_legacy_enabled();128129    let lowered_constraints = compute_sccs_applying_placeholder_outlives_constraints(130        constraints,131        &universal_region_relations,132        infcx,133    );134135    // If requested, emit legacy polonius facts.136    polonius::legacy::emit_facts(137        &mut polonius_facts,138        infcx.tcx,139        location_table,140        body,141        borrow_set,142        move_data,143        &universal_region_relations,144        &lowered_constraints,145    );146147    let mut regioncx = RegionInferenceContext::new(148        infcx,149        lowered_constraints,150        universal_region_relations,151        location_map,152    );153154    // If requested for `-Zpolonius=next`, convert NLL constraints to localized outlives constraints155    // and use them to compute loan liveness.156    if let Some(polonius_context) = polonius_context.as_mut() {157        polonius_context.compute_loan_liveness(&mut regioncx, body, borrow_set)158    }159160    // If requested: dump NLL facts, and run legacy polonius analysis.161    let polonius_output = polonius_facts.as_ref().and_then(|polonius_facts| {162        if infcx.tcx.sess.opts.unstable_opts.nll_facts {163            let def_id = body.source.def_id();164            let def_path = infcx.tcx.def_path(def_id);165            let dir_path = PathBuf::from(&infcx.tcx.sess.opts.unstable_opts.nll_facts_dir)166                .join(def_path.to_filename_friendly_no_crate());167            polonius_facts.write_to_dir(dir_path, location_table).unwrap();168        }169170        if polonius_output {171            let algorithm = infcx.tcx.env_var("POLONIUS_ALGORITHM").unwrap_or("Hybrid");172            let algorithm = Algorithm::from_str(algorithm).unwrap();173            debug!("compute_regions: using polonius algorithm {:?}", algorithm);174            let _prof_timer = infcx.tcx.prof.generic_activity("polonius_analysis");175            Some(Box::new(Output::compute(polonius_facts, algorithm, false)))176        } else {177            None178        }179    });180181    // Solve the region constraints.182    let (closure_region_requirements, nll_errors) =183        regioncx.solve(infcx, body, polonius_output.clone());184185    NllOutput {186        regioncx,187        polonius_input: polonius_facts.map(Box::new),188        polonius_output,189        opt_closure_req: closure_region_requirements,190        nll_errors,191        polonius_context,192    }193}194195/// `-Zdump-mir=nll` dumps MIR annotated with NLL specific information:196/// - free regions197/// - inferred region values198/// - region liveness199/// - inference constraints and their causes200///201/// As well as graphviz `.dot` visualizations of:202/// - the region constraints graph203/// - the region SCC graph204pub(super) fn dump_nll_mir<'tcx>(205    infcx: &BorrowckInferCtxt<'tcx>,206    body: &Body<'tcx>,207    regioncx: &RegionInferenceContext<'tcx>,208    closure_region_requirements: &Option<ClosureRegionRequirements<'tcx>>,209    borrow_set: &BorrowSet<'tcx>,210) {211    let tcx = infcx.tcx;212    let Some(dumper) = MirDumper::new(tcx, "nll", body) else { return };213214    // We want the NLL extra comments printed by default in NLL MIR dumps (they were removed in215    // #112346). Specifying `-Z mir-include-spans` on the CLI still has priority: for example,216    // they're always disabled in mir-opt tests to make working with blessed dumps easier.217    let options = PrettyPrintMirOptions {218        include_extra_comments: matches!(219            infcx.tcx.sess.opts.unstable_opts.mir_include_spans,220            MirIncludeSpans::On | MirIncludeSpans::Nll221        ),222    };223224    let extra_data = &|pass_where, out: &mut dyn std::io::Write| {225        emit_nll_mir(tcx, regioncx, closure_region_requirements, borrow_set, pass_where, out)226    };227228    let dumper = dumper.set_extra_data(extra_data).set_options(options);229230    dumper.dump_mir(body);231232    // Also dump the region constraint graph as a graphviz file.233    let _ = try {234        let mut file = dumper.create_dump_file("regioncx.all.dot", body)?;235        regioncx.dump_graphviz_raw_constraints(tcx, &mut file)?;236    };237238    // Also dump the region constraint SCC graph as a graphviz file.239    let _ = try {240        let mut file = dumper.create_dump_file("regioncx.scc.dot", body)?;241        regioncx.dump_graphviz_scc_constraints(tcx, &mut file)?;242    };243}244245/// Produces the actual NLL MIR sections to emit during the dumping process.246pub(crate) fn emit_nll_mir<'tcx>(247    tcx: TyCtxt<'tcx>,248    regioncx: &RegionInferenceContext<'tcx>,249    closure_region_requirements: &Option<ClosureRegionRequirements<'tcx>>,250    borrow_set: &BorrowSet<'tcx>,251    pass_where: PassWhere,252    out: &mut dyn io::Write,253) -> io::Result<()> {254    match pass_where {255        // Before the CFG, dump out the values for each region variable.256        PassWhere::BeforeCFG => {257            regioncx.dump_mir(tcx, out)?;258            writeln!(out, "|")?;259260            if let Some(closure_region_requirements) = closure_region_requirements {261                writeln!(out, "| Free Region Constraints")?;262                for_each_region_constraint(tcx, closure_region_requirements, &mut |msg| {263                    writeln!(out, "| {msg}")264                })?;265                writeln!(out, "|")?;266            }267268            if borrow_set.len() > 0 {269                writeln!(out, "| Borrows")?;270                for (borrow_idx, borrow_data) in borrow_set.iter_enumerated() {271                    writeln!(272                        out,273                        "| {:?}: issued at {:?} in {:?}",274                        borrow_idx, borrow_data.reserve_location, borrow_data.region275                    )?;276                }277                writeln!(out, "|")?;278            }279        }280281        PassWhere::BeforeLocation(_) => {}282283        PassWhere::AfterTerminator(_) => {}284285        PassWhere::BeforeBlock(_) | PassWhere::AfterLocation(_) | PassWhere::AfterCFG => {}286    }287    Ok(())288}289290pub(super) fn dump_annotation<'tcx, 'infcx>(291    infcx: &'infcx BorrowckInferCtxt<'tcx>,292    body: &Body<'tcx>,293    regioncx: &RegionInferenceContext<'tcx>,294    closure_region_requirements: &Option<ClosureRegionRequirements<'tcx>>,295) {296    let tcx = infcx.tcx;297    let base_def_id = tcx.typeck_root_def_id(body.source.def_id());298    if !find_attr!(tcx, base_def_id, RustcRegions) {299        return;300    }301302    // When the enclosing function is tagged with `#[rustc_regions]`,303    // we dump out various bits of state as warnings. This is useful304    // for verifying that the compiler is behaving as expected. These305    // warnings focus on the closure region requirements -- for306    // viewing the intraprocedural state, the -Zdump-mir output is307    // better.308309    let def_span = tcx.def_span(body.source.def_id());310    let err = if let Some(closure_region_requirements) = closure_region_requirements {311        let mut err = infcx.dcx().struct_span_note(def_span, "external requirements");312313        regioncx.annotate(tcx, &mut err);314315        err.note(format!(316            "number of external vids: {}",317            closure_region_requirements.num_external_vids318        ));319320        // Dump the region constraints we are imposing *between* those321        // newly created variables.322        for_each_region_constraint(tcx, closure_region_requirements, &mut |msg| {323            err.note(msg);324            Ok(())325        })326        .unwrap();327328        err329    } else {330        let mut err = infcx.dcx().struct_span_note(def_span, "no external requirements");331        regioncx.annotate(tcx, &mut err);332        err333    };334335    // FIXME(@lcnr): We currently don't dump the inferred hidden types here.336    err.emit();337}338339fn for_each_region_constraint<'tcx>(340    tcx: TyCtxt<'tcx>,341    closure_region_requirements: &ClosureRegionRequirements<'tcx>,342    with_msg: &mut dyn FnMut(String) -> io::Result<()>,343) -> io::Result<()> {344    for req in &closure_region_requirements.outlives_requirements {345        let subject = match req.subject {346            ClosureOutlivesSubject::Region(subject) => format!("{subject:?}"),347            ClosureOutlivesSubject::Ty(ty) => {348                with_no_trimmed_paths!(format!(349                    "{}",350                    ty.instantiate(tcx, |vid| ty::Region::new_var(tcx, vid))351                ))352            }353        };354        with_msg(format!("where {}: {:?}", subject, req.outlived_free_region,))?;355    }356    Ok(())357}358359pub(crate) trait ConstraintDescription {360    fn description(&self) -> &'static str;361}

Code quality findings 4

Warning: Direct indexing (e.g., `vec[i]`, `slice[i]`) panics on out-of-bounds access. Prefer using `.get(index)` or `.get_mut(index)` which return Option<&T>/Option<&mut T>.
warning correctness unchecked-indexing
/// This is intended to be used by before [BorrowCheckRootCtxt::handle_opaque_type_uses]
Warning: '.unwrap()' will panic on None/Err variants. Prefer using pattern matching (match, if let), combinators (map, and_then), or the '?' operator for robust error handling.
warning correctness unwrap-usage
polonius_facts.write_to_dir(dir_path, location_table).unwrap();
Warning: '.unwrap()' will panic on None/Err variants. Prefer using pattern matching (match, if let), combinators (map, and_then), or the '?' operator for robust error handling.
warning correctness unwrap-usage
let algorithm = Algorithm::from_str(algorithm).unwrap();
Warning: '.unwrap()' will panic on None/Err variants. Prefer using pattern matching (match, if let), combinators (map, and_then), or the '?' operator for robust error handling.
warning correctness unwrap-usage
.unwrap();

Get this view in your editor

Same data, no extra tab — call code_get_file + code_get_findings over MCP from Claude/Cursor/Copilot.