PageRenderTime 199ms CodeModel.GetById 34ms RepoModel.GetById 1ms app.codeStats 1ms

/vendor/rails/actionpack/test/controller/routing_test.rb

https://github.com/shuoling/i18n_demo_app
Ruby | 2407 lines | 1955 code | 427 blank | 25 comment | 9 complexity | 581f8075aac683dc8ba6ca0d8107fa5d MD5 | raw file
  1. require 'abstract_unit'
  2. require 'controller/fake_controllers'
  3. require 'action_controller/routing'
  4. class MilestonesController < ActionController::Base
  5. def index() head :ok end
  6. alias_method :show, :index
  7. def rescue_action(e) raise e end
  8. end
  9. RunTimeTests = ARGV.include? 'time'
  10. ROUTING = ActionController::Routing
  11. class ROUTING::RouteBuilder
  12. attr_reader :warn_output
  13. def warn(msg)
  14. (@warn_output ||= []) << msg
  15. end
  16. end
  17. # See RFC 3986, section 3.3 for allowed path characters.
  18. class UriReservedCharactersRoutingTest < Test::Unit::TestCase
  19. def setup
  20. ActionController::Routing.use_controllers! ['controller']
  21. @set = ActionController::Routing::RouteSet.new
  22. @set.draw do |map|
  23. map.connect ':controller/:action/:variable/*additional'
  24. end
  25. safe, unsafe = %w(: @ & = + $ , ;), %w(^ / ? # [ ])
  26. hex = unsafe.map { |char| '%' + char.unpack('H2').first.upcase }
  27. @segment = "#{safe.join}#{unsafe.join}".freeze
  28. @escaped = "#{safe.join}#{hex.join}".freeze
  29. end
  30. def test_route_generation_escapes_unsafe_path_characters
  31. assert_equal "/contr#{@segment}oller/act#{@escaped}ion/var#{@escaped}iable/add#{@escaped}itional-1/add#{@escaped}itional-2",
  32. @set.generate(:controller => "contr#{@segment}oller",
  33. :action => "act#{@segment}ion",
  34. :variable => "var#{@segment}iable",
  35. :additional => ["add#{@segment}itional-1", "add#{@segment}itional-2"])
  36. end
  37. def test_route_recognition_unescapes_path_components
  38. options = { :controller => "controller",
  39. :action => "act#{@segment}ion",
  40. :variable => "var#{@segment}iable",
  41. :additional => ["add#{@segment}itional-1", "add#{@segment}itional-2"] }
  42. assert_equal options, @set.recognize_path("/controller/act#{@escaped}ion/var#{@escaped}iable/add#{@escaped}itional-1/add#{@escaped}itional-2")
  43. end
  44. def test_route_generation_allows_passing_non_string_values_to_generated_helper
  45. assert_equal "/controller/action/variable/1/2", @set.generate(:controller => "controller",
  46. :action => "action",
  47. :variable => "variable",
  48. :additional => [1, 2])
  49. end
  50. end
  51. class SegmentTest < Test::Unit::TestCase
  52. def test_first_segment_should_interpolate_for_structure
  53. s = ROUTING::Segment.new
  54. def s.interpolation_statement(array) 'hello' end
  55. assert_equal 'hello', s.continue_string_structure([])
  56. end
  57. def test_interpolation_statement
  58. s = ROUTING::StaticSegment.new("Hello")
  59. assert_equal "Hello", eval(s.interpolation_statement([]))
  60. assert_equal "HelloHello", eval(s.interpolation_statement([s]))
  61. s2 = ROUTING::StaticSegment.new("-")
  62. assert_equal "Hello-Hello", eval(s.interpolation_statement([s, s2]))
  63. s3 = ROUTING::StaticSegment.new("World")
  64. assert_equal "Hello-World", eval(s3.interpolation_statement([s, s2]))
  65. end
  66. end
  67. class StaticSegmentTest < Test::Unit::TestCase
  68. def test_interpolation_chunk_should_respect_raw
  69. s = ROUTING::StaticSegment.new('Hello World')
  70. assert !s.raw?
  71. assert_equal 'Hello%20World', s.interpolation_chunk
  72. s = ROUTING::StaticSegment.new('Hello World', :raw => true)
  73. assert s.raw?
  74. assert_equal 'Hello World', s.interpolation_chunk
  75. end
  76. def test_regexp_chunk_should_escape_specials
  77. s = ROUTING::StaticSegment.new('Hello*World')
  78. assert_equal 'Hello\*World', s.regexp_chunk
  79. s = ROUTING::StaticSegment.new('HelloWorld')
  80. assert_equal 'HelloWorld', s.regexp_chunk
  81. end
  82. def test_regexp_chunk_should_add_question_mark_for_optionals
  83. s = ROUTING::StaticSegment.new("/", :optional => true)
  84. assert_equal "/?", s.regexp_chunk
  85. s = ROUTING::StaticSegment.new("hello", :optional => true)
  86. assert_equal "(?:hello)?", s.regexp_chunk
  87. end
  88. end
  89. class DynamicSegmentTest < Test::Unit::TestCase
  90. def segment(options = {})
  91. unless @segment
  92. @segment = ROUTING::DynamicSegment.new(:a, options)
  93. end
  94. @segment
  95. end
  96. def test_extract_value
  97. s = ROUTING::DynamicSegment.new(:a)
  98. hash = {:a => '10', :b => '20'}
  99. assert_equal '10', eval(s.extract_value)
  100. hash = {:b => '20'}
  101. assert_equal nil, eval(s.extract_value)
  102. s.default = '20'
  103. assert_equal '20', eval(s.extract_value)
  104. end
  105. def test_default_local_name
  106. assert_equal 'a_value', segment.local_name,
  107. "Unexpected name -- all value_check tests will fail!"
  108. end
  109. def test_presence_value_check
  110. a_value = 10
  111. assert eval(segment.value_check)
  112. end
  113. def test_regexp_value_check_rejects_nil
  114. segment = segment(:regexp => /\d+/)
  115. a_value = nil
  116. assert !eval(segment.value_check)
  117. end
  118. def test_optional_regexp_value_check_should_accept_nil
  119. segment = segment(:regexp => /\d+/, :optional => true)
  120. a_value = nil
  121. assert eval(segment.value_check)
  122. end
  123. def test_regexp_value_check_rejects_no_match
  124. segment = segment(:regexp => /\d+/)
  125. a_value = "Hello20World"
  126. assert !eval(segment.value_check)
  127. a_value = "20Hi"
  128. assert !eval(segment.value_check)
  129. end
  130. def test_regexp_value_check_accepts_match
  131. segment = segment(:regexp => /\d+/)
  132. a_value = "30"
  133. assert eval(segment.value_check)
  134. end
  135. def test_value_check_fails_on_nil
  136. a_value = nil
  137. assert ! eval(segment.value_check)
  138. end
  139. def test_optional_value_needs_no_check
  140. segment = segment(:optional => true)
  141. a_value = nil
  142. assert_equal nil, segment.value_check
  143. end
  144. def test_regexp_value_check_should_accept_match_with_default
  145. segment = segment(:regexp => /\d+/, :default => '200')
  146. a_value = '100'
  147. assert eval(segment.value_check)
  148. end
  149. def test_expiry_should_not_trigger_once_expired
  150. expired = true
  151. hash = merged = {:a => 2, :b => 3}
  152. options = {:b => 3}
  153. expire_on = Hash.new { raise 'No!!!' }
  154. eval(segment.expiry_statement)
  155. rescue RuntimeError
  156. flunk "Expiry check should not have occurred!"
  157. end
  158. def test_expiry_should_occur_according_to_expire_on
  159. expired = false
  160. hash = merged = {:a => 2, :b => 3}
  161. options = {:b => 3}
  162. expire_on = {:b => true, :a => false}
  163. eval(segment.expiry_statement)
  164. assert !expired
  165. assert_equal({:a => 2, :b => 3}, hash)
  166. expire_on = {:b => true, :a => true}
  167. eval(segment.expiry_statement)
  168. assert expired
  169. assert_equal({:b => 3}, hash)
  170. end
  171. def test_extraction_code_should_return_on_nil
  172. hash = merged = {:b => 3}
  173. options = {:b => 3}
  174. a_value = nil
  175. # Local jump because of return inside eval.
  176. assert_raises(LocalJumpError) { eval(segment.extraction_code) }
  177. end
  178. def test_extraction_code_should_return_on_mismatch
  179. segment = segment(:regexp => /\d+/)
  180. hash = merged = {:a => 'Hi', :b => '3'}
  181. options = {:b => '3'}
  182. a_value = nil
  183. # Local jump because of return inside eval.
  184. assert_raises(LocalJumpError) { eval(segment.extraction_code) }
  185. end
  186. def test_extraction_code_should_accept_value_and_set_local
  187. hash = merged = {:a => 'Hi', :b => '3'}
  188. options = {:b => '3'}
  189. a_value = nil
  190. expired = true
  191. eval(segment.extraction_code)
  192. assert_equal 'Hi', a_value
  193. end
  194. def test_extraction_should_work_without_value_check
  195. segment.default = 'hi'
  196. hash = merged = {:b => '3'}
  197. options = {:b => '3'}
  198. a_value = nil
  199. expired = true
  200. eval(segment.extraction_code)
  201. assert_equal 'hi', a_value
  202. end
  203. def test_extraction_code_should_perform_expiry
  204. expired = false
  205. hash = merged = {:a => 'Hi', :b => '3'}
  206. options = {:b => '3'}
  207. expire_on = {:a => true}
  208. a_value = nil
  209. eval(segment.extraction_code)
  210. assert_equal 'Hi', a_value
  211. assert expired
  212. assert_equal options, hash
  213. end
  214. def test_interpolation_chunk_should_replace_value
  215. a_value = 'Hi'
  216. assert_equal a_value, eval(%("#{segment.interpolation_chunk}"))
  217. end
  218. def test_interpolation_chunk_should_accept_nil
  219. a_value = nil
  220. assert_equal '', eval(%("#{segment.interpolation_chunk('a_value')}"))
  221. end
  222. def test_value_regexp_should_be_nil_without_regexp
  223. assert_equal nil, segment.value_regexp
  224. end
  225. def test_value_regexp_should_match_exacly
  226. segment = segment(:regexp => /\d+/)
  227. assert_no_match segment.value_regexp, "Hello 10 World"
  228. assert_no_match segment.value_regexp, "Hello 10"
  229. assert_no_match segment.value_regexp, "10 World"
  230. assert_match segment.value_regexp, "10"
  231. end
  232. def test_regexp_chunk_should_return_string
  233. segment = segment(:regexp => /\d+/)
  234. assert_kind_of String, segment.regexp_chunk
  235. end
  236. def test_build_pattern_non_optional_with_no_captures
  237. # Non optional
  238. a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /\d+/)
  239. assert_equal "(\\d+)stuff", a_segment.build_pattern('stuff')
  240. end
  241. def test_build_pattern_non_optional_with_captures
  242. # Non optional
  243. a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /(\d+)(.*?)/)
  244. assert_equal "((\\d+)(.*?))stuff", a_segment.build_pattern('stuff')
  245. end
  246. def test_optionality_implied
  247. a_segment = ROUTING::DynamicSegment.new(:id)
  248. assert a_segment.optionality_implied?
  249. a_segment = ROUTING::DynamicSegment.new(:action)
  250. assert a_segment.optionality_implied?
  251. end
  252. def test_modifiers_must_be_handled_sensibly
  253. a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /david|jamis/i)
  254. assert_equal "((?i-mx:david|jamis))stuff", a_segment.build_pattern('stuff')
  255. a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /david|jamis/x)
  256. assert_equal "((?x-mi:david|jamis))stuff", a_segment.build_pattern('stuff')
  257. a_segment = ROUTING::DynamicSegment.new(nil, :regexp => /david|jamis/)
  258. assert_equal "(david|jamis)stuff", a_segment.build_pattern('stuff')
  259. end
  260. end
  261. class ControllerSegmentTest < Test::Unit::TestCase
  262. def test_regexp_should_only_match_possible_controllers
  263. ActionController::Routing.with_controllers %w(admin/accounts admin/users account pages) do
  264. cs = ROUTING::ControllerSegment.new :controller
  265. regexp = %r{\A#{cs.regexp_chunk}\Z}
  266. ActionController::Routing.possible_controllers.each do |name|
  267. assert_match regexp, name
  268. assert_no_match regexp, "#{name}_fake"
  269. match = regexp.match name
  270. assert_equal name, match[1]
  271. end
  272. end
  273. end
  274. end
  275. class RouteBuilderTest < Test::Unit::TestCase
  276. def builder
  277. @builder ||= ROUTING::RouteBuilder.new
  278. end
  279. def build(path, options)
  280. builder.build(path, options)
  281. end
  282. def test_options_should_not_be_modified
  283. requirements1 = { :id => /\w+/, :controller => /(?:[a-z](?:-?[a-z]+)*)/ }
  284. requirements2 = requirements1.dup
  285. assert_equal requirements1, requirements2
  286. with_options(:controller => 'folder',
  287. :requirements => requirements2) do |m|
  288. m.build 'folders/new', :action => 'new'
  289. end
  290. assert_equal requirements1, requirements2
  291. end
  292. def test_segment_for_static
  293. segment, rest = builder.segment_for 'ulysses'
  294. assert_equal '', rest
  295. assert_kind_of ROUTING::StaticSegment, segment
  296. assert_equal 'ulysses', segment.value
  297. end
  298. def test_segment_for_action
  299. segment, rest = builder.segment_for ':action'
  300. assert_equal '', rest
  301. assert_kind_of ROUTING::DynamicSegment, segment
  302. assert_equal :action, segment.key
  303. assert_equal 'index', segment.default
  304. end
  305. def test_segment_for_dynamic
  306. segment, rest = builder.segment_for ':login'
  307. assert_equal '', rest
  308. assert_kind_of ROUTING::DynamicSegment, segment
  309. assert_equal :login, segment.key
  310. assert_equal nil, segment.default
  311. assert ! segment.optional?
  312. end
  313. def test_segment_for_with_rest
  314. segment, rest = builder.segment_for ':login/:action'
  315. assert_equal :login, segment.key
  316. assert_equal '/:action', rest
  317. segment, rest = builder.segment_for rest
  318. assert_equal '/', segment.value
  319. assert_equal ':action', rest
  320. segment, rest = builder.segment_for rest
  321. assert_equal :action, segment.key
  322. assert_equal '', rest
  323. end
  324. def test_segments_for
  325. segments = builder.segments_for_route_path '/:controller/:action/:id'
  326. assert_kind_of ROUTING::DividerSegment, segments[0]
  327. assert_equal '/', segments[2].value
  328. assert_kind_of ROUTING::DynamicSegment, segments[1]
  329. assert_equal :controller, segments[1].key
  330. assert_kind_of ROUTING::DividerSegment, segments[2]
  331. assert_equal '/', segments[2].value
  332. assert_kind_of ROUTING::DynamicSegment, segments[3]
  333. assert_equal :action, segments[3].key
  334. assert_kind_of ROUTING::DividerSegment, segments[4]
  335. assert_equal '/', segments[4].value
  336. assert_kind_of ROUTING::DynamicSegment, segments[5]
  337. assert_equal :id, segments[5].key
  338. end
  339. def test_segment_for_action
  340. s, r = builder.segment_for(':action/something/else')
  341. assert_equal '/something/else', r
  342. assert_equal :action, s.key
  343. end
  344. def test_action_default_should_not_trigger_on_prefix
  345. s, r = builder.segment_for ':action_name/something/else'
  346. assert_equal '/something/else', r
  347. assert_equal :action_name, s.key
  348. assert_equal nil, s.default
  349. end
  350. def test_divide_route_options
  351. segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
  352. defaults, requirements = builder.divide_route_options(segments,
  353. :action => 'buy', :person => /\w+/, :car => /\w+/,
  354. :defaults => {:person => nil, :car => nil}
  355. )
  356. assert_equal({:action => 'buy', :person => nil, :car => nil}, defaults)
  357. assert_equal({:person => /\w+/, :car => /\w+/}, requirements)
  358. end
  359. def test_assign_route_options
  360. segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
  361. defaults = {:action => 'buy', :person => nil, :car => nil}
  362. requirements = {:person => /\w+/, :car => /\w+/}
  363. route_requirements = builder.assign_route_options(segments, defaults, requirements)
  364. assert_equal({}, route_requirements)
  365. assert_equal :action, segments[3].key
  366. assert_equal 'buy', segments[3].default
  367. assert_equal :person, segments[5].key
  368. assert_equal %r/\w+/, segments[5].regexp
  369. assert segments[5].optional?
  370. assert_equal :car, segments[7].key
  371. assert_equal %r/\w+/, segments[7].regexp
  372. assert segments[7].optional?
  373. end
  374. def test_assign_route_options_with_anchor_chars
  375. segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
  376. defaults = {:action => 'buy', :person => nil, :car => nil}
  377. requirements = {:person => /\w+/, :car => /^\w+$/}
  378. assert_raises ArgumentError do
  379. route_requirements = builder.assign_route_options(segments, defaults, requirements)
  380. end
  381. requirements[:car] = /[^\/]+/
  382. route_requirements = builder.assign_route_options(segments, defaults, requirements)
  383. end
  384. def test_optional_segments_preceding_required_segments
  385. segments = builder.segments_for_route_path '/cars/:action/:person/:car/'
  386. defaults = {:action => 'buy', :person => nil, :car => "model-t"}
  387. assert builder.assign_route_options(segments, defaults, {}).empty?
  388. 0.upto(1) { |i| assert !segments[i].optional?, "segment #{i} is optional and it shouldn't be" }
  389. assert segments[2].optional?
  390. assert_equal nil, builder.warn_output # should only warn on the :person segment
  391. end
  392. def test_segmentation_of_dot_path
  393. segments = builder.segments_for_route_path '/books/:action.rss'
  394. assert builder.assign_route_options(segments, {}, {}).empty?
  395. assert_equal 6, segments.length # "/", "books", "/", ":action", ".", "rss"
  396. assert !segments.any? { |seg| seg.optional? }
  397. end
  398. def test_segmentation_of_dynamic_dot_path
  399. segments = builder.segments_for_route_path '/books/:action.:format'
  400. assert builder.assign_route_options(segments, {}, {}).empty?
  401. assert_equal 6, segments.length # "/", "books", "/", ":action", ".", ":format"
  402. assert !segments.any? { |seg| seg.optional? }
  403. assert_kind_of ROUTING::DynamicSegment, segments.last
  404. end
  405. def test_assignment_of_default_options
  406. segments = builder.segments_for_route_path '/:controller/:action/:id/'
  407. action, id = segments[-4], segments[-2]
  408. assert_equal :action, action.key
  409. assert_equal :id, id.key
  410. assert ! action.optional?
  411. assert ! id.optional?
  412. builder.assign_default_route_options(segments)
  413. assert_equal 'index', action.default
  414. assert action.optional?
  415. assert id.optional?
  416. end
  417. def test_assignment_of_default_options_respects_existing_defaults
  418. segments = builder.segments_for_route_path '/:controller/:action/:id/'
  419. action, id = segments[-4], segments[-2]
  420. assert_equal :action, action.key
  421. assert_equal :id, id.key
  422. action.default = 'show'
  423. action.is_optional = true
  424. id.default = 'Welcome'
  425. id.is_optional = true
  426. builder.assign_default_route_options(segments)
  427. assert_equal 'show', action.default
  428. assert action.optional?
  429. assert_equal 'Welcome', id.default
  430. assert id.optional?
  431. end
  432. def test_assignment_of_default_options_respects_regexps
  433. segments = builder.segments_for_route_path '/:controller/:action/:id/'
  434. action = segments[-4]
  435. assert_equal :action, action.key
  436. segments[-4] = ROUTING::DynamicSegment.new(:action, :regexp => /show|in/)
  437. builder.assign_default_route_options(segments)
  438. assert_equal nil, action.default
  439. assert ! action.optional?
  440. end
  441. def test_assignment_of_is_optional_when_default
  442. segments = builder.segments_for_route_path '/books/:action.rss'
  443. assert_equal segments[3].key, :action
  444. segments[3].default = 'changes'
  445. builder.ensure_required_segments(segments)
  446. assert ! segments[3].optional?
  447. end
  448. def test_is_optional_is_assigned_to_default_segments
  449. segments = builder.segments_for_route_path '/books/:action'
  450. builder.assign_route_options(segments, {:action => 'index'}, {})
  451. assert_equal segments[3].key, :action
  452. assert segments[3].optional?
  453. assert_kind_of ROUTING::DividerSegment, segments[2]
  454. assert segments[2].optional?
  455. end
  456. # XXX is optional not being set right?
  457. # /blah/:defaulted_segment <-- is the second slash optional? it should be.
  458. def test_route_build
  459. ActionController::Routing.with_controllers %w(users pages) do
  460. r = builder.build '/:controller/:action/:id/', :action => nil
  461. [0, 2, 4].each do |i|
  462. assert_kind_of ROUTING::DividerSegment, r.segments[i]
  463. assert_equal '/', r.segments[i].value
  464. assert r.segments[i].optional? if i > 1
  465. end
  466. assert_kind_of ROUTING::DynamicSegment, r.segments[1]
  467. assert_equal :controller, r.segments[1].key
  468. assert_equal nil, r.segments[1].default
  469. assert_kind_of ROUTING::DynamicSegment, r.segments[3]
  470. assert_equal :action, r.segments[3].key
  471. assert_equal 'index', r.segments[3].default
  472. assert_kind_of ROUTING::DynamicSegment, r.segments[5]
  473. assert_equal :id, r.segments[5].key
  474. assert r.segments[5].optional?
  475. end
  476. end
  477. def test_slashes_are_implied
  478. routes = [
  479. builder.build('/:controller/:action/:id/', :action => nil),
  480. builder.build('/:controller/:action/:id', :action => nil),
  481. builder.build(':controller/:action/:id', :action => nil),
  482. builder.build('/:controller/:action/:id/', :action => nil)
  483. ]
  484. expected = routes.first.segments.length
  485. routes.each_with_index do |route, i|
  486. found = route.segments.length
  487. assert_equal expected, found, "Route #{i + 1} has #{found} segments, expected #{expected}"
  488. end
  489. end
  490. end
  491. class RoutingTest < Test::Unit::TestCase
  492. def test_possible_controllers
  493. true_controller_paths = ActionController::Routing.controller_paths
  494. ActionController::Routing.use_controllers! nil
  495. silence_warnings do
  496. Object.send(:const_set, :RAILS_ROOT, File.dirname(__FILE__) + '/controller_fixtures')
  497. end
  498. ActionController::Routing.controller_paths = [
  499. RAILS_ROOT, RAILS_ROOT + '/app/controllers', RAILS_ROOT + '/vendor/plugins/bad_plugin/lib'
  500. ]
  501. assert_equal ["admin/user", "plugin", "user"], ActionController::Routing.possible_controllers.sort
  502. ensure
  503. if true_controller_paths
  504. ActionController::Routing.controller_paths = true_controller_paths
  505. end
  506. ActionController::Routing.use_controllers! nil
  507. Object.send(:remove_const, :RAILS_ROOT) rescue nil
  508. end
  509. def test_possible_controllers_are_reset_on_each_load
  510. true_possible_controllers = ActionController::Routing.possible_controllers
  511. true_controller_paths = ActionController::Routing.controller_paths
  512. ActionController::Routing.use_controllers! nil
  513. root = File.dirname(__FILE__) + '/controller_fixtures'
  514. ActionController::Routing.controller_paths = []
  515. assert_equal [], ActionController::Routing.possible_controllers
  516. ActionController::Routing.controller_paths = [
  517. root, root + '/app/controllers', root + '/vendor/plugins/bad_plugin/lib'
  518. ]
  519. ActionController::Routing::Routes.load!
  520. assert_equal ["admin/user", "plugin", "user"], ActionController::Routing.possible_controllers.sort
  521. ensure
  522. ActionController::Routing.controller_paths = true_controller_paths
  523. ActionController::Routing.use_controllers! true_possible_controllers
  524. Object.send(:remove_const, :RAILS_ROOT) rescue nil
  525. ActionController::Routing::Routes.clear!
  526. ActionController::Routing::Routes.load_routes!
  527. end
  528. def test_with_controllers
  529. c = %w(admin/accounts admin/users account pages)
  530. ActionController::Routing.with_controllers c do
  531. assert_equal c, ActionController::Routing.possible_controllers
  532. end
  533. end
  534. def test_normalize_unix_paths
  535. load_paths = %w(. config/../app/controllers config/../app//helpers script/../config/../vendor/rails/actionpack/lib vendor/rails/railties/builtin/rails_info app/models lib script/../config/../foo/bar/../../app/models .foo/../.bar foo.bar/../config)
  536. paths = ActionController::Routing.normalize_paths(load_paths)
  537. assert_equal %w(vendor/rails/railties/builtin/rails_info vendor/rails/actionpack/lib app/controllers app/helpers app/models config .bar lib .), paths
  538. end
  539. def test_normalize_windows_paths
  540. load_paths = %w(. config\\..\\app\\controllers config\\..\\app\\\\helpers script\\..\\config\\..\\vendor\\rails\\actionpack\\lib vendor\\rails\\railties\\builtin\\rails_info app\\models lib script\\..\\config\\..\\foo\\bar\\..\\..\\app\\models .foo\\..\\.bar foo.bar\\..\\config)
  541. paths = ActionController::Routing.normalize_paths(load_paths)
  542. assert_equal %w(vendor\\rails\\railties\\builtin\\rails_info vendor\\rails\\actionpack\\lib app\\controllers app\\helpers app\\models config .bar lib .), paths
  543. end
  544. def test_routing_helper_module
  545. assert_kind_of Module, ActionController::Routing::Helpers
  546. h = ActionController::Routing::Helpers
  547. c = Class.new
  548. assert ! c.ancestors.include?(h)
  549. ActionController::Routing::Routes.install_helpers c
  550. assert c.ancestors.include?(h)
  551. end
  552. end
  553. uses_mocha 'LegacyRouteSet, Route, RouteSet and RouteLoading' do
  554. class MockController
  555. attr_accessor :routes
  556. def initialize(routes)
  557. self.routes = routes
  558. end
  559. def url_for(options)
  560. only_path = options.delete(:only_path)
  561. port = options.delete(:port) || 80
  562. port_string = port == 80 ? '' : ":#{port}"
  563. host = options.delete(:host) || "named.route.test"
  564. anchor = "##{options.delete(:anchor)}" if options.key?(:anchor)
  565. path = routes.generate(options)
  566. only_path ? "#{path}#{anchor}" : "http://#{host}#{port_string}#{path}#{anchor}"
  567. end
  568. def request
  569. @request ||= MockRequest.new(:host => "named.route.test", :method => :get)
  570. end
  571. end
  572. class MockRequest
  573. attr_accessor :path, :path_parameters, :host, :subdomains, :domain, :method
  574. def initialize(values={})
  575. values.each { |key, value| send("#{key}=", value) }
  576. if values[:host]
  577. subdomain, self.domain = values[:host].split(/\./, 2)
  578. self.subdomains = [subdomain]
  579. end
  580. end
  581. def protocol
  582. "http://"
  583. end
  584. def host_with_port
  585. (subdomains * '.') + '.' + domain
  586. end
  587. end
  588. class LegacyRouteSetTests < Test::Unit::TestCase
  589. attr_reader :rs
  590. def setup
  591. # These tests assume optimisation is on, so re-enable it.
  592. ActionController::Base.optimise_named_routes = true
  593. @rs = ::ActionController::Routing::RouteSet.new
  594. @rs.draw {|m| m.connect ':controller/:action/:id' }
  595. ActionController::Routing.use_controllers! %w(content admin/user admin/news_feed)
  596. end
  597. def test_default_setup
  598. assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/content"))
  599. assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/content/list"))
  600. assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/content/show/10"))
  601. assert_equal({:controller => "admin/user", :action => 'show', :id => '10'}, rs.recognize_path("/admin/user/show/10"))
  602. assert_equal '/admin/user/show/10', rs.generate(:controller => 'admin/user', :action => 'show', :id => 10)
  603. assert_equal '/admin/user/show', rs.generate({:action => 'show'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
  604. assert_equal '/admin/user/list/10', rs.generate({}, {:controller => 'admin/user', :action => 'list', :id => '10'})
  605. assert_equal '/admin/stuff', rs.generate({:controller => 'stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
  606. assert_equal '/stuff', rs.generate({:controller => '/stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'})
  607. end
  608. def test_ignores_leading_slash
  609. @rs.draw {|m| m.connect '/:controller/:action/:id'}
  610. test_default_setup
  611. end
  612. def test_time_recognition
  613. # We create many routes to make situation more realistic
  614. @rs = ::ActionController::Routing::RouteSet.new
  615. @rs.draw { |map|
  616. map.frontpage '', :controller => 'search', :action => 'new'
  617. map.resources :videos do |video|
  618. video.resources :comments
  619. video.resource :file, :controller => 'video_file'
  620. video.resource :share, :controller => 'video_shares'
  621. video.resource :abuse, :controller => 'video_abuses'
  622. end
  623. map.resources :abuses, :controller => 'video_abuses'
  624. map.resources :video_uploads
  625. map.resources :video_visits
  626. map.resources :users do |user|
  627. user.resource :settings
  628. user.resources :videos
  629. end
  630. map.resources :channels do |channel|
  631. channel.resources :videos, :controller => 'channel_videos'
  632. end
  633. map.resource :session
  634. map.resource :lost_password
  635. map.search 'search', :controller => 'search'
  636. map.resources :pages
  637. map.connect ':controller/:action/:id'
  638. }
  639. n = 1000
  640. if RunTimeTests
  641. GC.start
  642. rectime = Benchmark.realtime do
  643. n.times do
  644. rs.recognize_path("/videos/1234567", {:method => :get})
  645. rs.recognize_path("/videos/1234567/abuse", {:method => :get})
  646. rs.recognize_path("/users/1234567/settings", {:method => :get})
  647. rs.recognize_path("/channels/1234567", {:method => :get})
  648. rs.recognize_path("/session/new", {:method => :get})
  649. rs.recognize_path("/admin/user/show/10", {:method => :get})
  650. end
  651. end
  652. puts "\n\nRecognition (#{rs.routes.size} routes):"
  653. per_url = rectime / (n * 6)
  654. puts "#{per_url * 1000} ms/url"
  655. puts "#{1 / per_url} url/s\n\n"
  656. end
  657. end
  658. def test_time_generation
  659. n = 5000
  660. if RunTimeTests
  661. GC.start
  662. pairs = [
  663. [{:controller => 'content', :action => 'index'}, {:controller => 'content', :action => 'show'}],
  664. [{:controller => 'content'}, {:controller => 'content', :action => 'index'}],
  665. [{:controller => 'content', :action => 'list'}, {:controller => 'content', :action => 'index'}],
  666. [{:controller => 'content', :action => 'show', :id => '10'}, {:controller => 'content', :action => 'list'}],
  667. [{:controller => 'admin/user', :action => 'index'}, {:controller => 'admin/user', :action => 'show'}],
  668. [{:controller => 'admin/user'}, {:controller => 'admin/user', :action => 'index'}],
  669. [{:controller => 'admin/user', :action => 'list'}, {:controller => 'admin/user', :action => 'index'}],
  670. [{:controller => 'admin/user', :action => 'show', :id => '10'}, {:controller => 'admin/user', :action => 'list'}],
  671. ]
  672. p = nil
  673. gentime = Benchmark.realtime do
  674. n.times do
  675. pairs.each {|(a, b)| rs.generate(a, b)}
  676. end
  677. end
  678. puts "\n\nGeneration (RouteSet): (#{(n * 8)} urls)"
  679. per_url = gentime / (n * 8)
  680. puts "#{per_url * 1000} ms/url"
  681. puts "#{1 / per_url} url/s\n\n"
  682. end
  683. end
  684. def test_route_with_colon_first
  685. rs.draw do |map|
  686. map.connect '/:controller/:action/:id', :action => 'index', :id => nil
  687. map.connect ':url', :controller => 'tiny_url', :action => 'translate'
  688. end
  689. end
  690. def test_route_with_regexp_for_controller
  691. rs.draw do |map|
  692. map.connect ':controller/:admintoken/:action/:id', :controller => /admin\/.+/
  693. map.connect ':controller/:action/:id'
  694. end
  695. assert_equal({:controller => "admin/user", :admintoken => "foo", :action => "index"},
  696. rs.recognize_path("/admin/user/foo"))
  697. assert_equal({:controller => "content", :action => "foo"}, rs.recognize_path("/content/foo"))
  698. assert_equal '/admin/user/foo', rs.generate(:controller => "admin/user", :admintoken => "foo", :action => "index")
  699. assert_equal '/content/foo', rs.generate(:controller => "content", :action => "foo")
  700. end
  701. def test_route_with_regexp_and_dot
  702. rs.draw do |map|
  703. map.connect ':controller/:action/:file',
  704. :controller => /admin|user/,
  705. :action => /upload|download/,
  706. :defaults => {:file => nil},
  707. :requirements => {:file => %r{[^/]+(\.[^/]+)?}}
  708. end
  709. # Without a file extension
  710. assert_equal '/user/download/file',
  711. rs.generate(:controller => "user", :action => "download", :file => "file")
  712. assert_equal(
  713. {:controller => "user", :action => "download", :file => "file"},
  714. rs.recognize_path("/user/download/file"))
  715. # Now, let's try a file with an extension, really a dot (.)
  716. assert_equal '/user/download/file.jpg',
  717. rs.generate(
  718. :controller => "user", :action => "download", :file => "file.jpg")
  719. assert_equal(
  720. {:controller => "user", :action => "download", :file => "file.jpg"},
  721. rs.recognize_path("/user/download/file.jpg"))
  722. end
  723. def test_basic_named_route
  724. rs.add_named_route :home, '', :controller => 'content', :action => 'list'
  725. x = setup_for_named_route
  726. assert_equal("http://named.route.test/",
  727. x.send(:home_url))
  728. end
  729. def test_basic_named_route_with_relative_url_root
  730. rs.add_named_route :home, '', :controller => 'content', :action => 'list'
  731. x = setup_for_named_route
  732. ActionController::Base.relative_url_root = "/foo"
  733. assert_equal("http://named.route.test/foo/",
  734. x.send(:home_url))
  735. assert_equal "/foo/", x.send(:home_path)
  736. ActionController::Base.relative_url_root = nil
  737. end
  738. def test_named_route_with_option
  739. rs.add_named_route :page, 'page/:title', :controller => 'content', :action => 'show_page'
  740. x = setup_for_named_route
  741. assert_equal("http://named.route.test/page/new%20stuff",
  742. x.send(:page_url, :title => 'new stuff'))
  743. end
  744. def test_named_route_with_default
  745. rs.add_named_route :page, 'page/:title', :controller => 'content', :action => 'show_page', :title => 'AboutPage'
  746. x = setup_for_named_route
  747. assert_equal("http://named.route.test/page/AboutRails",
  748. x.send(:page_url, :title => "AboutRails"))
  749. end
  750. def test_named_route_with_nested_controller
  751. rs.add_named_route :users, 'admin/user', :controller => 'admin/user', :action => 'index'
  752. x = setup_for_named_route
  753. assert_equal("http://named.route.test/admin/user",
  754. x.send(:users_url))
  755. end
  756. def test_optimised_named_route_call_never_uses_url_for
  757. rs.add_named_route :users, 'admin/user', :controller => '/admin/user', :action => 'index'
  758. rs.add_named_route :user, 'admin/user/:id', :controller=>'/admin/user', :action=>'show'
  759. x = setup_for_named_route
  760. x.expects(:url_for).never
  761. x.send(:users_url)
  762. x.send(:users_path)
  763. x.send(:user_url, 2, :foo=>"bar")
  764. x.send(:user_path, 3, :bar=>"foo")
  765. end
  766. def test_optimised_named_route_with_host
  767. rs.add_named_route :pages, 'pages', :controller => 'content', :action => 'show_page', :host => 'foo.com'
  768. x = setup_for_named_route
  769. x.expects(:url_for).with(:host => 'foo.com', :only_path => false, :controller => 'content', :action => 'show_page', :use_route => :pages).once
  770. x.send(:pages_url)
  771. end
  772. def setup_for_named_route
  773. klass = Class.new(MockController)
  774. rs.install_helpers(klass)
  775. klass.new(rs)
  776. end
  777. def test_named_route_without_hash
  778. rs.draw do |map|
  779. map.normal ':controller/:action/:id'
  780. end
  781. end
  782. def test_named_route_root
  783. rs.draw do |map|
  784. map.root :controller => "hello"
  785. end
  786. x = setup_for_named_route
  787. assert_equal("http://named.route.test/", x.send(:root_url))
  788. assert_equal("/", x.send(:root_path))
  789. end
  790. def test_named_route_with_regexps
  791. rs.draw do |map|
  792. map.article 'page/:year/:month/:day/:title', :controller => 'page', :action => 'show',
  793. :year => /\d+/, :month => /\d+/, :day => /\d+/
  794. map.connect ':controller/:action/:id'
  795. end
  796. x = setup_for_named_route
  797. # assert_equal(
  798. # {:controller => 'page', :action => 'show', :title => 'hi', :use_route => :article, :only_path => false},
  799. # x.send(:article_url, :title => 'hi')
  800. # )
  801. assert_equal(
  802. "http://named.route.test/page/2005/6/10/hi",
  803. x.send(:article_url, :title => 'hi', :day => 10, :year => 2005, :month => 6)
  804. )
  805. end
  806. def test_changing_controller
  807. assert_equal '/admin/stuff/show/10', rs.generate(
  808. {:controller => 'stuff', :action => 'show', :id => 10},
  809. {:controller => 'admin/user', :action => 'index'}
  810. )
  811. end
  812. def test_paths_escaped
  813. rs.draw do |map|
  814. map.path 'file/*path', :controller => 'content', :action => 'show_file'
  815. map.connect ':controller/:action/:id'
  816. end
  817. # No + to space in URI escaping, only for query params.
  818. results = rs.recognize_path "/file/hello+world/how+are+you%3F"
  819. assert results, "Recognition should have succeeded"
  820. assert_equal ['hello+world', 'how+are+you?'], results[:path]
  821. # Use %20 for space instead.
  822. results = rs.recognize_path "/file/hello%20world/how%20are%20you%3F"
  823. assert results, "Recognition should have succeeded"
  824. assert_equal ['hello world', 'how are you?'], results[:path]
  825. results = rs.recognize_path "/file"
  826. assert results, "Recognition should have succeeded"
  827. assert_equal [], results[:path]
  828. end
  829. def test_paths_slashes_unescaped_with_ordered_parameters
  830. rs.add_named_route :path, '/file/*path', :controller => 'content'
  831. # No / to %2F in URI, only for query params.
  832. x = setup_for_named_route
  833. assert_equal("/file/hello/world", x.send(:path_path, 'hello/world'))
  834. end
  835. def test_non_controllers_cannot_be_matched
  836. rs.draw do |map|
  837. map.connect ':controller/:action/:id'
  838. end
  839. assert_raises(ActionController::RoutingError) { rs.recognize_path("/not_a/show/10") }
  840. end
  841. def test_paths_do_not_accept_defaults
  842. assert_raises(ActionController::RoutingError) do
  843. rs.draw do |map|
  844. map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => %w(fake default)
  845. map.connect ':controller/:action/:id'
  846. end
  847. end
  848. rs.draw do |map|
  849. map.path 'file/*path', :controller => 'content', :action => 'show_file', :path => []
  850. map.connect ':controller/:action/:id'
  851. end
  852. end
  853. def test_should_list_options_diff_when_routing_requirements_dont_match
  854. rs.draw do |map|
  855. map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
  856. end
  857. exception = assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'post', :action => 'show', :bad_param => "foo", :use_route => "post") }
  858. assert_match /^post_url failed to generate/, exception.message
  859. from_match = exception.message.match(/from \{[^\}]+\}/).to_s
  860. assert_match /:bad_param=>"foo"/, from_match
  861. assert_match /:action=>"show"/, from_match
  862. assert_match /:controller=>"post"/, from_match
  863. expected_match = exception.message.match(/expected: \{[^\}]+\}/).to_s
  864. assert_no_match /:bad_param=>"foo"/, expected_match
  865. assert_match /:action=>"show"/, expected_match
  866. assert_match /:controller=>"post"/, expected_match
  867. diff_match = exception.message.match(/diff: \{[^\}]+\}/).to_s
  868. assert_match /:bad_param=>"foo"/, diff_match
  869. assert_no_match /:action=>"show"/, diff_match
  870. assert_no_match /:controller=>"post"/, diff_match
  871. end
  872. # this specifies the case where your formerly would get a very confusing error message with an empty diff
  873. def test_should_have_better_error_message_when_options_diff_is_empty
  874. rs.draw do |map|
  875. map.content '/content/:query', :controller => 'content', :action => 'show'
  876. end
  877. exception = assert_raise(ActionController::RoutingError) { rs.generate(:controller => 'content', :action => 'show', :use_route => "content") }
  878. assert_match %r[:action=>"show"], exception.message
  879. assert_match %r[:controller=>"content"], exception.message
  880. assert_match %r[you may have ambiguous routes, or you may need to supply additional parameters for this route], exception.message
  881. assert_match %r[content_url has the following required parameters: \["content", :query\] - are they all satisfied?], exception.message
  882. end
  883. def test_dynamic_path_allowed
  884. rs.draw do |map|
  885. map.connect '*path', :controller => 'content', :action => 'show_file'
  886. end
  887. assert_equal '/pages/boo', rs.generate(:controller => 'content', :action => 'show_file', :path => %w(pages boo))
  888. end
  889. def test_dynamic_recall_paths_allowed
  890. rs.draw do |map|
  891. map.connect '*path', :controller => 'content', :action => 'show_file'
  892. end
  893. recall_path = ActionController::Routing::PathSegment::Result.new(%w(pages boo))
  894. assert_equal '/pages/boo', rs.generate({}, :controller => 'content', :action => 'show_file', :path => recall_path)
  895. end
  896. def test_backwards
  897. rs.draw do |map|
  898. map.connect 'page/:id/:action', :controller => 'pages', :action => 'show'
  899. map.connect ':controller/:action/:id'
  900. end
  901. assert_equal '/page/20', rs.generate({:id => 20}, {:controller => 'pages', :action => 'show'})
  902. assert_equal '/page/20', rs.generate(:controller => 'pages', :id => 20, :action => 'show')
  903. assert_equal '/pages/boo', rs.generate(:controller => 'pages', :action => 'boo')
  904. end
  905. def test_route_with_fixnum_default
  906. rs.draw do |map|
  907. map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
  908. map.connect ':controller/:action/:id'
  909. end
  910. assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page')
  911. assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => 1)
  912. assert_equal '/page', rs.generate(:controller => 'content', :action => 'show_page', :id => '1')
  913. assert_equal '/page/10', rs.generate(:controller => 'content', :action => 'show_page', :id => 10)
  914. assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page"))
  915. assert_equal({:controller => "content", :action => 'show_page', :id => '1'}, rs.recognize_path("/page/1"))
  916. assert_equal({:controller => "content", :action => 'show_page', :id => '10'}, rs.recognize_path("/page/10"))
  917. end
  918. # For newer revision
  919. def test_route_with_text_default
  920. rs.draw do |map|
  921. map.connect 'page/:id', :controller => 'content', :action => 'show_page', :id => 1
  922. map.connect ':controller/:action/:id'
  923. end
  924. assert_equal '/page/foo', rs.generate(:controller => 'content', :action => 'show_page', :id => 'foo')
  925. assert_equal({:controller => "content", :action => 'show_page', :id => 'foo'}, rs.recognize_path("/page/foo"))
  926. token = "\321\202\320\265\320\272\321\201\321\202" # 'text' in russian
  927. escaped_token = CGI::escape(token)
  928. assert_equal '/page/' + escaped_token, rs.generate(:controller => 'content', :action => 'show_page', :id => token)
  929. assert_equal({:controller => "content", :action => 'show_page', :id => token}, rs.recognize_path("/page/#{escaped_token}"))
  930. end
  931. def test_action_expiry
  932. assert_equal '/content', rs.generate({:controller => 'content'}, {:controller => 'content', :action => 'show'})
  933. end
  934. def test_recognition_with_uppercase_controller_name
  935. assert_equal({:controller => "content", :action => 'index'}, rs.recognize_path("/Content"))
  936. assert_equal({:controller => "content", :action => 'list'}, rs.recognize_path("/ConTent/list"))
  937. assert_equal({:controller => "content", :action => 'show', :id => '10'}, rs.recognize_path("/CONTENT/show/10"))
  938. # these used to work, before the routes rewrite, but support for this was pulled in the new version...
  939. #assert_equal({'controller' => "admin/news_feed", 'action' => 'index'}, rs.recognize_path("Admin/NewsFeed"))
  940. #assert_equal({'controller' => "admin/news_feed", 'action' => 'index'}, rs.recognize_path("Admin/News_Feed"))
  941. end
  942. def test_requirement_should_prevent_optional_id
  943. rs.draw do |map|
  944. map.post 'post/:id', :controller=> 'post', :action=> 'show', :requirements => {:id => /\d+/}
  945. end
  946. assert_equal '/post/10', rs.generate(:controller => 'post', :action => 'show', :id => 10)
  947. assert_raises ActionController::RoutingError do
  948. rs.generate(:controller => 'post', :action => 'show')
  949. end
  950. end
  951. def test_both_requirement_and_optional
  952. rs.draw do |map|
  953. map.blog('test/:year', :controller => 'post', :action => 'show',
  954. :defaults => { :year => nil },
  955. :requirements => { :year => /\d{4}/ }
  956. )
  957. map.connect ':controller/:action/:id'
  958. end
  959. assert_equal '/test', rs.generate(:controller => 'post', :action => 'show')
  960. assert_equal '/test', rs.generate(:controller => 'post', :action => 'show', :year => nil)
  961. x = setup_for_named_route
  962. assert_equal("http://named.route.test/test",
  963. x.send(:blog_url))
  964. end
  965. def test_set_to_nil_forgets
  966. rs.draw do |map|
  967. map.connect 'pages/:year/:month/:day', :controller => 'content', :action => 'list_pages', :month => nil, :day => nil
  968. map.connect ':controller/:action/:id'
  969. end
  970. assert_equal '/pages/2005',
  971. rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005)
  972. assert_equal '/pages/2005/6',
  973. rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6)
  974. assert_equal '/pages/2005/6/12',
  975. rs.generate(:controller => 'content', :action => 'list_pages', :year => 2005, :month => 6, :day => 12)
  976. assert_equal '/pages/2005/6/4',
  977. rs.generate({:day => 4}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
  978. assert_equal '/pages/2005/6',
  979. rs.generate({:day => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
  980. assert_equal '/pages/2005',
  981. rs.generate({:day => nil, :month => nil}, {:controller => 'content', :action => 'list_pages', :year => '2005', :month => '6', :day => '12'})
  982. end
  983. def test_url_with_no_action_specified
  984. rs.draw do |map|
  985. map.connect '', :controller => 'content'
  986. map.connect ':controller/:action/:id'
  987. end
  988. assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
  989. assert_equal '/', rs.generate(:controller => 'content')
  990. end
  991. def test_named_url_with_no_action_specified
  992. rs.draw do |map|
  993. map.home '', :controller => 'content'
  994. map.connect ':controller/:action/:id'
  995. end
  996. assert_equal '/', rs.generate(:controller => 'content', :action => 'index')
  997. assert_equal '/', rs.generate(:controller => 'content')
  998. x = setup_for_named_route
  999. assert_equal("http://named.route.test/",
  1000. x.send(:home_url))
  1001. end
  1002. def test_url_generated_when_forgetting_action
  1003. [{:controller => 'content', :action => 'index'}, {:controller => 'content'}].each do |hash|
  1004. rs.draw do |map|
  1005. map.home '', hash
  1006. map.connect ':controller/:action/:id'
  1007. end
  1008. assert_equal '/', rs.generate({:action => nil}, {:controller => 'content', :action => 'hello'})
  1009. assert_equal '/', rs.generate({:controller => 'content'})
  1010. assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
  1011. end
  1012. end
  1013. def test_named_route_method
  1014. rs.draw do |map|
  1015. map.categories 'categories', :controller => 'content', :action => 'categories'
  1016. map.connect ':controller/:action/:id'
  1017. end
  1018. assert_equal '/categories', rs.generate(:controller => 'content', :action => 'categories')
  1019. assert_equal '/content/hi', rs.generate({:controller => 'content', :action => 'hi'})
  1020. end
  1021. def test_named_routes_array
  1022. test_named_route_method
  1023. assert_equal [:categories], rs.named_routes.names
  1024. end
  1025. def test_nil_defaults
  1026. rs.draw do |map|
  1027. map.connect 'journal',
  1028. :controller => 'content',
  1029. :action => 'list_journal',
  1030. :date => nil, :user_id => nil
  1031. map.connect ':controller/:action/:id'
  1032. end
  1033. assert_equal '/journal', rs.generate(:controller => 'content', :action => 'list_journal', :date => nil, :user_id => nil)
  1034. end
  1035. def setup_request_method_routes_for(method)
  1036. @request = ActionController::TestRequest.new
  1037. @request.env["REQUEST_METHOD"] = method
  1038. @request.request_uri = "/match"
  1039. rs.draw do |r|
  1040. r.connect '/match', :controller => 'books', :action => 'get', :conditions => { :method => :get }
  1041. r.connect '/match', :controller => 'books', :action => 'post', :conditions => { :method => :post }
  1042. r.connect '/match', :controller => 'books', :action => 'put', :conditions => { :method => :put }
  1043. r.connect '/match', :controller => 'books', :action => 'delete', :conditions => { :method => :delete }
  1044. end
  1045. end
  1046. %w(GET POST PUT DELETE).each do |request_method|
  1047. define_method("test_request_method_recognized_with_#{request_method}") do
  1048. begin
  1049. Object.const_set(:BooksController, Class.new(ActionController::Base))
  1050. setup_request_method_routes_for(request_method)
  1051. assert_nothing_raised { rs.recognize(@request) }
  1052. assert_equal request_method.downcase, @request.path_parameters[:action]
  1053. ensure
  1054. Object.send(:remove_const, :BooksController) rescue nil
  1055. end
  1056. end
  1057. end
  1058. def test_recognize_array_of_methods
  1059. Object.const_set(:BooksController, Class.new(ActionController::Base))
  1060. rs.draw do |r|
  1061. r.connect '/match', :controller => 'books', :action => 'get_or_post', :conditions => { :method => [:get, :post] }
  1062. r.connect '/match', :controller => 'books', :action => 'not_get_or_post'
  1063. end
  1064. @request = ActionController::TestRequest.new
  1065. @request.env["REQUEST_METHOD"] = 'POST'
  1066. @request.request_uri = "/match"
  1067. assert_nothing_raised { rs.recognize(@request) }
  1068. assert_equal 'get_or_post', @request.path_parameters[:action]
  1069. # have to recreate or else the RouteSet uses a cached version:
  1070. @request = ActionController::TestRequest.new
  1071. @request.env["REQUEST_METHOD"] = 'PUT'
  1072. @request.request_uri = "/match"
  1073. assert_nothing_raised { rs.recognize(@request) }
  1074. assert_equal 'not_get_or_post', @request.path_parameters[:action]
  1075. ensure
  1076. Object.send(:remove_const, :BooksController) rescue nil
  1077. end
  1078. def test_subpath_recognized
  1079. Object.const_set(:SubpathBooksController, Class.new(ActionController::Base))
  1080. rs.draw do |r|
  1081. r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
  1082. r.connect '/items/:id/:action', :controller => 'subpath_books'
  1083. r.connect '/posts/new/:action', :controller => 'subpath_books'
  1084. r.connect '/posts/:id', :controller => 'subpath_books', :action => "show"
  1085. end
  1086. hash = rs.recognize_path "/books/17/edit"
  1087. assert_not_nil hash
  1088. assert_equal %w(subpath_books 17 edit), [hash[:controller], hash[:id], hash[:action]]
  1089. hash = rs.recognize_path "/items/3/complete"
  1090. assert_not_nil hash
  1091. assert_equal %w(subpath_books 3 complete), [hash[:controller], hash[:id], hash[:action]]
  1092. hash = rs.recognize_path "/posts/new/preview"
  1093. assert_not_nil hash
  1094. assert_equal %w(subpath_books preview), [hash[:controller], hash[:action]]
  1095. hash = rs.recognize_path "/posts/7"
  1096. assert_not_nil hash
  1097. assert_equal %w(subpath_books show 7), [hash[:controller], hash[:action], hash[:id]]
  1098. ensure
  1099. Object.send(:remove_const, :SubpathBooksController) rescue nil
  1100. end
  1101. def test_subpath_generated
  1102. Object.const_set(:SubpathBooksController, Class.new(ActionController::Base))
  1103. rs.draw do |r|
  1104. r.connect '/books/:id/edit', :controller => 'subpath_books', :action => 'edit'
  1105. r.connect '/items/:id/:action', :controller => 'subpath_books'
  1106. r.connect '/posts/new/:action', :controller => 'subpath_books'
  1107. end
  1108. assert_equal "/books/7/edit", rs.generate(:controller => "subpath_books", :id => 7, :action => "edit")
  1109. assert_equal "/items/15/complete", rs.generate(:controller => "subpath_books", :id => 15, :action => "complete")
  1110. assert_equal "/posts/new/preview", rs.generate(:controller => "subpath_books", :action => "preview")
  1111. ensure
  1112. Object.send(:remove_const, :SubpathBooksController) rescue nil
  1113. end
  1114. def test_failed_requirements_raises_exception_with_violated_requirements
  1115. rs.draw do |r|
  1116. r.foo_with_requirement 'foos/:id', :controller=>'foos', :requirements=>{:id=>/\d+/}
  1117. end
  1118. x = setup_for_named_route
  1119. assert_raises(ActionController::RoutingError) do
  1120. x.send(:foo_with_requirement_url, "I am Against the requirements")
  1121. end
  1122. end
  1123. end
  1124. class RouteTest < Test::Unit::TestCase
  1125. def setup
  1126. @route = ROUTING::Route.new
  1127. end
  1128. def slash_segment(is_optional = false)
  1129. ROUTING::DividerSegment.new('/', :optional => is_optional)
  1130. end
  1131. def default_route
  1132. unless defined?(@default_route)
  1133. segments = []
  1134. segments << ROUTING::StaticSegment.new('/', :raw => true)
  1135. segments << ROUTING::DynamicSegment.new(:controller)
  1136. segments << slash_segment(:optional)
  1137. segments << ROUTING::DynamicSegment.new(:action, :default => 'index', :optional => true)
  1138. segments << slash_segment(:optional)
  1139. segments << ROUTING::DynamicSegment.new(:id, :optional => true)
  1140. segments << slash_segment(:optional)
  1141. @default_route = ROUTING::Route.new(segments).freeze
  1142. end
  1143. @default_route
  1144. end
  1145. def test_default_route_recognition
  1146. expected = {:controller => 'accounts', :action => 'show', :id => '10'}
  1147. assert_equal expected, default_route.recognize('/accounts/show/10')
  1148. assert_equal expected, default_route.recognize('/accounts/show/10/')
  1149. expected[:id] = 'jamis'
  1150. assert_equal expected, default_route.recognize('/accounts/show/jamis/')
  1151. expected.delete :id
  1152. assert_equal expected, default_route.recognize('/accounts/show')
  1153. assert_equal expected, default_route.recognize('/accounts/show/')
  1154. expected[:action] = 'index'
  1155. assert_equal expected, default_route.recognize('/accounts/')
  1156. assert_equal expected, default_route.recognize('/accounts')
  1157. assert_equal nil, default_route.recognize('/')
  1158. assert_equal nil, default_route.recognize('/accounts/how/goood/it/is/to/be/free')
  1159. end
  1160. def test_default_route_should_omit_default_action
  1161. o = {:controller => 'accounts', :action => 'index'}
  1162. assert_equal '/accounts', default_route.generate(o, o, {})
  1163. end
  1164. def test_default_route_should_include_default_action_when_id_present
  1165. o = {:controller => 'accounts', :action => 'index', :id => '20'}
  1166. assert_equal '/accounts/index/20', default_route.generate(o, o, {})
  1167. end
  1168. def test_default_route_should_work_with_action_but_no_id
  1169. o = {:controller => 'accounts', :action => 'list_all'}
  1170. assert_equal '/accounts/list_all', default_route.generate(o, o, {})
  1171. end
  1172. def test_default_route_should_uri_escape_pluses
  1173. expected = { :controller => 'accounts', :action => 'show', :id => 'hello world' }
  1174. assert_equal expected, default_route.recognize('/accounts/show/hello world')
  1175. assert_equal expected, default_route.recognize('/accounts/show/hello%20world')
  1176. assert_equal '/accounts/show/hello%20world', default_route.generate(expected, expected, {})
  1177. expected[:id] = 'hello+world'
  1178. assert_equal expected, default_route.recognize('/accounts/show/hello+world')
  1179. assert_equal expected, default_route.recognize('/accounts/show/hello%2Bworld')
  1180. assert_equal '/accounts/show/hello+world', default_route.generate(expected, expected, {})
  1181. end
  1182. def test_matches_controller_and_action
  1183. # requirement_for should only be called for the action and controller _once_
  1184. @route.expects(:requirement_for).with(:controller).times(1).returns('pages')
  1185. @route.expects(:requirement_for).with(:action).times(1).returns('show')
  1186. @route.requirements = {:controller => 'pages', :action => 'show'}
  1187. assert @route.matches_controller_and_action?('pages', 'show')
  1188. assert !@route.matches_controller_and_action?('not_pages', 'show')
  1189. assert !@route.matches_controller_and_action?('pages', 'not_show')
  1190. end
  1191. def test_parameter_shell
  1192. page_url = ROUTING::Route.new
  1193. page_url.requirements = {:controller => 'pages', :action => 'show', :id => /\d+/}
  1194. assert_equal({:controller => 'pages', :action => 'show'}, page_url.parameter_shell)
  1195. end
  1196. def test_defaults
  1197. route = ROUTING::RouteBuilder.new.build '/users/:id.:format', :controller => "users", :action => "show", :format => "html"
  1198. assert_equal(
  1199. { :controller => "users", :action => "show", :format => "html" },
  1200. route.defaults)
  1201. end
  1202. def test_builder_complains_without_controller
  1203. assert_raises(ArgumentError) do
  1204. ROUTING::RouteBuilder.new.build '/contact', :contoller => "contact", :action => "index"
  1205. end
  1206. end
  1207. def test_significant_keys_for_default_route
  1208. keys = default_route.significant_keys.sort_by {|k| k.to_s }
  1209. assert_equal [:action, :controller, :id], keys
  1210. end
  1211. def test_significant_keys
  1212. segments = []
  1213. segments << ROUTING::StaticSegment.new('/', :raw => true)
  1214. segments << ROUTING::StaticSegment.new('user')
  1215. segments << ROUTING::StaticSegment.new('/', :raw => true, :optional => true)
  1216. segments << ROUTING::DynamicSegment.new(:user)
  1217. segments << ROUTING::StaticSegment.new('/', :raw => true, :optional => true)
  1218. requirements = {:controller => 'users', :action => 'show'}
  1219. user_url = ROUTING::Route.new(segments, requirements)
  1220. keys = user_url.significant_keys.sort_by { |k| k.to_s }
  1221. assert_equal [:action, :controller, :user], keys
  1222. end
  1223. def test_build_empty_query_string
  1224. assert_equal '', @route.build_query_string({})
  1225. end
  1226. def test_build_query_string_with_nil_value
  1227. assert_equal '', @route.build_query_string({:x => nil})
  1228. end
  1229. def test_simple_build_query_string
  1230. assert_equal '?x=1&y=2', order_query_string(@route.build_query_string(:x => '1', :y => '2'))
  1231. end
  1232. def test_convert_ints_build_query_string
  1233. assert_equal '?x=1&y=2', order_query_string(@route.build_query_string(:x => 1, :y => 2))
  1234. end
  1235. def test_escape_spaces_build_query_string
  1236. assert_equal '?x=hello+world&y=goodbye+world', order_query_string(@route.build_query_string(:x => 'hello world', :y => 'goodbye world'))
  1237. end
  1238. def test_expand_array_build_query_string
  1239. assert_equal '?x%5B%5D=1&x%5B%5D=2', order_query_string(@route.build_query_string(:x => [1, 2]))
  1240. end
  1241. def test_escape_spaces_build_query_string_selected_keys
  1242. assert_equal '?x=hello+world', order_query_string(@route.build_query_string({:x => 'hello world', :y => 'goodbye world'}, [:x]))
  1243. end
  1244. private
  1245. def order_query_string(qs)
  1246. '?' + qs[1..-1].split('&').sort.join('&')
  1247. end
  1248. end
  1249. class RouteSetTest < Test::Unit::TestCase
  1250. def set
  1251. @set ||= ROUTING::RouteSet.new
  1252. end
  1253. def request
  1254. @request ||= MockRequest.new(:host => "named.routes.test", :method => :get)
  1255. end
  1256. def test_generate_extras
  1257. set.draw { |m| m.connect ':controller/:action/:id' }
  1258. path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
  1259. assert_equal "/foo/bar/15", path
  1260. assert_equal %w(that this), extras.map(&:to_s).sort
  1261. end
  1262. def test_extra_keys
  1263. set.draw { |m| m.connect ':controller/:action/:id' }
  1264. extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
  1265. assert_equal %w(that this), extras.map(&:to_s).sort
  1266. end
  1267. def test_generate_extras_not_first
  1268. set.draw do |map|
  1269. map.connect ':controller/:action/:id.:format'
  1270. map.connect ':controller/:action/:id'
  1271. end
  1272. path, extras = set.generate_extras(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
  1273. assert_equal "/foo/bar/15", path
  1274. assert_equal %w(that this), extras.map(&:to_s).sort
  1275. end
  1276. def test_generate_not_first
  1277. set.draw do |map|
  1278. map.connect ':controller/:action/:id.:format'
  1279. map.connect ':controller/:action/:id'
  1280. end
  1281. assert_equal "/foo/bar/15?this=hello", set.generate(:controller => "foo", :action => "bar", :id => 15, :this => "hello")
  1282. end
  1283. def test_extra_keys_not_first
  1284. set.draw do |map|
  1285. map.connect ':controller/:action/:id.:format'
  1286. map.connect ':controller/:action/:id'
  1287. end
  1288. extras = set.extra_keys(:controller => "foo", :action => "bar", :id => 15, :this => "hello", :that => "world")
  1289. assert_equal %w(that this), extras.map(&:to_s).sort
  1290. end
  1291. def test_draw
  1292. assert_equal 0, set.routes.size
  1293. set.draw do |map|
  1294. map.connect '/hello/world', :controller => 'a', :action => 'b'
  1295. end
  1296. assert_equal 1, set.routes.size
  1297. end
  1298. def test_named_draw
  1299. assert_equal 0, set.routes.size
  1300. set.draw do |map|
  1301. map.hello '/hello/world', :controller => 'a', :action => 'b'
  1302. end
  1303. assert_equal 1, set.routes.size
  1304. assert_equal set.routes.first, set.named_routes[:hello]
  1305. end
  1306. def test_later_named_routes_take_precedence
  1307. set.draw do |map|
  1308. map.hello '/hello/world', :controller => 'a', :action => 'b'
  1309. map.hello '/hello', :controller => 'a', :action => 'b'
  1310. end
  1311. assert_equal set.routes.last, set.named_routes[:hello]
  1312. end
  1313. def setup_named_route_test
  1314. set.draw do |map|
  1315. map.show '/people/:id', :controller => 'people', :action => 'show'
  1316. map.index '/people', :controller => 'people', :action => 'index'
  1317. map.multi '/people/go/:foo/:bar/joe/:id', :controller => 'people', :action => 'multi'
  1318. map.users '/admin/users', :controller => 'admin/users', :action => 'index'
  1319. end
  1320. klass = Class.new(MockController)
  1321. set.install_helpers(klass)
  1322. klass.new(set)
  1323. end
  1324. def test_named_route_hash_access_method
  1325. controller = setup_named_route_test
  1326. assert_equal(
  1327. { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => false },
  1328. controller.send(:hash_for_show_url, :id => 5))
  1329. assert_equal(
  1330. { :controller => 'people', :action => 'index', :use_route => :index, :only_path => false },
  1331. controller.send(:hash_for_index_url))
  1332. assert_equal(
  1333. { :controller => 'people', :action => 'show', :id => 5, :use_route => :show, :only_path => true },
  1334. controller.send(:hash_for_show_path, :id => 5)
  1335. )
  1336. end
  1337. def test_named_route_url_method
  1338. controller = setup_named_route_test
  1339. assert_equal "http://named.route.test/people/5", controller.send(:show_url, :id => 5)
  1340. assert_equal "/people/5", controller.send(:show_path, :id => 5)
  1341. assert_equal "http://named.route.test/people", controller.send(:index_url)
  1342. assert_equal "/people", controller.send(:index_path)
  1343. assert_equal "http://named.route.test/admin/users", controller.send(:users_url)
  1344. assert_equal '/admin/users', controller.send(:users_path)
  1345. assert_equal '/admin/users', set.generate(controller.send(:hash_for_users_url), {:controller => 'users', :action => 'index'})
  1346. end
  1347. def test_named_route_url_method_with_anchor
  1348. controller = setup_named_route_test
  1349. assert_equal "http://named.route.test/people/5#location", controller.send(:show_url, :id => 5, :anchor => 'location')
  1350. assert_equal "/people/5#location", controller.send(:show_path, :id => 5, :anchor => 'location')
  1351. assert_equal "http://named.route.test/people#location", controller.send(:index_url, :anchor => 'location')
  1352. assert_equal "/people#location", controller.send(:index_path, :anchor => 'location')
  1353. assert_equal "http://named.route.test/admin/users#location", controller.send(:users_url, :anchor => 'location')
  1354. assert_equal '/admin/users#location', controller.send(:users_path, :anchor => 'location')
  1355. assert_equal "http://named.route.test/people/go/7/hello/joe/5#location",
  1356. controller.send(:multi_url, 7, "hello", 5, :anchor => 'location')
  1357. assert_equal "http://named.route.test/people/go/7/hello/joe/5?baz=bar#location",
  1358. controller.send(:multi_url, 7, "hello", 5, :baz => "bar", :anchor => 'location')
  1359. assert_equal "http://named.route.test/people?baz=bar#location",
  1360. controller.send(:index_url, :baz => "bar", :anchor => 'location')
  1361. end
  1362. def test_named_route_url_method_with_port
  1363. controller = setup_named_route_test
  1364. assert_equal "http://named.route.test:8080/people/5", controller.send(:show_url, 5, :port=>8080)
  1365. end
  1366. def test_named_route_url_method_with_host
  1367. controller = setup_named_route_test
  1368. assert_equal "http://some.example.com/people/5", controller.send(:show_url, 5, :host=>"some.example.com")
  1369. end
  1370. def test_named_route_url_method_with_ordered_parameters
  1371. controller = setup_named_route_test
  1372. assert_equal "http://named.route.test/people/go/7/hello/joe/5",
  1373. controller.send(:multi_url, 7, "hello", 5)
  1374. end
  1375. def test_named_route_url_method_with_ordered_parameters_and_hash
  1376. controller = setup_named_route_test
  1377. assert_equal "http://named.route.test/people/go/7/hello/joe/5?baz=bar",
  1378. controller.send(:multi_url, 7, "hello", 5, :baz => "bar")
  1379. end
  1380. def test_named_route_url_method_with_ordered_parameters_and_empty_hash
  1381. controller = setup_named_route_test
  1382. assert_equal "http://named.route.test/people/go/7/hello/joe/5",
  1383. controller.send(:multi_url, 7, "hello", 5, {})
  1384. end
  1385. def test_named_route_url_method_with_no_positional_arguments
  1386. controller = setup_named_route_test
  1387. assert_equal "http://named.route.test/people?baz=bar",
  1388. controller.send(:index_url, :baz => "bar")
  1389. end
  1390. def test_draw_default_route
  1391. ActionController::Routing.with_controllers(['users']) do
  1392. set.draw do |map|
  1393. map.connect '/:controller/:action/:id'
  1394. end
  1395. assert_equal 1, set.routes.size
  1396. route = set.routes.first
  1397. assert route.segments.last.optional?
  1398. assert_equal '/users/show/10', set.generate(:controller => 'users', :action => 'show', :id => 10)
  1399. assert_equal '/users/index/10', set.generate(:controller => 'users', :id => 10)
  1400. assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10'))
  1401. assert_equal({:controller => 'users', :action => 'index', :id => '10'}, set.recognize_path('/users/index/10/'))
  1402. end
  1403. end
  1404. def test_draw_default_route_with_default_controller
  1405. ActionController::Routing.with_controllers(['users']) do
  1406. set.draw do |map|
  1407. map.connect '/:controller/:action/:id', :controller => 'users'
  1408. end
  1409. assert_equal({:controller => 'users', :action => 'index'}, set.recognize_path('/'))
  1410. end
  1411. end
  1412. def test_route_with_parameter_shell
  1413. ActionController::Routing.with_controllers(['users', 'pages']) do
  1414. set.draw do |map|
  1415. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/
  1416. map.connect '/:controller/:action/:id'
  1417. end
  1418. assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages'))
  1419. assert_equal({:controller => 'pages', :action => 'index'}, set.recognize_path('/pages/index'))
  1420. assert_equal({:controller => 'pages', :action => 'list'}, set.recognize_path('/pages/list'))
  1421. assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/pages/show/10'))
  1422. assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
  1423. end
  1424. end
  1425. def test_route_requirements_with_anchor_chars_are_invalid
  1426. assert_raises ArgumentError do
  1427. set.draw do |map|
  1428. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /^\d+/
  1429. end
  1430. end
  1431. assert_raises ArgumentError do
  1432. set.draw do |map|
  1433. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\A\d+/
  1434. end
  1435. end
  1436. assert_raises ArgumentError do
  1437. set.draw do |map|
  1438. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+$/
  1439. end
  1440. end
  1441. assert_raises ArgumentError do
  1442. set.draw do |map|
  1443. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\Z/
  1444. end
  1445. end
  1446. assert_raises ArgumentError do
  1447. set.draw do |map|
  1448. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+\z/
  1449. end
  1450. end
  1451. assert_nothing_raised do
  1452. set.draw do |map|
  1453. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /\d+/, :name => /^(david|jamis)/
  1454. end
  1455. assert_raises ActionController::RoutingError do
  1456. set.generate :controller => 'pages', :action => 'show', :id => 10
  1457. end
  1458. end
  1459. end
  1460. def test_route_requirements_with_invalid_http_method_is_invalid
  1461. assert_raises ArgumentError do
  1462. set.draw do |map|
  1463. map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :invalid}
  1464. end
  1465. end
  1466. end
  1467. def test_route_requirements_with_head_method_condition_is_invalid
  1468. assert_raises ArgumentError do
  1469. set.draw do |map|
  1470. map.connect 'valid/route', :controller => 'pages', :action => 'show', :conditions => {:method => :head}
  1471. end
  1472. end
  1473. end
  1474. def test_non_path_route_requirements_match_all
  1475. set.draw do |map|
  1476. map.connect 'page/37s', :controller => 'pages', :action => 'show', :name => /(jamis|david)/
  1477. end
  1478. assert_equal '/page/37s', set.generate(:controller => 'pages', :action => 'show', :name => 'jamis')
  1479. assert_raises ActionController::RoutingError do
  1480. set.generate(:controller => 'pages', :action => 'show', :name => 'not_jamis')
  1481. end
  1482. assert_raises ActionController::RoutingError do
  1483. set.generate(:controller => 'pages', :action => 'show', :name => 'nor_jamis_and_david')
  1484. end
  1485. end
  1486. def test_recognize_with_encoded_id_and_regex
  1487. set.draw do |map|
  1488. map.connect 'page/:id', :controller => 'pages', :action => 'show', :id => /[a-zA-Z0-9\+]+/
  1489. end
  1490. assert_equal({:controller => 'pages', :action => 'show', :id => '10'}, set.recognize_path('/page/10'))
  1491. assert_equal({:controller => 'pages', :action => 'show', :id => 'hello+world'}, set.recognize_path('/page/hello+world'))
  1492. end
  1493. def test_recognize_with_conditions
  1494. Object.const_set(:PeopleController, Class.new)
  1495. set.draw do |map|
  1496. map.with_options(:controller => "people") do |people|
  1497. people.people "/people", :action => "index", :conditions => { :method => :get }
  1498. people.connect "/people", :action => "create", :conditions => { :method => :post }
  1499. people.person "/people/:id", :action => "show", :conditions => { :method => :get }
  1500. people.connect "/people/:id", :action => "update", :conditions => { :method => :put }
  1501. people.connect "/people/:id", :action => "destroy", :conditions => { :method => :delete }
  1502. end
  1503. end
  1504. request.path = "/people"
  1505. request.method = :get
  1506. assert_nothing_raised { set.recognize(request) }
  1507. assert_equal("index", request.path_parameters[:action])
  1508. request.method = :post
  1509. assert_nothing_raised { set.recognize(request) }
  1510. assert_equal("create", request.path_parameters[:action])
  1511. request.method = :put
  1512. assert_nothing_raised { set.recognize(request) }
  1513. assert_equal("update", request.path_parameters[:action])
  1514. begin
  1515. request.method = :bacon
  1516. set.recognize(request)
  1517. flunk 'Should have raised NotImplemented'
  1518. rescue ActionController::NotImplemented => e
  1519. assert_equal [:get, :post, :put, :delete], e.allowed_methods
  1520. end
  1521. request.path = "/people/5"
  1522. request.method = :get
  1523. assert_nothing_raised { set.recognize(request) }
  1524. assert_equal("show", request.path_parameters[:action])
  1525. assert_equal("5", request.path_parameters[:id])
  1526. request.method = :put
  1527. assert_nothing_raised { set.recognize(request) }
  1528. assert_equal("update", request.path_parameters[:action])
  1529. assert_equal("5", request.path_parameters[:id])
  1530. request.method = :delete
  1531. assert_nothing_raised { set.recognize(request) }
  1532. assert_equal("destroy", request.path_parameters[:action])
  1533. assert_equal("5", request.path_parameters[:id])
  1534. begin
  1535. request.method = :post
  1536. set.recognize(request)
  1537. flunk 'Should have raised MethodNotAllowed'
  1538. rescue ActionController::MethodNotAllowed => e
  1539. assert_equal [:get, :put, :delete], e.allowed_methods
  1540. end
  1541. ensure
  1542. Object.send(:remove_const, :PeopleController)
  1543. end
  1544. def test_recognize_with_alias_in_conditions
  1545. Object.const_set(:PeopleController, Class.new)
  1546. set.draw do |map|
  1547. map.people "/people", :controller => 'people', :action => "index",
  1548. :conditions => { :method => :get }
  1549. map.root :people
  1550. end
  1551. request.path = "/people"
  1552. request.method = :get
  1553. assert_nothing_raised { set.recognize(request) }
  1554. assert_equal("people", request.path_parameters[:controller])
  1555. assert_equal("index", request.path_parameters[:action])
  1556. request.path = "/"
  1557. request.method = :get
  1558. assert_nothing_raised { set.recognize(request) }
  1559. assert_equal("people", request.path_parameters[:controller])
  1560. assert_equal("index", request.path_parameters[:action])
  1561. ensure
  1562. Object.send(:remove_const, :PeopleController)
  1563. end
  1564. def test_typo_recognition
  1565. Object.const_set(:ArticlesController, Class.new)
  1566. set.draw do |map|
  1567. map.connect 'articles/:year/:month/:day/:title',
  1568. :controller => 'articles', :action => 'permalink',
  1569. :year => /\d{4}/, :day => /\d{1,2}/, :month => /\d{1,2}/
  1570. end
  1571. request.path = "/articles/2005/11/05/a-very-interesting-article"
  1572. request.method = :get
  1573. assert_nothing_raised { set.recognize(request) }
  1574. assert_equal("permalink", request.path_parameters[:action])
  1575. assert_equal("2005", request.path_parameters[:year])
  1576. assert_equal("11", request.path_parameters[:month])
  1577. assert_equal("05", request.path_parameters[:day])
  1578. assert_equal("a-very-interesting-article", request.path_parameters[:title])
  1579. ensure
  1580. Object.send(:remove_const, :ArticlesController)
  1581. end
  1582. def test_routing_traversal_does_not_load_extra_classes
  1583. assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
  1584. set.draw do |map|
  1585. map.connect '/profile', :controller => 'profile'
  1586. end
  1587. request.path = '/profile'
  1588. set.recognize(request) rescue nil
  1589. assert !Object.const_defined?("Profiler__"), "Profiler should not be loaded"
  1590. end
  1591. def test_recognize_with_conditions_and_format
  1592. Object.const_set(:PeopleController, Class.new)
  1593. set.draw do |map|
  1594. map.with_options(:controller => "people") do |people|
  1595. people.person "/people/:id", :action => "show", :conditions => { :method => :get }
  1596. people.connect "/people/:id", :action => "update", :conditions => { :method => :put }
  1597. people.connect "/people/:id.:_format", :action => "show", :conditions => { :method => :get }
  1598. end
  1599. end
  1600. request.path = "/people/5"
  1601. request.method = :get
  1602. assert_nothing_raised { set.recognize(request) }
  1603. assert_equal("show", request.path_parameters[:action])
  1604. assert_equal("5", request.path_parameters[:id])
  1605. request.method = :put
  1606. assert_nothing_raised { set.recognize(request) }
  1607. assert_equal("update", request.path_parameters[:action])
  1608. request.path = "/people/5.png"
  1609. request.method = :get
  1610. assert_nothing_raised { set.recognize(request) }
  1611. assert_equal("show", request.path_parameters[:action])
  1612. assert_equal("5", request.path_parameters[:id])
  1613. assert_equal("png", request.path_parameters[:_format])
  1614. ensure
  1615. Object.send(:remove_const, :PeopleController)
  1616. end
  1617. def test_generate_with_default_action
  1618. set.draw do |map|
  1619. map.connect "/people", :controller => "people"
  1620. map.connect "/people/list", :controller => "people", :action => "list"
  1621. end
  1622. url = set.generate(:controller => "people", :action => "list")
  1623. assert_equal "/people/list", url
  1624. end
  1625. def test_root_map
  1626. Object.const_set(:PeopleController, Class.new)
  1627. set.draw { |map| map.root :controller => "people" }
  1628. request.path = ""
  1629. request.method = :get
  1630. assert_nothing_raised { set.recognize(request) }
  1631. assert_equal("people", request.path_parameters[:controller])
  1632. assert_equal("index", request.path_parameters[:action])
  1633. ensure
  1634. Object.send(:remove_const, :PeopleController)
  1635. end
  1636. def test_namespace
  1637. Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })
  1638. set.draw do |map|
  1639. map.namespace 'api' do |api|
  1640. api.route 'inventory', :controller => "products", :action => 'inventory'
  1641. end
  1642. end
  1643. request.path = "/api/inventory"
  1644. request.method = :get
  1645. assert_nothing_raised { set.recognize(request) }
  1646. assert_equal("api/products", request.path_parameters[:controller])
  1647. assert_equal("inventory", request.path_parameters[:action])
  1648. ensure
  1649. Object.send(:remove_const, :Api)
  1650. end
  1651. def test_namespaced_root_map
  1652. Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })
  1653. set.draw do |map|
  1654. map.namespace 'api' do |api|
  1655. api.root :controller => "products"
  1656. end
  1657. end
  1658. request.path = "/api"
  1659. request.method = :get
  1660. assert_nothing_raised { set.recognize(request) }
  1661. assert_equal("api/products", request.path_parameters[:controller])
  1662. assert_equal("index", request.path_parameters[:action])
  1663. ensure
  1664. Object.send(:remove_const, :Api)
  1665. end
  1666. def test_namespace_with_path_prefix
  1667. Object.const_set(:Api, Module.new { |m| m.const_set(:ProductsController, Class.new) })
  1668. set.draw do |map|
  1669. map.namespace 'api', :path_prefix => 'prefix' do |api|
  1670. api.route 'inventory', :controller => "products", :action => 'inventory'
  1671. end
  1672. end
  1673. request.path = "/prefix/inventory"
  1674. request.method = :get
  1675. assert_nothing_raised { set.recognize(request) }
  1676. assert_equal("api/products", request.path_parameters[:controller])
  1677. assert_equal("inventory", request.path_parameters[:action])
  1678. ensure
  1679. Object.send(:remove_const, :Api)
  1680. end
  1681. def test_generate_finds_best_fit
  1682. set.draw do |map|
  1683. map.connect "/people", :controller => "people", :action => "index"
  1684. map.connect "/ws/people", :controller => "people", :action => "index", :ws => true
  1685. end
  1686. url = set.generate(:controller => "people", :action => "index", :ws => true)
  1687. assert_equal "/ws/people", url
  1688. end
  1689. def test_generate_changes_controller_module
  1690. set.draw { |map| map.connect ':controller/:action/:id' }
  1691. current = { :controller => "bling/bloop", :action => "bap", :id => 9 }
  1692. url = set.generate({:controller => "foo/bar", :action => "baz", :id => 7}, current)
  1693. assert_equal "/foo/bar/baz/7", url
  1694. end
  1695. def test_id_is_not_impossibly_sticky
  1696. set.draw do |map|
  1697. map.connect 'foo/:number', :controller => "people", :action => "index"
  1698. map.connect ':controller/:action/:id'
  1699. end
  1700. url = set.generate({:controller => "people", :action => "index", :number => 3},
  1701. {:controller => "people", :action => "index", :id => "21"})
  1702. assert_equal "/foo/3", url
  1703. end
  1704. def test_id_is_sticky_when_it_ought_to_be
  1705. set.draw do |map|
  1706. map.connect ':controller/:id/:action'
  1707. end
  1708. url = set.generate({:action => "destroy"}, {:controller => "people", :action => "show", :id => "7"})
  1709. assert_equal "/people/7/destroy", url
  1710. end
  1711. def test_use_static_path_when_possible
  1712. set.draw do |map|
  1713. map.connect 'about', :controller => "welcome", :action => "about"
  1714. map.connect ':controller/:action/:id'
  1715. end
  1716. url = set.generate({:controller => "welcome", :action => "about"},
  1717. {:controller => "welcome", :action => "get", :id => "7"})
  1718. assert_equal "/about", url
  1719. end
  1720. def test_generate
  1721. set.draw { |map| map.connect ':controller/:action/:id' }
  1722. args = { :controller => "foo", :action => "bar", :id => "7", :x => "y" }
  1723. assert_equal "/foo/bar/7?x=y", set.generate(args)
  1724. assert_equal ["/foo/bar/7", [:x]], set.generate_extras(args)
  1725. assert_equal [:x], set.extra_keys(args)
  1726. end
  1727. def test_named_routes_are_never_relative_to_modules
  1728. set.draw do |map|
  1729. map.connect "/connection/manage/:action", :controller => 'connection/manage'
  1730. map.connect "/connection/connection", :controller => "connection/connection"
  1731. map.family_connection "/connection", :controller => "connection"
  1732. end
  1733. url = set.generate({:controller => "connection"}, {:controller => 'connection/manage'})
  1734. assert_equal "/connection/connection", url
  1735. url = set.generate({:use_route => :family_connection, :controller => "connection"}, {:controller => 'connection/manage'})
  1736. assert_equal "/connection", url
  1737. end
  1738. def test_action_left_off_when_id_is_recalled
  1739. set.draw do |map|
  1740. map.connect ':controller/:action/:id'
  1741. end
  1742. assert_equal '/post', set.generate(
  1743. {:controller => 'post', :action => 'index'},
  1744. {:controller => 'post', :action => 'show', :id => '10'}
  1745. )
  1746. end
  1747. def test_query_params_will_be_shown_when_recalled
  1748. set.draw do |map|
  1749. map.connect 'show_post/:parameter', :controller => 'post', :action => 'show'
  1750. map.connect ':controller/:action/:id'
  1751. end
  1752. assert_equal '/post/edit?parameter=1', set.generate(
  1753. {:action => 'edit', :parameter => 1},
  1754. {:controller => 'post', :action => 'show', :parameter => 1}
  1755. )
  1756. end
  1757. def test_expiry_determination_should_consider_values_with_to_param
  1758. set.draw { |map| map.connect 'projects/:project_id/:controller/:action' }
  1759. assert_equal '/projects/1/post/show', set.generate(
  1760. {:action => 'show', :project_id => 1},
  1761. {:controller => 'post', :action => 'show', :project_id => '1'})
  1762. end
  1763. def test_generate_all
  1764. set.draw do |map|
  1765. map.connect 'show_post/:id', :controller => 'post', :action => 'show'
  1766. map.connect ':controller/:action/:id'
  1767. end
  1768. all = set.generate(
  1769. {:action => 'show', :id => 10, :generate_all => true},
  1770. {:controller => 'post', :action => 'show'}
  1771. )
  1772. assert_equal 2, all.length
  1773. assert_equal '/show_post/10', all.first
  1774. assert_equal '/post/show/10', all.last
  1775. end
  1776. def test_named_route_in_nested_resource
  1777. set.draw do |map|
  1778. map.resources :projects do |project|
  1779. project.milestones 'milestones', :controller => 'milestones', :action => 'index'
  1780. end
  1781. end
  1782. request.path = "/projects/1/milestones"
  1783. request.method = :get
  1784. assert_nothing_raised { set.recognize(request) }
  1785. assert_equal("milestones", request.path_parameters[:controller])
  1786. assert_equal("index", request.path_parameters[:action])
  1787. end
  1788. def test_setting_root_in_namespace_using_symbol
  1789. assert_nothing_raised do
  1790. set.draw do |map|
  1791. map.namespace :admin do |admin|
  1792. admin.root :controller => 'home'
  1793. end
  1794. end
  1795. end
  1796. end
  1797. def test_setting_root_in_namespace_using_string
  1798. assert_nothing_raised do
  1799. set.draw do |map|
  1800. map.namespace 'admin' do |admin|
  1801. admin.root :controller => 'home'
  1802. end
  1803. end
  1804. end
  1805. end
  1806. def test_route_requirements_with_unsupported_regexp_options_must_error
  1807. assert_raises ArgumentError do
  1808. set.draw do |map|
  1809. map.connect 'page/:name', :controller => 'pages',
  1810. :action => 'show',
  1811. :requirements => {:name => /(david|jamis)/m}
  1812. end
  1813. end
  1814. end
  1815. def test_route_requirements_with_supported_options_must_not_error
  1816. assert_nothing_raised do
  1817. set.draw do |map|
  1818. map.connect 'page/:name', :controller => 'pages',
  1819. :action => 'show',
  1820. :requirements => {:name => /(david|jamis)/i}
  1821. end
  1822. end
  1823. assert_nothing_raised do
  1824. set.draw do |map|
  1825. map.connect 'page/:name', :controller => 'pages',
  1826. :action => 'show',
  1827. :requirements => {:name => / # Desperately overcommented regexp
  1828. ( #Either
  1829. david #The Creator
  1830. | #Or
  1831. jamis #The Deployer
  1832. )/x}
  1833. end
  1834. end
  1835. end
  1836. def test_route_requirement_recognize_with_ignore_case
  1837. set.draw do |map|
  1838. map.connect 'page/:name', :controller => 'pages',
  1839. :action => 'show',
  1840. :requirements => {:name => /(david|jamis)/i}
  1841. end
  1842. assert_equal({:controller => 'pages', :action => 'show', :name => 'jamis'}, set.recognize_path('/page/jamis'))
  1843. assert_raises ActionController::RoutingError do
  1844. set.recognize_path('/page/davidjamis')
  1845. end
  1846. assert_equal({:controller => 'pages', :action => 'show', :name => 'DAVID'}, set.recognize_path('/page/DAVID'))
  1847. end
  1848. def test_route_requirement_generate_with_ignore_case
  1849. set.draw do |map|
  1850. map.connect 'page/:name', :controller => 'pages',
  1851. :action => 'show',
  1852. :requirements => {:name => /(david|jamis)/i}
  1853. end
  1854. url = set.generate({:controller => 'pages', :action => 'show', :name => 'david'})
  1855. assert_equal "/page/david", url
  1856. assert_raises ActionController::RoutingError do
  1857. url = set.generate({:controller => 'pages', :action => 'show', :name => 'davidjamis'})
  1858. end
  1859. url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
  1860. assert_equal "/page/JAMIS", url
  1861. end
  1862. def test_route_requirement_recognize_with_extended_syntax
  1863. set.draw do |map|
  1864. map.connect 'page/:name', :controller => 'pages',
  1865. :action => 'show',
  1866. :requirements => {:name => / # Desperately overcommented regexp
  1867. ( #Either
  1868. david #The Creator
  1869. | #Or
  1870. jamis #The Deployer
  1871. )/x}
  1872. end
  1873. assert_equal({:controller => 'pages', :action => 'show', :name => 'jamis'}, set.recognize_path('/page/jamis'))
  1874. assert_equal({:controller => 'pages', :action => 'show', :name => 'david'}, set.recognize_path('/page/david'))
  1875. assert_raises ActionController::RoutingError do
  1876. set.recognize_path('/page/david #The Creator')
  1877. end
  1878. assert_raises ActionController::RoutingError do
  1879. set.recognize_path('/page/David')
  1880. end
  1881. end
  1882. def test_route_requirement_generate_with_extended_syntax
  1883. set.draw do |map|
  1884. map.connect 'page/:name', :controller => 'pages',
  1885. :action => 'show',
  1886. :requirements => {:name => / # Desperately overcommented regexp
  1887. ( #Either
  1888. david #The Creator
  1889. | #Or
  1890. jamis #The Deployer
  1891. )/x}
  1892. end
  1893. url = set.generate({:controller => 'pages', :action => 'show', :name => 'david'})
  1894. assert_equal "/page/david", url
  1895. assert_raises ActionController::RoutingError do
  1896. url = set.generate({:controller => 'pages', :action => 'show', :name => 'davidjamis'})
  1897. end
  1898. assert_raises ActionController::RoutingError do
  1899. url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
  1900. end
  1901. end
  1902. def test_route_requirement_generate_with_xi_modifiers
  1903. set.draw do |map|
  1904. map.connect 'page/:name', :controller => 'pages',
  1905. :action => 'show',
  1906. :requirements => {:name => / # Desperately overcommented regexp
  1907. ( #Either
  1908. david #The Creator
  1909. | #Or
  1910. jamis #The Deployer
  1911. )/xi}
  1912. end
  1913. url = set.generate({:controller => 'pages', :action => 'show', :name => 'JAMIS'})
  1914. assert_equal "/page/JAMIS", url
  1915. end
  1916. def test_route_requirement_recognize_with_xi_modifiers
  1917. set.draw do |map|
  1918. map.connect 'page/:name', :controller => 'pages',
  1919. :action => 'show',
  1920. :requirements => {:name => / # Desperately overcommented regexp
  1921. ( #Either
  1922. david #The Creator
  1923. | #Or
  1924. jamis #The Deployer
  1925. )/xi}
  1926. end
  1927. assert_equal({:controller => 'pages', :action => 'show', :name => 'JAMIS'}, set.recognize_path('/page/JAMIS'))
  1928. end
  1929. end
  1930. class RouteLoadingTest < Test::Unit::TestCase
  1931. def setup
  1932. routes.instance_variable_set '@routes_last_modified', nil
  1933. silence_warnings { Object.const_set :RAILS_ROOT, '.' }
  1934. ActionController::Routing::Routes.configuration_file = File.join(RAILS_ROOT, 'config', 'routes.rb')
  1935. @stat = stub_everything
  1936. end
  1937. def teardown
  1938. ActionController::Routing::Routes.configuration_file = nil
  1939. Object.send :remove_const, :RAILS_ROOT
  1940. end
  1941. def test_load
  1942. File.expects(:stat).returns(@stat)
  1943. routes.expects(:load).with(regexp_matches(/routes\.rb$/))
  1944. routes.reload
  1945. end
  1946. def test_no_reload_when_not_modified
  1947. @stat.expects(:mtime).times(2).returns(1)
  1948. File.expects(:stat).times(2).returns(@stat)
  1949. routes.expects(:load).with(regexp_matches(/routes\.rb$/)).at_most_once
  1950. 2.times { routes.reload }
  1951. end
  1952. def test_reload_when_modified
  1953. @stat.expects(:mtime).at_least(2).returns(1, 2)
  1954. File.expects(:stat).at_least(2).returns(@stat)
  1955. routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)
  1956. 2.times { routes.reload }
  1957. end
  1958. def test_bang_forces_reload
  1959. @stat.expects(:mtime).at_least(2).returns(1)
  1960. File.expects(:stat).at_least(2).returns(@stat)
  1961. routes.expects(:load).with(regexp_matches(/routes\.rb$/)).times(2)
  1962. 2.times { routes.reload! }
  1963. end
  1964. def test_adding_inflections_forces_reload
  1965. ActiveSupport::Inflector::Inflections.instance.expects(:uncountable).with('equipment')
  1966. routes.expects(:reload!)
  1967. ActiveSupport::Inflector.inflections { |inflect| inflect.uncountable('equipment') }
  1968. end
  1969. def test_load_with_configuration
  1970. routes.configuration_file = "foobarbaz"
  1971. File.expects(:stat).returns(@stat)
  1972. routes.expects(:load).with("foobarbaz")
  1973. routes.reload
  1974. end
  1975. private
  1976. def routes
  1977. ActionController::Routing::Routes
  1978. end
  1979. end
  1980. end